tree 263bc1ad86743e45f14c74e83cddef326330b578
parent b7ceefea77a246fe5c1dcd1b91bf6079d1b97c02
author Paul Jakma <paul@jakma.org> 1484822363 +0000
committer Paul Jakma <paul@quagga.net> 1485191979 +0000

lib: ensure vty buf is nul terminated and wrap puts to it with checks

* vty.c: Fix str* overruns in previous commit, which I reported to the
  author. Add bit more checking of updates to vty buffer.
  Swap VTY_BUFSIZ over to vty->max, as that should be the external API.
* vty.c: (vty_buf_assert) conditions that should always be assertable for
  vty buffer.
  (vty_buf_put) little wrapper to check char puts to vty input buffer,
  and unconditionally write nul at very end of buffer as guard.
  Won't always work, as some places use mem* to manipulate.
  (vty_self_insert{,_overwrite}) Length check needs to leave room for nul.
  Use vty_buf_put.
  (vty_insert_word_overwrite) Length check needs to leave room for nul.
  (*) Add vty_buf_assert calls.

Merging in fixes from Quentin Young <qlyoung@cumulusnetworks.com>