commit 81cce0185e23b6ecd2ab98ab34182901226bcf9e
author Stephen Hemminger <stephen.hemminger@vyatta.com> Tue Apr 28 14:28:00 2009 -0700
committer Paul Jakma <paul@quagga.net> Thu Jun 18 20:18:27 2009 +0100
tree 24a8fa282d80b9dab623bb26fbbec731c0c8b34a
parent 82f5ee1ead0aa83f83f918abfc3f5071741a56e5

[cleanup] Use correct buffer size for inet_ntop()

Don't need big buffer 1024 to hold IPV4 (INET_ADDRSTRLEN)
or IPv6 (INET6_ADDRSTRLEN) message.

zebra/interface.c

diff --git a/zebra/interface.c b/zebra/interface.c
index 9cbbf93..3e4867c 100644
--- a/zebra/interface.c
+++ b/zebra/interface.c
@@ -1513,7 +1513,6 @@
 {
   struct listnode *node;
   struct interface *ifp;
-  char buf[BUFSIZ];
 
   for (ALL_LIST_ELEMENTS_RO (iflist, node, ifp))
     {
@@ -1543,10 +1542,11 @@
 	  {
 	    if (CHECK_FLAG (ifc->conf, ZEBRA_IFC_CONFIGURED))
 	      {
+		char buf[INET6_ADDRSTRLEN];
 		p = ifc->address;
 		vty_out (vty, " ip%s address %s/%d",
 			 p->family == AF_INET ? "" : "v6",
-			 inet_ntop (p->family, &p->u.prefix, buf, BUFSIZ),
+			 inet_ntop (p->family, &p->u.prefix, buf, sizeof(buf)),
 			 p->prefixlen);
 
 		if (ifc->label)