2005-05-06 Paul Jakma <paul@dishone.st>
* (general) extern and static'ification of functions in code and
header.
Cleanup any definitions with unspecified arguments.
Add casts for callback assignments where the callback is defined,
typically, as passing void *, but the function being assigned has
some other pointer type defined as its argument, as gcc complains
about casts from void * to X* via function arguments.
Fix some old K&R style function argument definitions.
Add noreturn gcc attribute to some functions, as appropriate.
Add unused gcc attribute to some functions (eg ones meant to help
while debugging)
Add guard defines to headers which were missing them.
* command.c: (install_node) add const qualifier, still doesnt shut
up the warning though, because of the double pointer.
(cmp_node) ditto
* keychain.c: (key_str2time) Add GET_LONG_RANGE() macro, derived
fromn vty.h ones to fix some of the (long) < 0 warnings.
* thread.c: (various) use thread_empty
(cpu_record_hash_key) should cast to uintptr_t, a stdint.h type
* vty.h: Add VTY_GET_IPV4_ADDRESS and VTY_GET_IPV4_PREFIX so they
removed from ospfd/ospf_vty.h
* zebra.h: Move definition of ZEBRA_PORT to here, to remove
dependence of lib on zebra/zserv.h
diff --git a/lib/sockunion.c b/lib/sockunion.c
index 8a1fd9d..a636c64 100644
--- a/lib/sockunion.c
+++ b/lib/sockunion.c
@@ -273,7 +273,7 @@
}
/* Return sizeof union sockunion. */
-int
+static int
sockunion_sizeof (union sockunion *su)
{
int ret;
@@ -294,7 +294,7 @@
}
/* return sockunion structure : this function should be revised. */
-char *
+static char *
sockunion_log (union sockunion *su)
{
static char buf[SU_ADDRSTRLEN];
@@ -662,7 +662,7 @@
}
/* Print sockunion structure */
-void
+static void __attribute__ ((unused))
sockunion_print (union sockunion *su)
{
if (su == NULL)
@@ -701,7 +701,7 @@
}
#ifdef HAVE_IPV6
-int
+static int
in6addr_cmp (struct in6_addr *addr1, struct in6_addr *addr2)
{
unsigned int i;