ospf_apiserver_term:
Remove unused variable.
Add comment: this is seriously broken, and needs fixing. It appears
likely to segfault if ever called. Comments please - should I make
the fix I suggest in the comment? -gdt
diff --git a/ospfd/ospf_apiserver.c b/ospfd/ospf_apiserver.c
index 4f294f7..07b8f21 100644
--- a/ospfd/ospf_apiserver.c
+++ b/ospfd/ospf_apiserver.c
@@ -180,7 +180,7 @@
void
ospf_apiserver_term (void)
{
- struct listnode *node, *nnode;
+ struct listnode *node;
struct ospf_apiserver *apiserv;
/* Unregister wildcard [0/0] type */
@@ -189,6 +189,11 @@
/* Free all client instances */
while ( (node = listhead (apiserver_list)) != NULL)
+ /*
+ * XXX: this is just plain odd/wrong. Is there a missing
+ * apiserv = (struct ospf_apiserver *) node;
+ * ?
+ */
ospf_apiserver_free (apiserv);
/* Free client list itself */