commit 9499bf2bc6daf0a9b7170d3cf994daef2f1a8920
author Leonid Rosenboim <lrosenbo@wrs.com> Thu Dec 06 20:17:41 2012 +0000
committer David Lamparter <equinox@opensourcerouting.org> Mon Jan 14 16:07:25 2013 +0100
tree da0c36589c64c385b2f2ace17b92076febb9afe6
parent 15c713485699fd22dfa5b7ce3ca7c6be049f1033

zebra: don't overrun afi/safi array boundaries

zebra was not checking afi/safi values.  This was leading to crashes where
these values were coming directly from some protocol's on-wire fields.
Safeguarding them in zebra is a good start.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

zebra/zebra_rib.c

diff --git a/zebra/zebra_rib.c b/zebra/zebra_rib.c
index a75d721..4dd8551 100644
--- a/zebra/zebra_rib.c
+++ b/zebra/zebra_rib.c
@@ -155,6 +155,9 @@
   if (! vrf)
     return NULL;
 
+  if( afi >= AFI_MAX  || safi >= SAFI_MAX )
+    return NULL;
+
   return vrf->table[afi][safi];
 }
 
@@ -168,6 +171,9 @@
   if (! vrf)
     return NULL;
 
+  if( afi >= AFI_MAX  || safi >= SAFI_MAX )
+    return NULL;
+
   return vrf->stable[afi][safi];
 }