commit aa7dbb1067b7d02e1354fe1e5664ccb7d259d649
author Balaji <balajig81@gmail.com> Mon Mar 16 16:55:26 2015 +0000
committer David Lamparter <equinox@opensourcerouting.org> Tue Apr 14 12:04:29 2015 +0200
tree 43cc4818319a53e49a26f330952b37b417d44af9
parent 941789e470199df4f612368f669ecc0fd096fb9a

bgpd: Configured suppress value cannot be less than the reuse value in bgp dampening

RFC 2439, Section 4.2; the values pair up for hysteresis.

Signed-off-by: Balaji.G <balajig81@gmail.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd/bgp_route.c

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index e7357e5..f84a72d 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -11976,6 +11976,14 @@
     }
 
   bgp = vty->index;
+
+  if (suppress < reuse)
+    {
+      vty_out (vty, "Suppress value cannot be less than reuse value %s",
+                    VTY_NEWLINE);
+      return 0;
+    }
+
   return bgp_damp_enable (bgp, bgp_node_afi (vty), bgp_node_safi (vty),
 			  half, reuse, suppress, max);
 }