commit b9f1dca10f9a9bf853a9999a117c8cdeec5b7b69
author Jorge Boncompte [DTI2] <jorge@dti2.net> Mon May 07 16:53:01 2012 +0000
committer David Lamparter <equinox@opensourcerouting.org> Tue May 22 20:25:49 2012 +0200
tree b6382403ba177cb56f0ca6054db1ce32428fd7f2
parent 1a2fd7078f943e2207ee0f1b0dafdcd2d9c81925

bgpd: use on stack struct attr_extra in bgp_attr_unintern()

  Reduce memory heap fragmentation and pressure on the memory allocator.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd/bgp_attr.c

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 9749782..b63ac4c 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -657,6 +657,7 @@
   struct attr *attr = *pattr;
   struct attr *ret;
   struct attr tmp;
+  struct attr_extra tmp_extra;
   
   /* Decrement attribute reference. */
   attr->refcnt--;
@@ -665,7 +666,7 @@
   
   if (attr->extra)
     {
-      tmp.extra = bgp_attr_extra_new ();
+      tmp.extra = &tmp_extra;
       memcpy (tmp.extra, attr->extra, sizeof (struct attr_extra));
     }
   
@@ -680,7 +681,6 @@
     }
 
   bgp_attr_unintern_sub (&tmp);
-  bgp_attr_extra_free (&tmp);
 }
 
 void