Bug in ospf6_lsa_compare()
This fix is probably correct on 32bit systems,
but i think it will not work on 64bit systems.
sizeof(signed long) would be 8 and therefore the
cast from u_int32_t will map all the values to
non-negative part of long int.
You would like to use int (like in ospfd) and
change the type of seqnuma, seqnumb to that.
The type int32_t would be even more proper, but
sizeof(int) is 4 on relevant platforms.
Signed-off: Ondrej Zajicek <santiago@crfreenet.org>
Acked-by: Feng Lu <lu.feng@6wind.com>
Acked-by: Yasuhiro Ohara <yasu@jaist.ac.jp>
diff --git a/ospf6d/ospf6_lsa.c b/ospf6d/ospf6_lsa.c
index e57306b..8eeb995 100644
--- a/ospf6d/ospf6_lsa.c
+++ b/ospf6d/ospf6_lsa.c
@@ -306,7 +306,7 @@
int
ospf6_lsa_compare (struct ospf6_lsa *a, struct ospf6_lsa *b)
{
- int seqnuma, seqnumb;
+ int32_t seqnuma, seqnumb;
u_int16_t cksuma, cksumb;
u_int16_t agea, ageb;
@@ -314,8 +314,8 @@
assert (b && b->header);
assert (OSPF6_LSA_IS_SAME (a, b));
- seqnuma = (int) ntohl (a->header->seqnum);
- seqnumb = (int) ntohl (b->header->seqnum);
+ seqnuma = (int32_t) ntohl (a->header->seqnum);
+ seqnumb = (int32_t) ntohl (b->header->seqnum);
/* compare by sequence number */
if (seqnuma > seqnumb)