commit c0cad4368858d24caedd7e7d2bb776b6d4dd6eb3
author Ulrich Weber <ulrich.weber@sophos.com> Thu Nov 17 21:35:08 2011 +0400
committer Denis Ovsienko <infrastation@yandex.ru> Tue Dec 13 14:10:04 2011 +0400
tree f5d77cf7d32df711120749db6e23ef70852fcf3f
parent 5009160c748b19a543a2f4fbd01d9de69ca71955

ripngd: limit max of "timers basic" to 65535 as documented

and use VTY_GET_INTEGER_RANGE instead of calling strtoul

ripngd/ripngd.c

diff --git a/ripngd/ripngd.c b/ripngd/ripngd.c
index d416255..8e97c2f 100644
--- a/ripngd/ripngd.c
+++ b/ripngd/ripngd.c
@@ -2485,28 +2485,10 @@
   unsigned long update;
   unsigned long timeout;
   unsigned long garbage;
-  char *endptr = NULL;
 
-  update = strtoul (argv[0], &endptr, 10);
-  if (update == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "update timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
-  
-  timeout = strtoul (argv[1], &endptr, 10);
-  if (timeout == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "timeout timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
-  
-  garbage = strtoul (argv[2], &endptr, 10);
-  if (garbage == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "garbage timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
+  VTY_GET_INTEGER_RANGE("update timer", update, argv[0], 0, 65535);
+  VTY_GET_INTEGER_RANGE("timeout timer", timeout, argv[1], 0, 65535);
+  VTY_GET_INTEGER_RANGE("garbage timer", garbage, argv[2], 0, 65535);
 
   /* Set each timer value. */
   ripng->update_time = update;