bgpd: stop startup timer on stopping BGP (fixes dd49eb1)
bgp_delete() really needs to kill t_startup, otherwise after creating
and quickly destroying a BGP instance it may fire on a deallocated
struct bgp, overwriting memory.
Reported-by: Martin Winter <mwinter@netdef.org>
Fixes: dd49eb1 ("Fix BGP's use of restart bit.")
Cc: Vipin Kumar <vipin@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Acked-by: Vincent JARDIN <vincent.jardin@6wind.com>
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 79bcaaf..d72708e 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -2103,6 +2103,8 @@
afi_t afi;
int i;
+ THREAD_OFF (bgp->t_startup);
+
/* Delete static route. */
bgp_static_delete (bgp);