commit d9d4ae5157207b9b8bdb167983519a7ffb860f2c
author Stephen Hemminger <stephen@networkplumber.org> Wed Jan 13 00:32:39 2010 +0000
committer David Lamparter <equinox@opensourcerouting.org> Tue Jun 03 15:30:22 2014 +0200
tree 8919a83dcb99aac5fa0141f873525517d5e3b7ac
parent 8c71e481dae11b7ae3f1ef561a989624b2ae84b6

bgpd: fix crash when allowas-in is done on inactive peer

When allowas-in is changed on a peer that is not up, BGP would crash
trying to do route_refresh.  If peer is not up, there is no need
to do notification or send.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Feng Lu <lu.feng@6wind.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd/bgpd.c

diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 6a21b11..2fe300c 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -2293,6 +2293,9 @@
   if (CHECK_FLAG (peer->sflags, PEER_STATUS_GROUP))
     return;
 
+  if (peer->status != Established)
+    return;
+
   if (type == peer_change_reset)
     bgp_notify_send (peer, BGP_NOTIFY_CEASE,
 		     BGP_NOTIFY_CEASE_CONFIG_CHANGE);