commit e25a9741fb1ba52a69833687caa01f13cd4d1320
author Daniel Walton <dwalton@cumulusnetworks.com> Mon Nov 09 20:21:50 2015 -0500
committer Paul Jakma <paul.jakma@hpe.com> Tue Oct 04 13:07:52 2016 +0100
tree bc3eb6ea0e14e142095ada9a0dc44a3447dc009a
parent cb9ed1d867f6ac9e0bad85c47aabeb10b94be2e5

bgpd: don't count a route with an unreachable nexthop in PfxRcd

When a route is received from a peer that we cannot
reach do not count that route as a received route.

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd/bgp_route.c

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index eedb2a0..066637b 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -247,7 +247,7 @@
       || ri->peer == ri->peer->bgp->peer_self)
     return;
     
-  if (BGP_INFO_HOLDDOWN (ri)
+  if (!BGP_INFO_COUNTABLE (ri)
       && CHECK_FLAG (ri->flags, BGP_INFO_COUNTED))
     {
           
@@ -264,7 +264,7 @@
           zlog_warn ("%s: Please report to Quagga bugzilla", __func__);
         }      
     }
-  else if (!BGP_INFO_HOLDDOWN (ri) 
+  else if (BGP_INFO_COUNTABLE (ri)
            && !CHECK_FLAG (ri->flags, BGP_INFO_COUNTED))
     {
       SET_FLAG (ri->flags, BGP_INFO_COUNTED);
@@ -281,8 +281,8 @@
 {
   SET_FLAG (ri->flags, flag);
   
-  /* early bath if we know it's not a flag that changes useability state */
-  if (!CHECK_FLAG (flag, BGP_INFO_VALID|BGP_INFO_UNUSEABLE))
+  /* early bath if we know it's not a flag that changes countability state */
+  if (!CHECK_FLAG (flag, BGP_INFO_VALID|BGP_INFO_HISTORY|BGP_INFO_REMOVED))
     return;
   
   bgp_pcount_adjust (rn, ri);
@@ -293,8 +293,8 @@
 {
   UNSET_FLAG (ri->flags, flag);
   
-  /* early bath if we know it's not a flag that changes useability state */
-  if (!CHECK_FLAG (flag, BGP_INFO_VALID|BGP_INFO_UNUSEABLE))
+  /* early bath if we know it's not a flag that changes countability state */
+  if (!CHECK_FLAG (flag, BGP_INFO_VALID|BGP_INFO_HISTORY|BGP_INFO_REMOVED))
     return;
   
   bgp_pcount_adjust (rn, ri);

bgpd/bgp_route.h

diff --git a/bgpd/bgp_route.h b/bgpd/bgp_route.h
index 2a72daa..332714c 100644
--- a/bgpd/bgp_route.h
+++ b/bgpd/bgp_route.h
@@ -139,6 +139,10 @@
   u_char tag[3];
 };
 
+#define BGP_INFO_COUNTABLE(BI) \
+  (! CHECK_FLAG ((BI)->flags, BGP_INFO_HISTORY) \
+   && ! CHECK_FLAG ((BI)->flags, BGP_INFO_REMOVED))
+
 /* Flags which indicate a route is unuseable in some form */
 #define BGP_INFO_UNUSEABLE \
   (BGP_INFO_HISTORY|BGP_INFO_DAMPED|BGP_INFO_REMOVED)