ospfd: Remove the blocking of opaque LSAs origination & flooding 'optimisation'
* Opaque support contains some kind of hack/optimisation to
origination/flooding to suppress some origins/floods until an opaque LS
Acks are received. Previous versions of the code have already been shown
to have bugs in them (see e16fd8a5, e.g.). It seems over-complex and fragile,
plus its conceptually the wrong place to try implement flooding hacks that,
AFAICT, do not depend particularly on the semantics of opaque LSA.
Nuke.
Tested-by: Olivier Dugeon <olivier.dugeon@orange.com>
diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c
index b97e3a7..d597653 100644
--- a/ospfd/ospf_packet.c
+++ b/ospfd/ospf_packet.c
@@ -2125,14 +2125,7 @@
lsr = ospf_ls_retransmit_lookup (nbr, lsa);
if (lsr != NULL && ospf_lsa_more_recent (lsr, lsa) == 0)
- {
-#ifdef HAVE_OPAQUE_LSA
- if (IS_OPAQUE_LSA (lsr->data->type))
- ospf_opaque_ls_ack_received (nbr, lsr);
-#endif /* HAVE_OPAQUE_LSA */
-
- ospf_ls_retransmit_delete (nbr, lsr);
- }
+ ospf_ls_retransmit_delete (nbr, lsr);
lsa->data = NULL;
ospf_lsa_discard (lsa);