tree e1825968b9d0f7208b93944980331179456b7625
parent 969d3550a8cbb07f8b4d5ebe8dde5064f8260140
author Joakim Tjernlund <Joakim.Tjernlund@transmode.se> 1259238187 +0000
committer Vincent JARDIN <vincent.jardin@6wind.com> 1414421879 +0100

ospfd: invalid MD5 auth_key?

This looks fishy in ospf_make_md5_digest()
if (list_isempty (OSPF_IF_PARAM (oi, auth_crypt)))
    auth_key = (const u_int8_t *) "";
...
MD5Update(&ctx, auth_key, OSPF_AUTH_MD5_SIZE);
auth_key points to a "" string of len 1 which is a lot
smaller that OSPF_AUTH_MD5_SIZE. Is this intentional to
get some random data or just a plain bug?

Anyone using MD5 should have a closer look and decide
what to do.
Acked-by: Feng Lu <lu.feng@6wind.com>