From: kamatchi soundaram <kamatchi@tdd.sj.nec.com>
Subject: [zebra 19262] Re: Memory leak in OSPF
Fix applied for Kamatchi's original report was to remove the auth_crypt
initialisation from the wrong function. This should fix that.
diff --git a/ospfd/ospf_interface.c b/ospfd/ospf_interface.c
index 9f566a4..83abf55 100644
--- a/ospfd/ospf_interface.c
+++ b/ospfd/ospf_interface.c
@@ -489,6 +489,8 @@
UNSET_IF_PARAM (oip, auth_simple);
UNSET_IF_PARAM (oip, auth_crypt);
UNSET_IF_PARAM (oip, auth_type);
+
+ oip->auth_crypt = list_new ();
return oip;
}
@@ -623,9 +625,6 @@
SET_IF_PARAM (IF_DEF_PARAMS (ifp), auth_simple);
memset (IF_DEF_PARAMS (ifp)->auth_simple, 0, OSPF_AUTH_SIMPLE_SIZE);
- SET_IF_PARAM (IF_DEF_PARAMS (ifp), auth_crypt);
- IF_DEF_PARAMS (ifp)->auth_crypt = list_new ();
-
SET_IF_PARAM (IF_DEF_PARAMS (ifp), auth_type);
IF_DEF_PARAMS (ifp)->auth_type = OSPF_AUTH_NOTSET;