commit 5c6eeac8f0350fd6b14cf226ffcff655f1dd9582
author David Pursehouse <david.pursehouse@sonymobile.com> Thu Oct 11 16:44:48 2012 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Mon Oct 22 12:30:14 2012 +0900
tree 3225695b9d2a97342a49127717ea5e2bc5935a63
parent e98607248eec2b149d84efe944c12cbef419b82e

More coding style cleanup

Fixing more issues found with pylint.  Some that were supposed to
have been fixed in the previous sweep (Ie0db839e) but were missed:

C0321: More than one statement on a single line
W0622: Redefining built-in 'name'

And some more:

W0631: Using possibly undefined loop variable 'name'
W0223: Method 'name' is abstract in class 'name' but is not overridden
W0231: __init__ method from base class 'name' is not called

Change-Id: Ie119183708609d6279e973057a385fde864230c3

manifest_xml.py

diff --git a/manifest_xml.py b/manifest_xml.py
index 1207244..04cabaa 100644
--- a/manifest_xml.py
+++ b/manifest_xml.py
@@ -321,7 +321,8 @@
       raise ManifestParseError("no <manifest> in %s" % (path,))
 
     nodes = []
-    for node in manifest.childNodes:
+    for node in manifest.childNodes:  # pylint:disable-msg=W0631
+                                      # We only get here if manifest is initialised
         if node.nodeName == 'include':
             name = self._reqatt(node, 'name')
             fp = os.path.join(include_root, name)