commit 76ca9f8145f367f83df19981da4dd934fdda471b
author Shawn O. Pearce <sop@google.com> Sat Apr 18 14:48:03 2009 -0700
committer Shawn O. Pearce <sop@google.com> Sat Apr 18 14:48:03 2009 -0700
tree d6c095928fd2b1131972206b3c3f498843a736a6
parent accc56d82b902e7c7a22401db710958fcb1c7b58

Make usage of open safer by setting binary mode and closing fds

Signed-off-by: Shawn O. Pearce <sop@google.com>

editor.py

diff --git a/editor.py b/editor.py
index a297470..34c9ad1 100644
--- a/editor.py
+++ b/editor.py
@@ -78,7 +78,11 @@
 
       if subprocess.Popen(editor + [path]).wait() != 0:
         raise EditorError()
-      return open(path).read()
+      fd = open(path)
+      try:
+        return read()
+      finally:
+        fd.close()
     finally:
       if fd:
         os.close(fd)