Make usage of open safer by setting binary mode and closing fds
Signed-off-by: Shawn O. Pearce <sop@google.com>
diff --git a/project.py b/project.py
index 8d6e4b6..0a761ef 100644
--- a/project.py
+++ b/project.py
@@ -1070,9 +1070,7 @@
rev = self.GetRemote(self.remote.name).ToLocal(self.revision)
rev = self.bare_git.rev_parse('%s^0' % rev)
- f = open(os.path.join(dotgit, HEAD), 'wb')
- f.write("%s\n" % rev)
- f.close()
+ _lwrite(os.path.join(dotgit, HEAD), '%s\n' % rev)
cmd = ['read-tree', '--reset', '-u']
cmd.append('-v')
@@ -1167,7 +1165,11 @@
path = os.path.join(self._project.gitdir, HEAD)
else:
path = os.path.join(self._project.worktree, '.git', HEAD)
- line = open(path, 'r').read()
+ fd = open(path, 'rb')
+ try:
+ line = fd.read()
+ finally:
+ fd.close()
if line.startswith('ref: '):
return line[5:-1]
return line[:-1]