commit 8a68ff96057ec58e524a3e41a2d8dca7b5d016bc
author David Pursehouse <david.pursehouse@sonymobile.com> Mon Sep 24 12:15:13 2012 +0900
committer Gustaf Lundh <gustaf.lundh@sonymobile.com> Tue Oct 09 12:45:30 2012 +0200
tree 22f6971e8d3c4a90d11d3704602d073a852328b4
parent e3b1c45aebed329cbc9ad172b1d8e812cf208117

Coding style cleanup

Fix the following issues reported by pylint:

C0321: More than one statement on a single line
W0622: Redefining built-in 'name'
W0612: Unused variable 'name'
W0613: Unused argument 'name'
W0102: Dangerous default value 'value' as argument
W0105: String statement has no effect

Also fixed a few cases of inconsistent indentation.

Change-Id: Ie0db839e7c57d576cff12d8c055fe87030d00744

manifest_xml.py

diff --git a/manifest_xml.py b/manifest_xml.py
index a6364a7..1207244 100644
--- a/manifest_xml.py
+++ b/manifest_xml.py
@@ -113,7 +113,7 @@
       if os.path.exists(self.manifestFile):
         os.remove(self.manifestFile)
       os.symlink('manifests/%s' % name, self.manifestFile)
-    except OSError, e:
+    except OSError:
       raise ManifestParseError('cannot link manifest %s' % name)
 
   def _RemoteToXml(self, r, doc, root):
@@ -589,7 +589,6 @@
     groups.extend(set(default_groups).difference(groups))
 
     if self.IsMirror:
-      relpath = None
       worktree = None
       gitdir = os.path.join(self.topdir, '%s.git' % name)
     else: