commit cd892a38a61e2cb5975189a8f6e61fe1cd72d2c1
author Renaud Paquay <rpaquay@google.com> Thu Nov 03 15:59:05 2016 -0700
committer Renaud Paquay <rpaquay@google.com> Thu Aug 31 13:49:49 2017 -0700
tree 893d07c27770c4376f9e4a78395fc944761dd032
parent 010fed771183c23c0e7d04a4e7292782f68de9db

Allow quotes in editor command on Windows

This change allows setting the EDITOR env. variable to point to a
program location that contains quotes and spaces.

For example:

> set EDITOR="C:\Program Files (x86)\Notepad++\notepad++.exe" -multiInst -nosession
> repo upload

Change-Id: Ic95b00f7443982b1956a2992d0220e50b1cf6bbb

editor.py

diff --git a/editor.py b/editor.py
index 96d7ce4..7980f2b 100644
--- a/editor.py
+++ b/editor.py
@@ -83,7 +83,12 @@
       os.close(fd)
       fd = None
 
-      if re.compile("^.*[$ \t'].*$").match(editor):
+      if platform_utils.isWindows():
+        # Split on spaces, respecting quoted strings
+        import shlex
+        args = shlex.split(editor)
+        shell = False
+      elif re.compile("^.*[$ \t'].*$").match(editor):
         args = [editor + ' "$@"', 'sh']
         shell = True
       else: