commit f97e72e5ddfcd34400aba384775b793170044f5c
author Xin Li <delphij@google.com> Fri Jun 24 12:17:14 2016 -0700
committer Xin Li <delphij@google.com> Wed Jun 29 11:01:43 2016 -0700
tree cd904224470fe41af46ebbf1e5894377d8d0088c
parent faaddc9b4e4c6f6cbac02e90415676fabd177b99

Bail out when manifest is referencing a bad SHA-1 revision.

BUG: Issue 222
Change-Id: Ie0a64b39922d6fdf1be2989eb514985be8490278

gitc_utils.py

diff --git a/gitc_utils.py b/gitc_utils.py
index a388dc2..7a35e7a 100644
--- a/gitc_utils.py
+++ b/gitc_utils.py
@@ -24,6 +24,8 @@
 import git_config
 import wrapper
 
+from error import ManifestParseError
+
 NUM_BATCH_RETRIEVE_REVISIONID = 300
 
 def get_gitc_manifest_dir():
@@ -54,7 +56,11 @@
     if gitcmd.Wait():
       print('FATAL: Failed to retrieve revisionExpr for %s' % proj)
       sys.exit(1)
-    proj.revisionExpr = gitcmd.stdout.split('\t')[0]
+    revisionExpr = gitcmd.stdout.split('\t')[0]
+    if not revisionExpr:
+      raise(ManifestParseError('Invalid SHA-1 revision project %s (%s)' %
+                               (proj.remote.url, proj.revisionExpr)))
+    proj.revisionExpr = revisionExpr
 
 def _manifest_groups(manifest):
   """Returns the manifest group string that should be synced