Enhance Submitting Code section
overview/contributing.rst
overview/contributing/code_review.rst
overview/contributing/copyright.rst
overview/contributing/jira_tickets.rst
howto/code/commit-message.rst
howto/code/pull_request.rst
--------------------------------------
- Document a few items that surfaced in code reviews this morning.
- Add more links to existing documentation.
howto/release/repositories/pod-configs/
howto/release/repositories/voltha-onos/release.rst
howto/release/repositories/voltha-onos/todo.rst
--------------------------------------------------
- Create skeleton directories for documenting release items needed.
- Submitted as part of an earlier patch but included here for good measure.
Change-Id: Ibe118570bdf19ced1d06d6e9efb10fd1419f82ef
diff --git a/howto/code/commit-message.rst b/howto/code/commit-message.rst
index f18f8b3..e4d18a8 100644
--- a/howto/code/commit-message.rst
+++ b/howto/code/commit-message.rst
@@ -6,11 +6,15 @@
- First line in a commit message is special.
- 50 cpl max to avoid complaints about length.
- Mention a jira ticket (VOL-xxxx) and the ticket will receive status updates from jenkins.
+- Additional jira ticket dependencies can be listed on line 3+
.. code:: bash
[VOL-5048] - Build and deploy for VOLTHA v2.12 release.
+ [VOL-5049]
+ [VOL-5050]
+
api/pom.xml
app/pom.xml
pom.xml
diff --git a/howto/code/pull_request.rst b/howto/code/pull_request.rst
index f3c1c58..b02b992 100644
--- a/howto/code/pull_request.rst
+++ b/howto/code/pull_request.rst
@@ -9,6 +9,8 @@
:ref:`Commit message syntax <pull-request--commit-message>`
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+- `Working url (branch=master fallback) <https://docs.voltha.org/master/howto/code/commit-message.html#pull-request-commit-message>`_
+
Job directives: recheck
-----------------------
@@ -18,7 +20,34 @@
- Visit gerrit: https://gerrit.opencord.org/c/bbsim/+/34384
- Click the pencil icon in the top left by reviewers.
-- Comment/description text: recheck
+- Comment/description text: ``recheck``
It may take a little while to run dependent on queue size but this token will
initiate re-running job phases for a patch.
+
+Code Review Request
+-------------------
+
+A code review can be requested in two ways, interactively when a patch is
+created or from the gerrit UI. Item of note, gerrit will also automatically
+assign reviewers based on volume of commits to an individual repository so
+you may have reviewers w/o explicitly requesting one.
+
+Interactively using git
+-----------------------
+
+- Create a patch, rebase/merge as needed.
+- git review to create a pull request.
+
+ - From the command line, include argument --reviewers
+ - git review --reviewers tux@onf.org foo@onf.org bar@onf.org
+ - People will be notified via email about the review request.
+
+Manually add reviewers at a later date
+--------------------------------------
+
+- `Naviagate to your patch in gerrit <https://gerrit.opencord.org/c/bbsim/+/34384>`_
+- Click the pencil icon in the top left by reviewers.
+- Add community members to request a review.
+
+