VOL-1577 - General cleanup (gofmt, go vet, go test, dep check)
Change-Id: I536b2746b8bd266f3e75aeccc65bfe7468f1b44a
diff --git a/ro_core/core/core.go b/ro_core/core/core.go
index 5825574..90aadae 100644
--- a/ro_core/core/core.go
+++ b/ro_core/core/core.go
@@ -21,8 +21,8 @@
"github.com/opencord/voltha-go/common/log"
"github.com/opencord/voltha-go/db/kvstore"
"github.com/opencord/voltha-go/db/model"
- "github.com/opencord/voltha-protos/go/voltha"
"github.com/opencord/voltha-go/ro_core/config"
+ "github.com/opencord/voltha-protos/go/voltha"
"google.golang.org/grpc"
)
diff --git a/ro_core/core/device_agent.go b/ro_core/core/device_agent.go
index ca70d48..dfaf767 100644
--- a/ro_core/core/device_agent.go
+++ b/ro_core/core/device_agent.go
@@ -202,4 +202,4 @@
return device.GetImages(), nil
}
return nil, status.Errorf(codes.NotFound, "device-%s", agent.deviceId)
-}
\ No newline at end of file
+}
diff --git a/ro_core/core/device_manager.go b/ro_core/core/device_manager.go
index 9e67b72..f3a1f6c 100644
--- a/ro_core/core/device_manager.go
+++ b/ro_core/core/device_manager.go
@@ -176,7 +176,7 @@
if agent := dMgr.getDeviceAgent(deviceId); agent != nil {
return agent, nil
}
- return nil, status.Error(codes.NotFound, deviceId) // This should nto happen
+ return nil, status.Error(codes.NotFound, deviceId) // This should nto happen
}
// loadRootDeviceParentAndChildren loads the children and parents of a root device in memory
@@ -393,4 +393,3 @@
}
return childDeviceIds, nil
}
-
diff --git a/ro_core/core/grpc_nbi_api_handler.go b/ro_core/core/grpc_nbi_api_handler.go
index 8338507..6d50e9e 100644
--- a/ro_core/core/grpc_nbi_api_handler.go
+++ b/ro_core/core/grpc_nbi_api_handler.go
@@ -266,7 +266,7 @@
//@TODO useless stub, what should this actually do?
func (handler *APIHandler) GetMeterStatsOfLogicalDevice(
- ctx context.Context,
+ ctx context.Context,
in *common.ID,
) (*openflow_13.MeterStatsReply, error) {
log.Debug("GetMeterStatsOfLogicalDevice-stub")
@@ -275,8 +275,8 @@
//@TODO useless stub, what should this actually do?
func (handler *APIHandler) GetMibDeviceData(
- ctx context.Context,
- in *common.ID,
+ ctx context.Context,
+ in *common.ID,
) (*omci.MibDeviceData, error) {
log.Debug("GetMibDeviceData-stub")
return nil, nil
@@ -299,4 +299,3 @@
log.Debug("UpdateLogicalDeviceMeterTable-stub")
return nil, nil
}
-
diff --git a/ro_core/core/logical_device_manager.go b/ro_core/core/logical_device_manager.go
index 846df63..05b494a 100644
--- a/ro_core/core/logical_device_manager.go
+++ b/ro_core/core/logical_device_manager.go
@@ -219,5 +219,5 @@
return port, nil
}
}
- return nil, status.Errorf(codes.NotFound, "%s-$s", lPortId.Id, lPortId.PortId)
+ return nil, status.Errorf(codes.NotFound, "%s-%s", lPortId.Id, lPortId.PortId)
}
diff --git a/ro_core/core/model_proxy_manager.go b/ro_core/core/model_proxy_manager.go
index 6db4bef..e766b71 100644
--- a/ro_core/core/model_proxy_manager.go
+++ b/ro_core/core/model_proxy_manager.go
@@ -38,7 +38,7 @@
)
// String equivalent for data path agents
-var commonTypes = []string {
+var commonTypes = []string{
"Adapters",
"AlarmFilters",
"CoreInstances",
diff --git a/ro_core/main.go b/ro_core/main.go
index f80c77e..97015d4 100644
--- a/ro_core/main.go
+++ b/ro_core/main.go
@@ -22,9 +22,9 @@
grpcserver "github.com/opencord/voltha-go/common/grpc"
"github.com/opencord/voltha-go/common/log"
"github.com/opencord/voltha-go/db/kvstore"
- ic "github.com/opencord/voltha-protos/go/inter_container"
"github.com/opencord/voltha-go/ro_core/config"
c "github.com/opencord/voltha-go/ro_core/core"
+ ic "github.com/opencord/voltha-protos/go/inter_container"
"os"
"os/signal"
"strconv"