tree e421c3f5a3c3986c7e74c14356c5768e589236c3
parent 13647a8baa066a7f29fa33e4b8000cc4d44b798c
author Joey Armstrong <joey@opennetworking.org> 1707256839 -0500
committer Joey Armstrong <joey@opennetworking.org> 1707317479 -0500

[VOL-5272] Check on code review input from Mirko D

[VOL-5031] - original ticket

app-install.sh
--------------
  o Fixed a typo in parsed path:
    + use names="${names[0]}" to extract path from sed command output.
    + Inline comments showing input string and names array variable.

  o Screen sources with latest shellcheck v0.9.0.
  o Replace cd $HERE && cd $APP_ROOT with {pushd,popd} and error checking.

  o Usability enhancements to improve log readability:
    + func init: validate and display envionment vars used.
    + Display banners and whitespace to breakup a long stream
      of artifact copying and unpacking.

  o Add simple getopts command line switches to enable --debug mode.

  o Replace "cp -v" with "rsync --checksum"
    + Adds error checking, detect bit flip.
    + Only copy files when needed.

Dockerfile.voltha-onos
----------------------
  o Install rsync command, mia from the base docker image.
  o Display command version installed for rsync and unzip.

Change-Id: Ief6ca6bf381394d6a50e6bb17037228a2fe2041a