Gitiles
Code Review Sign In
gerrit.opencord.org / voltha-openolt-adapter / 8da2f066b0b641b37953b39cf40a768c5cf3528a
commit8da2f066b0b641b37953b39cf40a768c5cf3528a[log] [tgz]
authorJoey Armstrong <jarmstrong@linuxfoundation.org>Wed May 01 18:25:00 2024 -0400
committerJoey Armstrong <jarmstrong@linuxfoundation.org>Fri May 03 17:41:39 2024 -0400
tree521846040b9f8b4086a137b45926d881ba95d1bb
parent098137bbced8793a5029855946a045430e4942b1 [diff]
[VOL-5337] - Add pre-commit tool for enahnced linting.

requirements.txt
.pre-commit-config.yaml
=======================
  o Install tool dependencies.

Change-Id: I5fa5ed35f24a72656ac84f9f57303f8389c877d5
3 files changed
tree: 521846040b9f8b4086a137b45926d881ba95d1bb
  1. .gitignore
  2. .gitreview
  3. .golangci.yml
  4. .pre-commit-config.yaml
  5. CODE_OF_CONDUCT.md
  6. Makefile
  7. README.md
  8. VERSION
  9. cmd/
  10. compose/
  11. config.mk
  12. docker/
  13. go.mod
  14. go.sum
  15. internal/
  16. makefiles/
  17. pkg/
  18. requirements.txt
  19. vendor/
README.md

OpenOLT adapter

The OpenOLT adapter connects the VOLTHA core to an OLT device running the OpenOLT agent.

Development make targets

The Makefile contains many commands that are useful in development:

% make help

build                     : Alias for 'docker build'
clean                     : Removes any local filesystem artifacts generated by a build
distclean                 : Removes any local filesystem artifacts generated by a build or test run
docker-build-profile      : Build openolt adapter docker image with profiling enabled
docker-build              : Build openolt adapter docker image
docker-kind-load          : Load docker images into a KinD cluster
docker-push               : Push the docker images to an external repository
help                      : Print help for each Makefile target
lint-dockerfile           : Perform static analysis on Dockerfile
lint-mod                  : Verify the Go dependencies
lint                      : Run all lint targets
local-lib-go              : Copies a local version of the voltha-lib-go dependency into the vendor directory
local-protos              : Copies a local version of the voltha-protos dependency into the vendor directory
mod-update                : Update go mod files
sca                       : Runs static code analysis with the golangci-lint tool
test                      : Run unit tests

Some highlights:

  • It's recommended that you run the lint, sca, and test targets before submitting code changes.

  • The docker-* targets for building and pushing Docker images depend on the variables DOCKER_REGISTRY, DOCKER_REPOSITORY, and DOCKER_TAG as described in the CORD documentation

  • If you make changes the dependencies in the go.mod file, you will need to run make mod-update to update the go.sum and vendor directory.

Building with a Local Copy of voltha-protos or voltha-lib-go

If you want to build/test using a local copy of the voltha-protos or voltha-lib-go libraries this can be accomplished by using the environment variables LOCAL_PROTOS and LOCAL_LIB_GO. These environment variables should be set to the filesystem path where the local source is located, e.g.:

export LOCAL_PROTOS=/path/to/voltha-protos
export LOCAL_LIB_GO=/path/to/voltha-lib-go

Then run make local-protos and/or make local-lib-go as is appropriate to copy them into the vendor directory.

NOTE: That the files in the vendor directory are no longer what is in the most recent commit, and it will take manual git intervention to put the original files back.