Gitiles
Code Review Sign In
gerrit.opencord.org / voltha-openolt-adapter / a087056d8d05da888ffc6b5ba28f702b5237f888
commita087056d8d05da888ffc6b5ba28f702b5237f888[log] [tgz]
authorGirish Gowdra <girish@opennetworking.org>Thu Mar 11 14:30:14 2021 -0800
committerGirish Gowdra <girish@opennetworking.org>Thu Mar 11 16:28:43 2021 -0800
tree755c5477cfa4f53fbe9b71716a88e830954cec00
parent7650be66f82e8ec3e571be3538cce3a5b96c3b72 [diff]
VOL-3896: ONU fails to activate again if ONU is deleted after OLT disable
- When OLT is disabled the local cache of child devices are cleared in openolt adapter.
  If ONU delete were triggered post OLT disable, the openolt adapter does not
  have relevant information (esp. ONU serial number) in Child_device_lost API
  call to pass down to OLT agent to delete the ONU context. The local cache too is void
  of this information as it was cleared on OLT disable.
  A possible fix is to pass down the entire ONU Device struct in Child_device_lost
  API which contains all the relevant information to clear the ONU context on the OLT.

Change-Id: I76e28a0a46c1c82b25c859160466abfff693ed09
7 files changed
tree: 755c5477cfa4f53fbe9b71716a88e830954cec00
  1. .gitignore
  2. .gitreview
  3. .golangci.yml
  4. CODE_OF_CONDUCT.md
  5. Makefile
  6. README.md
  7. VERSION
  8. cmd/
  9. compose/
  10. docker/
  11. go.mod
  12. go.sum
  13. internal/
  14. pkg/
  15. vendor/
README.md

OpenOLT adapter

The OpenOLT adapter connects the VOLTHA core to an OLT device running the OpenOLT agent.

Development make targets

The Makefile contains many commands that are useful in development:

build                     : Alias for 'docker build'
clean                     : Removes any local filesystem artifacts generated by a build
distclean                 : Removes any local filesystem artifacts generated by a build or test run
docker-build-profile      : Build openolt adapter docker image with profiling enabled
docker-build              : Build openolt adapter docker image
docker-kind-load          : Load docker images into a KinD cluster
docker-push               : Push the docker images to an external repository
help                      : Print help for each Makefile target
lint-dockerfile           : Perform static analysis on Dockerfile
lint-mod                  : Verify the Go dependencies
lint                      : Run all lint targets
local-lib-go              : Copies a local version of the voltha-lib-go dependency into the vendor directory
local-protos              : Copies a local version of the voltha-protos dependency into the vendor directory
mod-update                : Update go mod files
sca                       : Runs static code analysis with the golangci-lint tool
test                      : Run unit tests

Some highlights:

  • It's recommended that you run the lint, sca, and test targets before submitting code changes.

  • The docker-* targets for building and pushing Docker images depend on the variables DOCKER_REGISTRY, DOCKER_REPOSITORY, and DOCKER_TAG as described in the CORD documentation

  • If you make changes the dependencies in the go.mod file, you will need to run make mod-update to update the go.sum and vendor directory.

Building with a Local Copy of voltha-protos or voltha-lib-go

If you want to build/test using a local copy of the voltha-protos or voltha-lib-go libraries this can be accomplished by using the environment variables LOCAL_PROTOS and LOCAL_LIB_GO. These environment variables should be set to the filesystem path where the local source is located, e.g.:

export LOCAL_PROTOS=/path/to/voltha-protos
export LOCAL_LIB_GO=/path/to/voltha-lib-go

Then run make local-protos and/or make local-lib-go as is appropriate to copy them into the vendor directory.

NOTE: That the files in the vendor directory are no longer what is in the most recent commit, and it will take manual git intervention to put the original files back.