commit | a3b7c59196608acab3294f4ec4231a320319e4fe | [log] [tgz] |
---|---|---|
author | Joey Armstrong <joey@opennetworking.org> | Mon Dec 11 17:56:05 2023 -0500 |
committer | Joey Armstrong <joey@opennetworking.org> | Fri Dec 22 00:05:15 2023 -0500 |
tree | 8b0fd694e157ed4d9e5d0bd600bd40350aebb479 | |
parent | 1992f9986f754ca3ad7d3b70a0c18c3b10efb08b [diff] |
[VOL-5146] voltha-openolt-adapter failure cmd/openolt-adapter/common.go pkg/mocks/common.go ----------------------------- o Bogus job uncovered sca lint failures, files lack newline at EOF. o Run gofmt -e -s -w to update files and commit the repair. makefiles/golang/include.mk makefiles/golang/beautify.mk ---------------------------- o Added target beautify-golang as a convenience for invoking gofmat. o Logic also added in repo:onf-make VERSION ------- o Version file incremented per code review input. cmd/openolt-adapter/common.go internal/pkg/core/common.go pkg/mocks/common.go compose/adapters-openolt-go.yml ------------------------------- o Bogus patch. o Cosmetic edits to trigger a job, see if adapter failure still reported. Change-Id: I5f4b606126b9bf622bae5c115b231a48d5205f10
The OpenOLT adapter connects the VOLTHA core to an OLT device running the OpenOLT agent.
make
targetsThe Makefile
contains many commands that are useful in development:
% make help build : Alias for 'docker build' clean : Removes any local filesystem artifacts generated by a build distclean : Removes any local filesystem artifacts generated by a build or test run docker-build-profile : Build openolt adapter docker image with profiling enabled docker-build : Build openolt adapter docker image docker-kind-load : Load docker images into a KinD cluster docker-push : Push the docker images to an external repository help : Print help for each Makefile target lint-dockerfile : Perform static analysis on Dockerfile lint-mod : Verify the Go dependencies lint : Run all lint targets local-lib-go : Copies a local version of the voltha-lib-go dependency into the vendor directory local-protos : Copies a local version of the voltha-protos dependency into the vendor directory mod-update : Update go mod files sca : Runs static code analysis with the golangci-lint tool test : Run unit tests
Some highlights:
It's recommended that you run the lint
, sca
, and test
targets before submitting code changes.
The docker-*
targets for building and pushing Docker images depend on the variables DOCKER_REGISTRY
, DOCKER_REPOSITORY
, and DOCKER_TAG
as described in the CORD documentation
If you make changes the dependencies in the go.mod
file, you will need to run make mod-update
to update the go.sum
and vendor
directory.
voltha-protos
or voltha-lib-go
If you want to build/test using a local copy of the voltha-protos
or voltha-lib-go
libraries this can be accomplished by using the environment variables LOCAL_PROTOS
and LOCAL_LIB_GO
. These environment variables should be set to the filesystem path where the local source is located, e.g.:
export LOCAL_PROTOS=/path/to/voltha-protos export LOCAL_LIB_GO=/path/to/voltha-lib-go
Then run make local-protos
and/or make local-lib-go
as is appropriate to copy them into the vendor
directory.
NOTE: That the files in the
vendor
directory are no longer what is in the most recent commit, and it will take manualgit
intervention to put the original files back.