commit | d8844c41b9cfabc49c046b4985ca4a92da218bf3 | [log] [tgz] |
---|---|---|
author | Joey Armstrong <joey@opennetworking.org> | Sat Dec 17 23:09:13 2022 -0500 |
committer | Joey Armstrong <joey@opennetworking.org> | Tue Dec 27 16:02:38 2022 -0500 |
tree | dcbc931de1f843ac22c760c26f883aa7170d64e4 | |
parent | f9bffdf85c298b8838d3444c5ea416b99ebbe8ad [diff] |
VOL-4836 - Comstic edits to trigger a build Makefile VERSION cmd/openolt-adapter/main.go internal/pkg/config/config.go internal/pkg/olterrors/common.go internal/pkg/olterrors/olterrors.go pkg/mocks/mockEventproxy.go pkg/mocks/mockOpenOltClient.go ------------------------------------------------------------------------------- o Update copyright notice. Remove vendor files, content is not expected to be modified. Will need to revisit later, problem handling: o files should not be modified but make clean will remove them. o Modifying revision control files wil cause a jenkins job failure. o Commiting files to revision control is technically duplication given the exist in a different repo. Change-Id: Iaaeb6c92c3febf5e5b11e049d8809fa1925dbb48
The OpenOLT adapter connects the VOLTHA core to an OLT device running the OpenOLT agent.
make
targetsThe Makefile
contains many commands that are useful in development:
build : Alias for 'docker build' clean : Removes any local filesystem artifacts generated by a build distclean : Removes any local filesystem artifacts generated by a build or test run docker-build-profile : Build openolt adapter docker image with profiling enabled docker-build : Build openolt adapter docker image docker-kind-load : Load docker images into a KinD cluster docker-push : Push the docker images to an external repository help : Print help for each Makefile target lint-dockerfile : Perform static analysis on Dockerfile lint-mod : Verify the Go dependencies lint : Run all lint targets local-lib-go : Copies a local version of the voltha-lib-go dependency into the vendor directory local-protos : Copies a local version of the voltha-protos dependency into the vendor directory mod-update : Update go mod files sca : Runs static code analysis with the golangci-lint tool test : Run unit tests
Some highlights:
It's recommended that you run the lint
, sca
, and test
targets before submitting code changes.
The docker-*
targets for building and pushing Docker images depend on the variables DOCKER_REGISTRY
, DOCKER_REPOSITORY
, and DOCKER_TAG
as described in the CORD documentation
If you make changes the dependencies in the go.mod
file, you will need to run make mod-update
to update the go.sum
and vendor
directory.
voltha-protos
or voltha-lib-go
If you want to build/test using a local copy of the voltha-protos
or voltha-lib-go
libraries this can be accomplished by using the environment variables LOCAL_PROTOS
and LOCAL_LIB_GO
. These environment variables should be set to the filesystem path where the local source is located, e.g.:
export LOCAL_PROTOS=/path/to/voltha-protos export LOCAL_LIB_GO=/path/to/voltha-lib-go
Then run make local-protos
and/or make local-lib-go
as is appropriate to copy them into the vendor
directory.
NOTE: That the files in the
vendor
directory are no longer what is in the most recent commit, and it will take manualgit
intervention to put the original files back.