VOL-3344 - Enabled default linters and fixed found issues.
Also disabled govet's variable shadowing check, since this is very useful for isolating multiple "err"ors in a row.
Change-Id: Icd70c723c406c5986b8cfe4535ad7daa0752e48c
diff --git a/internal/pkg/core/openolt_test.go b/internal/pkg/core/openolt_test.go
index a2ac77b..08c2f52 100644
--- a/internal/pkg/core/openolt_test.go
+++ b/internal/pkg/core/openolt_test.go
@@ -26,7 +26,6 @@
"context"
"errors"
"reflect"
- "sync"
"testing"
com "github.com/opencord/voltha-lib-go/v3/pkg/adapters/common"
@@ -43,17 +42,16 @@
// mocks the OpenOLT struct.
type fields struct {
- deviceHandlers map[string]*DeviceHandler
- coreProxy *com.CoreProxy
- adapterProxy *com.AdapterProxy
- eventProxy *com.EventProxy
- kafkaICProxy kafka.InterContainerProxy
- numOnus int
- KVStoreAddress string
- KVStoreType string
- exitChannel chan int
- lockDeviceHandlersMap sync.RWMutex
- ctx context.Context
+ deviceHandlers map[string]*DeviceHandler
+ coreProxy *com.CoreProxy
+ adapterProxy *com.AdapterProxy
+ eventProxy *com.EventProxy
+ kafkaICProxy kafka.InterContainerProxy
+ numOnus int
+ KVStoreAddress string
+ KVStoreType string
+ exitChannel chan int
+ ctx context.Context
}
// mockOlt mocks OpenOLT struct.
@@ -728,7 +726,9 @@
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
oo := testOltObject(tt.fields)
- oo.Start(tt.args.ctx)
+ if err := oo.Start(tt.args.ctx); err != nil {
+ t.Error(err)
+ }
if err := oo.Stop(tt.args.ctx); err != nil {
t.Errorf("Stop() error = %v, wantErr %v", err, tt.wantErr)
}