commit e6ff101ff6eb61eec7be1cfe1577a0dedceb6fe5
author Kent Hagerman <khagerma@ciena.com> Tue Jul 14 15:07:53 2020 -0400
committer Girish Gowdra <girish@opennetworking.org> Tue Jul 21 16:54:41 2020 +0000
tree f0ef4fe93d56ce7a8905cb5bcf88a17f9d968a24
parent 7fb80c207ea2e2969c509ea8bdc137bc0b4fc064

VOL-3344 - Enabled default linters and fixed found issues.

Also disabled govet's variable shadowing check, since this is very useful for isolating multiple "err"ors in a row.

Change-Id: Icd70c723c406c5986b8cfe4535ad7daa0752e48c

internal/pkg/core/statsmanager.go

diff --git a/internal/pkg/core/statsmanager.go b/internal/pkg/core/statsmanager.go
index 6427a0c..53f81ab 100755
--- a/internal/pkg/core/statsmanager.go
+++ b/internal/pkg/core/statsmanager.go
@@ -288,12 +288,9 @@
 	metricNames := StatMgr.Device.metrics.GetSubscriberMetrics()
 
 	var metrics []string
-
-	if metricNames != nil && len(metricNames) > 0 {
-		for metric := range metricNames {
-			if metricNames[metric].Enabled {
-				metrics = append(metrics, metric)
-			}
+	for metric := range metricNames {
+		if metricNames[metric].Enabled {
+			metrics = append(metrics, metric)
 		}
 	}
 
@@ -332,12 +329,9 @@
 	metricNames := StatMgr.Device.metrics.GetSubscriberMetrics()
 
 	var metrics []string
-
-	if metricNames != nil && len(metricNames) > 0 {
-		for metric := range metricNames {
-			if metricNames[metric].Enabled {
-				metrics = append(metrics, metric)
-			}
+	for metric := range metricNames {
+		if metricNames[metric].Enabled {
+			metrics = append(metrics, metric)
 		}
 	}