[VOL-2612] Remove error log when returning error from methods
Change-Id: If07af8337a55e0d5d729fc76092590f697ee8276
diff --git a/internal/pkg/core/openolt_eventmgr.go b/internal/pkg/core/openolt_eventmgr.go
index 873bc44..a44d639 100644
--- a/internal/pkg/core/openolt_eventmgr.go
+++ b/internal/pkg/core/openolt_eventmgr.go
@@ -180,8 +180,7 @@
}
/* Send event to KAFKA */
if err := em.eventProxy.SendDeviceEvent(&de, communication, olt, raisedTs); err != nil {
- log.Errorw("Failed to send OLT event", log.Fields{"err": err})
- return err
+ return olterrors.NewErrCommunication("send-olt-event", log.Fields{"device-id": deviceID}, err)
}
log.Infow("OLT UpDown event sent to KAFKA", log.Fields{})
return nil
@@ -201,8 +200,7 @@
de.DeviceEventName = fmt.Sprintf("%s_%s", onuDiscoveryEvent, "RAISE_EVENT")
/* Send event to KAFKA */
if err := em.eventProxy.SendDeviceEvent(&de, equipment, pon, raisedTs); err != nil {
- log.Errorw("Failed to send ONU discovery event", log.Fields{"serial-number": serialNumber, "intf-id": onuDisc.IntfId})
- return err
+ return olterrors.NewErrCommunication("send-onu-discovery-event", log.Fields{"serial-number": serialNumber, "intf-id": onuDisc.IntfId}, err)
}
log.Infow("ONU discovery event sent to KAFKA", log.Fields{"serial-number": serialNumber, "intf-id": onuDisc.IntfId})
return nil
@@ -471,6 +469,7 @@
device, err := em.handler.coreProxy.GetDevice(ctx.Background(), deviceID, deviceID)
if err != nil {
log.Errorw("Error while fetching Device object", log.Fields{"DeviceId": deviceID})
+ return
}
for _, port := range device.Ports {
if port.PortNo == portID {
@@ -495,7 +494,7 @@
}
/* Send event to KAFKA */
if err := em.eventProxy.SendDeviceEvent(&de, communication, olt, raisedTs); err != nil {
- log.Errorw("failed-to-send-olt-intf-oper-status-event", log.Fields{"err": err})
+ olterrors.NewErrCommunication("send-olt-intf-oper-status-event", log.Fields{"device-id": deviceID, "intf-id": ifindication.IntfId, "oper-state": ifindication.OperState}, err).Log()
}
log.Info("sent-olt-intf-oper-status-event-to-kafka")
}