Fixing gosec issues
Change-Id: I8a176b05d778e3428ce53d87406ce194b438c895
diff --git a/internal/pkg/onuadaptercore/file_download_manager.go b/internal/pkg/onuadaptercore/file_download_manager.go
index 1dfd50a..b75c319 100644
--- a/internal/pkg/onuadaptercore/file_download_manager.go
+++ b/internal/pkg/onuadaptercore/file_download_manager.go
@@ -25,6 +25,7 @@
"net/http"
"net/url"
"os"
+ "path/filepath"
"sync"
"time"
@@ -136,13 +137,16 @@
//GetDownloadImageBuffer returns the content of the requested file as byte slice
func (dm *fileDownloadManager) GetDownloadImageBuffer(ctx context.Context, aFileName string) ([]byte, error) {
- //nolint:gosec
- file, err := os.Open(cDefaultLocalDir + "/" + aFileName)
+ file, err := os.Open(filepath.Clean(cDefaultLocalDir + "/" + aFileName))
if err != nil {
return nil, err
}
- //nolint:errcheck
- defer file.Close()
+ defer func() {
+ err := file.Close()
+ if err != nil {
+ logger.Errorw(ctx, "failed to close file", log.Fields{"error": err})
+ }
+ }()
stats, statsErr := file.Stat()
if statsErr != nil {