[VOL-4485] omci-lib-go: ME Attribute names should be exported
Change-Id: I15ef78c3b470a9c49a23b32aad513c1cddfb3066
diff --git a/internal/pkg/uniprt/uniportadmin.go b/internal/pkg/uniprt/uniportadmin.go
index 4ddf154..2a0a2c9 100755
--- a/internal/pkg/uniprt/uniportadmin.go
+++ b/internal/pkg/uniprt/uniportadmin.go
@@ -213,7 +213,7 @@
oFsm.mutexAdminState.RUnlock()
logger.Debugw(ctx, "LockStateFSM Tx Set::ONU-G:admin", log.Fields{
"omciAdmin": omciAdminState, "in state": e.FSM.Current(), "device-id": oFsm.deviceID})
- requestedAttributes := me.AttributeValueMap{"AdministrativeState": omciAdminState}
+ requestedAttributes := me.AttributeValueMap{me.OnuG_AdministrativeState: omciAdminState}
oFsm.mutexPLastTxMeInstance.Lock()
meInstance, err := oFsm.pOmciCC.SendSetOnuGLS(log.WithSpanFromContext(context.TODO(), ctx), oFsm.pDeviceHandler.GetOmciTimeout(), true,
requestedAttributes, oFsm.PAdaptFsm.CommChan)
@@ -430,7 +430,7 @@
}
oFsm.mutexAdminState.RUnlock()
//set PPTPEthUni or VEIP AdminState
- requestedAttributes := me.AttributeValueMap{"AdministrativeState": omciAdminState}
+ requestedAttributes := me.AttributeValueMap{me.PhysicalPathTerminationPointEthernetUni_AdministrativeState: omciAdminState}
for uniNo, uniPort := range *oFsm.pDeviceHandler.GetUniEntityMap() {
// only unlock the UniPort in case it is defined for usage (R2.6 limit only one port),
diff --git a/internal/pkg/uniprt/uniportstatus.go b/internal/pkg/uniprt/uniportstatus.go
index b088d41..4c294ce 100755
--- a/internal/pkg/uniprt/uniportstatus.go
+++ b/internal/pkg/uniprt/uniportstatus.go
@@ -28,12 +28,7 @@
"github.com/opencord/voltha-protos/v5/go/extension"
)
-const (
- uniStatusTimeout = 3
- adminState = "AdministrativeState"
- operationalState = "OperationalState"
- configInd = "ConfigurationInd"
-)
+const uniStatusTimeout = 3
//UniPortStatus implements methods to get uni port status info
type UniPortStatus struct {
@@ -59,7 +54,10 @@
if uniPort.UniID == uint8(uniIdx) && uniPort.PortType == cmn.UniPPTP {
- requestedAttributes := me.AttributeValueMap{adminState: 0, operationalState: 0, configInd: 0}
+ requestedAttributes := me.AttributeValueMap{
+ me.PhysicalPathTerminationPointEthernetUni_AdministrativeState: 0,
+ me.PhysicalPathTerminationPointEthernetUni_OperationalState: 0,
+ me.PhysicalPathTerminationPointEthernetUni_ConfigurationInd: 0}
// Note: No reference to fetch the OMCI timeout configuration value, so hard code it to 10s
meInstance, err := portStatus.pOmiCC.SendGetMe(ctx, me.PhysicalPathTerminationPointEthernetUniClassID, uniPort.EntityID, requestedAttributes, 10, true, portStatus.omciRespChn)
if err != nil {
@@ -134,17 +132,17 @@
},
},
}
- if meAttributes[operationalState].(uint8) == 0 {
+ if meAttributes[me.PhysicalPathTerminationPointEthernetUni_OperationalState].(uint8) == 0 {
singleValResp.Response.GetUniInfo().OperState = extension.GetOnuUniInfoResponse_ENABLED
- } else if meAttributes[operationalState].(uint8) == 1 {
+ } else if meAttributes[me.PhysicalPathTerminationPointEthernetUni_OperationalState].(uint8) == 1 {
singleValResp.Response.GetUniInfo().OperState = extension.GetOnuUniInfoResponse_DISABLED
} else {
singleValResp.Response.GetUniInfo().OperState = extension.GetOnuUniInfoResponse_OPERSTATE_UNDEFINED
}
- if meAttributes[adminState].(uint8) == 0 {
+ if meAttributes[me.PhysicalPathTerminationPointEthernetUni_AdministrativeState].(uint8) == 0 {
singleValResp.Response.GetUniInfo().AdmState = extension.GetOnuUniInfoResponse_UNLOCKED
- } else if meAttributes[adminState].(uint8) == 1 {
+ } else if meAttributes[me.PhysicalPathTerminationPointEthernetUni_AdministrativeState].(uint8) == 1 {
singleValResp.Response.GetUniInfo().AdmState = extension.GetOnuUniInfoResponse_LOCKED
} else {
singleValResp.Response.GetUniInfo().AdmState = extension.GetOnuUniInfoResponse_ADMSTATE_UNDEFINED
@@ -159,7 +157,7 @@
18: extension.GetOnuUniInfoResponse_HUNDRED_BASE_T_HDX,
19: extension.GetOnuUniInfoResponse_GIGABIT_ETHERNET_HDX,
}
- configInd := meAttributes[configInd].(uint8)
+ configInd := meAttributes[me.PhysicalPathTerminationPointEthernetUni_ConfigurationInd].(uint8)
singleValResp.Response.GetUniInfo().ConfigInd = configIndMap[configInd]
return &singleValResp
}