VOL-3052 Onu Software upgrade correction and remove internal test functionality

Signed-off-by: mpagenko <michael.pagenkopf@adtran.com>
Change-Id: Icf0e72648fe56a86f7cc15d57750a6566c431daa
diff --git a/internal/pkg/onuadaptercore/mib_sync.go b/internal/pkg/onuadaptercore/mib_sync.go
index 43e4556..a9f095e 100644
--- a/internal/pkg/onuadaptercore/mib_sync.go
+++ b/internal/pkg/onuadaptercore/mib_sync.go
@@ -505,11 +505,19 @@
 			oo.onuSwImageIndications.activeEntityEntry.valid = true
 			oo.onuSwImageIndications.activeEntityEntry.version = imageVersion
 			oo.onuSwImageIndications.activeEntityEntry.isCommitted = imageIsCommitted
+			//as the SW version indication may stem from some ONU Down/up event
+			//the complementary image state is to be invalidated
+			//  (state of the second image is always expected afterwards or just invalid)
+			oo.onuSwImageIndications.inactiveEntityEntry.valid = false
 		} else {
 			oo.onuSwImageIndications.inactiveEntityEntry.entityID = entityID
 			oo.onuSwImageIndications.inactiveEntityEntry.valid = true
 			oo.onuSwImageIndications.inactiveEntityEntry.version = imageVersion
 			oo.onuSwImageIndications.inactiveEntityEntry.isCommitted = imageIsCommitted
+			//as the SW version indication may stem form some ONU Down/up event
+			//the complementary image state is to be invalidated
+			//  (state of the second image is always expected afterwards or just invalid)
+			oo.onuSwImageIndications.activeEntityEntry.valid = false
 		}
 		_ = oo.pMibUploadFsm.pFsm.Event(ulEvGetSecondSwVersion)
 		return