[VOL-4120] openonu-adapter-go: support command "voltctl device onuimage list <onu-id>"
Change-Id: If6bc1a94663c09881059b1f91d34944dccec52f3
diff --git a/internal/pkg/onuadaptercore/device_handler.go b/internal/pkg/onuadaptercore/device_handler.go
index af5cb57..ba969a1 100644
--- a/internal/pkg/onuadaptercore/device_handler.go
+++ b/internal/pkg/onuadaptercore/device_handler.go
@@ -1337,6 +1337,28 @@
}
}
+func (dh *deviceHandler) getOnuImages(ctx context.Context) (*voltha.OnuImages, error) {
+
+ var onuImageStatus *OnuImageStatus
+
+ pDevEntry := dh.getOnuDeviceEntry(ctx, false)
+ if pDevEntry != nil {
+ onuImageStatus = NewOnuImageStatus(pDevEntry)
+ pDevEntry.mutexOnuImageStatus.Lock()
+ pDevEntry.pOnuImageStatus = onuImageStatus
+ pDevEntry.mutexOnuImageStatus.Unlock()
+
+ } else {
+ logger.Errorw(ctx, "No valid OnuDevice - aborting", log.Fields{"device-id": dh.deviceID})
+ return nil, fmt.Errorf("no-valid-OnuDevice-aborting")
+ }
+ images, err := onuImageStatus.getOnuImageStatus(ctx)
+ pDevEntry.mutexOnuImageStatus.Lock()
+ pDevEntry.pOnuImageStatus = nil
+ pDevEntry.mutexOnuImageStatus.Unlock()
+ return images, err
+}
+
// deviceHandler methods that implement the adapters interface requests## end #########
// #####################################################################################
@@ -1919,6 +1941,11 @@
if pDevEntry.PDevOmciCC != nil {
pDevEntry.PDevOmciCC.CancelRequestMonitoring()
}
+ pDevEntry.mutexOnuImageStatus.RLock()
+ if pDevEntry.pOnuImageStatus != nil {
+ pDevEntry.pOnuImageStatus.CancelProcessing(ctx)
+ }
+ pDevEntry.mutexOnuImageStatus.RUnlock()
if includingMibSyncFsm {
pDevEntry.CancelProcessing(ctx)
diff --git a/internal/pkg/onuadaptercore/mib_sync.go b/internal/pkg/onuadaptercore/mib_sync.go
index 29e0a2a..564be6f 100644
--- a/internal/pkg/onuadaptercore/mib_sync.go
+++ b/internal/pkg/onuadaptercore/mib_sync.go
@@ -18,7 +18,6 @@
package adaptercoreonu
import (
- "bytes"
"context"
"encoding/hex"
"encoding/json"
@@ -601,7 +600,7 @@
case "OnuG":
oo.mutexLastTxParamStruct.RUnlock()
oo.mutexPersOnuConfig.Lock()
- oo.sOnuPersistentData.PersVendorID = trimStringFromInterface(meAttributes["VendorId"])
+ oo.sOnuPersistentData.PersVendorID = TrimStringFromMeOctet(meAttributes["VendorId"])
snBytes, _ := me.InterfaceToOctets(meAttributes["SerialNumber"])
if onugSerialNumberLen == len(snBytes) {
snVendorPart := fmt.Sprintf("%s", snBytes[:4])
@@ -620,7 +619,7 @@
case "Onu2G":
oo.mutexLastTxParamStruct.RUnlock()
oo.mutexPersOnuConfig.Lock()
- oo.sOnuPersistentData.PersEquipmentID = trimStringFromInterface(meAttributes["EquipmentId"])
+ oo.sOnuPersistentData.PersEquipmentID = TrimStringFromMeOctet(meAttributes["EquipmentId"])
logger.Debugw(ctx, "MibSync FSM - GetResponse Data for Onu2-G - EquipmentId", log.Fields{"device-id": oo.deviceID,
"onuDeviceEntry.equipmentID": oo.sOnuPersistentData.PersEquipmentID})
oo.mutexPersOnuConfig.Unlock()
@@ -682,7 +681,7 @@
func (oo *OnuDeviceEntry) handleSwImageIndications(ctx context.Context, entityID uint16, meAttributes me.AttributeValueMap) {
imageIsCommitted := meAttributes["IsCommitted"].(uint8)
imageIsActive := meAttributes["IsActive"].(uint8)
- imageVersion := trimStringFromInterface(meAttributes["Version"])
+ imageVersion := TrimStringFromMeOctet(meAttributes["Version"])
oo.mutexPersOnuConfig.RLock()
logger.Infow(ctx, "MibSync FSM - GetResponse Data for SoftwareImage",
log.Fields{"device-id": oo.deviceID, "entityID": entityID,
@@ -829,11 +828,6 @@
return false
}
-func trimStringFromInterface(input interface{}) string {
- ifBytes, _ := me.InterfaceToOctets(input)
- return fmt.Sprintf("%s", bytes.Trim(ifBytes, "\x00"))
-}
-
func (oo *OnuDeviceEntry) mibDbVolatileDict(ctx context.Context) error {
logger.Debug(ctx, "MibVolatileDict- running from default Entry code")
return errors.New("not_implemented")
diff --git a/internal/pkg/onuadaptercore/omci_onu_upgrade.go b/internal/pkg/onuadaptercore/omci_onu_upgrade.go
index 3da030d..19a9ff0 100644
--- a/internal/pkg/onuadaptercore/omci_onu_upgrade.go
+++ b/internal/pkg/onuadaptercore/omci_onu_upgrade.go
@@ -1254,7 +1254,7 @@
meAttributes := msgObj.Attributes
imageIsCommitted := meAttributes["IsCommitted"].(uint8)
imageIsActive := meAttributes["IsActive"].(uint8)
- imageVersion := trimStringFromInterface(meAttributes["Version"])
+ imageVersion := TrimStringFromMeOctet(meAttributes["Version"])
logger.Debugw(ctx, "OnuUpgradeFsm - GetResponse Data for SoftwareImage",
log.Fields{"device-id": oFsm.deviceID, "entityID": msgObj.EntityInstance,
"version": imageVersion, "isActive": imageIsActive, "isCommitted": imageIsCommitted})
diff --git a/internal/pkg/onuadaptercore/onu_device_entry.go b/internal/pkg/onuadaptercore/onu_device_entry.go
index 9544efa..4ada5d9 100644
--- a/internal/pkg/onuadaptercore/onu_device_entry.go
+++ b/internal/pkg/onuadaptercore/onu_device_entry.go
@@ -213,6 +213,10 @@
//swIsInactive = 0 not yet used
swIsActive = 1
)
+const ( //definitions as per G.988 softwareImage::IsValid
+ //swIsInvalid = 0 not yet used
+ swIsValid = 1
+)
const onuDataMeID = 0
const onugMeID = 0
const onu2gMeID = 0
@@ -279,6 +283,8 @@
onuKVStoreProcResult error //error indication of processing
chOnuKvProcessingStep chan uint8
onuSwImageIndications sSwImageIndications
+ mutexOnuImageStatus sync.RWMutex
+ pOnuImageStatus *OnuImageStatus
//lockDeviceEntries sync.RWMutex
mibDbClass func(context.Context) error
supportedFsms OmciDeviceFsms
diff --git a/internal/pkg/onuadaptercore/onu_image_status.go b/internal/pkg/onuadaptercore/onu_image_status.go
new file mode 100755
index 0000000..fb34a26
--- /dev/null
+++ b/internal/pkg/onuadaptercore/onu_image_status.go
@@ -0,0 +1,250 @@
+/*
+ * Copyright 2020-present Open Networking Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+//Package adaptercoreonu provides the utility for onu devices, flows and statistics
+package adaptercoreonu
+
+import (
+ "context"
+ "encoding/hex"
+ "fmt"
+ "sync"
+ "time"
+
+ "github.com/opencord/omci-lib-go"
+ me "github.com/opencord/omci-lib-go/generated"
+ "github.com/opencord/voltha-lib-go/v4/pkg/log"
+ "github.com/opencord/voltha-protos/v4/go/voltha"
+)
+
+//OnuImageStatus implements methods to get status info of onu images
+type OnuImageStatus struct {
+ pDevEntry *OnuDeviceEntry
+ deviceID string
+ requestedAttributes me.AttributeValueMap
+ mutexWaitingForResp sync.RWMutex
+ waitingForResp bool
+ respChannel chan Message
+ mutexPLastTxMeInstance sync.RWMutex
+ pLastTxMeInstance *me.ManagedEntity
+}
+
+const (
+ cImgVersion = "Version"
+ cImgIsCommitted = "IsCommitted"
+ cImgIsActive = "IsActive"
+ cImgIsValid = "IsValid"
+ cImgProductCode = "ProductCode"
+ cImgImageHash = "ImageHash"
+)
+
+//NewOnuImageStatus creates a new instance of OnuImageStatus
+func NewOnuImageStatus(pDevEntry *OnuDeviceEntry) *OnuImageStatus {
+ return &OnuImageStatus{
+ pDevEntry: pDevEntry,
+ deviceID: pDevEntry.deviceID,
+ requestedAttributes: make(me.AttributeValueMap),
+ waitingForResp: false,
+ respChannel: make(chan Message),
+ }
+}
+func (oo *OnuImageStatus) getOnuImageStatus(ctx context.Context) (*voltha.OnuImages, error) {
+
+ var images voltha.OnuImages
+
+ if oo.pDevEntry.PDevOmciCC == nil {
+ logger.Errorw(ctx, "omciCC not ready to receive omci messages", log.Fields{"device-id": oo.deviceID})
+ return nil, fmt.Errorf("omciCC-not-ready-to-receive-omci-messages")
+ }
+ for i := firstSwImageMeID; i <= secondSwImageMeID; i++ {
+ logger.Debugw(ctx, "getOnuImageStatus for image id", log.Fields{"image-id": i, "device-id": oo.deviceID})
+
+ var image voltha.OnuImage
+
+ // TODO: Since the summed length of the attributes exceeds the capacity of a single response,
+ // it is distributed on several requests here. It should be discussed whether, in the course of a refactoring,
+ // a global mechanism should be implemented that automates this distribution - which would entail quite some
+ // changes on the respective receiver sides.
+
+ oo.requestedAttributes = me.AttributeValueMap{cImgVersion: "", cImgIsCommitted: 0, cImgIsActive: 0, cImgIsValid: 0}
+ if err := oo.requestOnuImageAttributes(ctx, uint16(i), &image); err != nil {
+ logger.Errorw(ctx, err.Error(), log.Fields{"requestedAttributes": oo.requestedAttributes, "device-id": oo.deviceID})
+ return nil, err
+ }
+ oo.requestedAttributes = me.AttributeValueMap{cImgProductCode: ""}
+ if err := oo.requestOnuImageAttributes(ctx, uint16(i), &image); err != nil {
+ logger.Errorw(ctx, err.Error(), log.Fields{"requestedAttributes": oo.requestedAttributes, "device-id": oo.deviceID})
+ return nil, err
+ }
+ oo.requestedAttributes = me.AttributeValueMap{cImgImageHash: 0}
+ if err := oo.requestOnuImageAttributes(ctx, uint16(i), &image); err != nil {
+ logger.Errorw(ctx, err.Error(), log.Fields{"requestedAttributes": oo.requestedAttributes, "device-id": oo.deviceID})
+ return nil, err
+ }
+ images.Items = append(images.Items, &image)
+ }
+ logger.Debugw(ctx, "images of the ONU", log.Fields{"images": images})
+ return &images, nil
+}
+
+func (oo *OnuImageStatus) requestOnuImageAttributes(ctx context.Context, imageID uint16, image *voltha.OnuImage) error {
+ oo.mutexPLastTxMeInstance.Lock()
+ meInstance, err := oo.pDevEntry.PDevOmciCC.sendGetMe(log.WithSpanFromContext(context.TODO(), ctx), me.SoftwareImageClassID,
+ imageID, oo.requestedAttributes, oo.pDevEntry.pOpenOnuAc.omciTimeout, true, oo.respChannel)
+ if err != nil {
+ oo.mutexPLastTxMeInstance.Unlock()
+ logger.Errorw(ctx, "can't send omci request to get data for image id", log.Fields{"image-id": imageID, "device-id": oo.deviceID})
+ return fmt.Errorf("can't-send-omci-request-to-get-data-for-image-id-%d", imageID)
+ }
+ oo.pLastTxMeInstance = meInstance
+ oo.mutexPLastTxMeInstance.Unlock()
+
+ if err = oo.waitForGetOnuImageStatus(ctx, image); err != nil {
+ logger.Errorw(ctx, err.Error(), log.Fields{"device-id": oo.deviceID})
+ return err
+ }
+ return nil
+}
+
+func (oo *OnuImageStatus) waitForGetOnuImageStatus(ctx context.Context, image *voltha.OnuImage) error {
+ oo.setWaitingForResp(true)
+ select {
+ // maybe be also some outside cancel (but no context modeled for the moment ...)
+ case <-ctx.Done():
+ logger.Errorw(ctx, "waitForGetOnuImageStatus context done", log.Fields{"device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-context-done")
+ case <-time.After(oo.pDevEntry.PDevOmciCC.GetMaxOmciTimeoutWithRetries() * time.Second):
+ logger.Errorw(ctx, "waitForGetOnuImageStatus timeout", log.Fields{"device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-timeout")
+ case message, ok := <-oo.respChannel:
+ if !ok {
+ logger.Errorw(ctx, "waitForGetOnuImageStatus response error", log.Fields{"device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-response-error")
+ }
+ switch message.Type {
+ case OMCI:
+ msg, _ := message.Data.(OmciMessage)
+ oo.setWaitingForResp(false)
+ return oo.processGetOnuImageStatusResp(ctx, msg, image)
+ case TestMsg:
+ msg, _ := message.Data.(TestMessage)
+ if msg.TestMessageVal == AbortMessageProcessing {
+ logger.Info(ctx, "waitForGetOnuImageStatus abort msg received", log.Fields{"device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-abort-msg-received")
+ }
+ default:
+ logger.Errorw(ctx, "waitForGetOnuImageStatus wrong msg type received", log.Fields{"msgType": message.Type, "device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-response-error")
+ }
+ }
+ logger.Errorw(ctx, "waitForGetOnuImageStatus processing error", log.Fields{"device-id": oo.deviceID})
+ oo.setWaitingForResp(false)
+ return fmt.Errorf("wait-for-image-status-processing-error")
+
+}
+
+func (oo *OnuImageStatus) processGetOnuImageStatusResp(ctx context.Context, msg OmciMessage, image *voltha.OnuImage) error {
+ if msg.OmciMsg.MessageType != omci.GetResponseType {
+ logger.Errorw(ctx, "processGetOnuImageStatusResp wrong response type received", log.Fields{"respType": msg.OmciMsg.MessageType, "device-id": oo.deviceID})
+ return fmt.Errorf("process-image-status-response-error")
+ }
+ msgLayer := (*msg.OmciPacket).Layer(omci.LayerTypeGetResponse)
+ if msgLayer == nil {
+ logger.Errorw(ctx, "processGetOnuImageStatusResp omci Msg layer not found", log.Fields{"device-id": oo.deviceID})
+ return fmt.Errorf("process-image-status-response-error")
+ }
+ msgObj, msgOk := msgLayer.(*omci.GetResponse)
+ if !msgOk {
+ logger.Errorw(ctx, "processGetOnuImageStatusResp omci msgObj layer could not be found", log.Fields{"device-id": oo.deviceID})
+ return fmt.Errorf("process-image-status-response-error")
+ }
+ oo.mutexPLastTxMeInstance.RLock()
+ if oo.pLastTxMeInstance != nil {
+ if msgObj.EntityClass == oo.pLastTxMeInstance.GetClassID() &&
+ msgObj.EntityInstance == oo.pLastTxMeInstance.GetEntityID() {
+ oo.mutexPLastTxMeInstance.RUnlock()
+
+ meAttributes := msgObj.Attributes
+ logger.Debugw(ctx, "processGetOnuImageStatusResp omci attributes received", log.Fields{"attributes": meAttributes, "device-id": oo.deviceID})
+
+ for k := range oo.requestedAttributes {
+ switch k {
+ case cImgIsCommitted:
+ if meAttributes[cImgIsCommitted].(uint8) == swIsCommitted {
+ image.IsCommited = true
+ } else {
+ image.IsCommited = false
+ }
+ case cImgIsActive:
+ if meAttributes[cImgIsActive].(uint8) == swIsActive {
+ image.IsActive = true
+ } else {
+ image.IsActive = false
+ }
+ case cImgIsValid:
+ if meAttributes[cImgIsValid].(uint8) == swIsValid {
+ image.IsValid = true
+ } else {
+ image.IsValid = false
+ }
+ case cImgVersion:
+ image.Version = TrimStringFromMeOctet(meAttributes[cImgVersion])
+ case cImgProductCode:
+ image.ProductCode = TrimStringFromMeOctet(meAttributes[cImgProductCode])
+ case cImgImageHash:
+ bytes, _ := me.InterfaceToOctets(meAttributes[cImgImageHash])
+ image.Hash = hex.EncodeToString(bytes)
+ }
+ }
+ return nil
+ }
+ oo.mutexPLastTxMeInstance.RUnlock()
+ logger.Errorw(ctx, "processGetOnuImageStatusResp wrong MeInstance received", log.Fields{"device-id": oo.deviceID})
+ return fmt.Errorf("process-image-status-response-error")
+ }
+ oo.mutexPLastTxMeInstance.RUnlock()
+ logger.Errorw(ctx, "processGetOnuImageStatusResp pLastTxMeInstance is nil", log.Fields{"device-id": oo.deviceID})
+ return fmt.Errorf("process-image-status-response-error")
+}
+func (oo *OnuImageStatus) setWaitingForResp(value bool) {
+ oo.mutexWaitingForResp.Lock()
+ oo.waitingForResp = value
+ oo.mutexWaitingForResp.Unlock()
+}
+func (oo *OnuImageStatus) isWaitingForResp() bool {
+ oo.mutexWaitingForResp.RLock()
+ value := oo.waitingForResp
+ oo.mutexWaitingForResp.RUnlock()
+ return value
+}
+
+//CancelProcessing ensures that interrupted processing is canceled while waiting for a response
+func (oo *OnuImageStatus) CancelProcessing(ctx context.Context) {
+ if oo.isWaitingForResp() {
+ abortMsg := Message{
+ Type: TestMsg,
+ Data: TestMessage{
+ TestMessageVal: AbortMessageProcessing,
+ },
+ }
+ oo.respChannel <- abortMsg
+ }
+}
diff --git a/internal/pkg/onuadaptercore/openonu.go b/internal/pkg/onuadaptercore/openonu.go
index 805944c..d4089b5 100644
--- a/internal/pkg/onuadaptercore/openonu.go
+++ b/internal/pkg/onuadaptercore/openonu.go
@@ -825,7 +825,16 @@
// Get_onu_images retrieves the ONU SW image status information via OMCI
func (oo *OpenONUAC) Get_onu_images(ctx context.Context, deviceID string) (*voltha.OnuImages, error) {
- return nil, errors.New("unImplemented")
+ logger.Infow(ctx, "Get_onu_images", log.Fields{"device-id": deviceID})
+ if handler := oo.getDeviceHandler(ctx, deviceID, false); handler != nil {
+ var err error
+ if images, err := handler.getOnuImages(ctx); err == nil {
+ return images, nil
+ }
+ return nil, fmt.Errorf(fmt.Sprintf("%s-%s", err, deviceID))
+ }
+ logger.Warnw(ctx, "no handler found for Get_onu_images", log.Fields{"device-id": deviceID})
+ return nil, fmt.Errorf(fmt.Sprintf("handler-not-found-%s", deviceID))
}
// Activate_onu_image initiates the activation of the image for the requested ONU(s)
diff --git a/internal/pkg/onuadaptercore/openonu_utils.go b/internal/pkg/onuadaptercore/openonu_utils.go
index 2d17b05..51e5e81 100644
--- a/internal/pkg/onuadaptercore/openonu_utils.go
+++ b/internal/pkg/onuadaptercore/openonu_utils.go
@@ -18,12 +18,16 @@
package adaptercoreonu
import (
+ "bytes"
"encoding/binary"
"errors"
+ "fmt"
"net"
"regexp"
"strconv"
"strings"
+
+ me "github.com/opencord/omci-lib-go/generated"
)
// GetTpIDFromTpPath extracts TpID from the TpPath.
@@ -81,3 +85,9 @@
return int16(val)
}
+
+// TrimStringFromMeOctet trim string out of Me octet
+func TrimStringFromMeOctet(input interface{}) string {
+ ifBytes, _ := me.InterfaceToOctets(input)
+ return fmt.Sprintf("%s", bytes.Trim(ifBytes, "\x00"))
+}