commit 7591109441fd732af132fa9117f4ad32ee8c7055
author Matteo Scandolo <matteo.scandolo@gmail.com> Tue Nov 16 17:05:36 2021 -0800
committer Andrea Campanella <andrea@opennetworking.org> Thu Nov 18 16:13:55 2021 +0000
tree 0de2ba225a9b009711c66a4924baa3334f8f9fc0
parent e8376f37788b566511cf5d483fadc1f2b53599b7

[VOL-4404] Checking that flows are removed from ONOS after device deletion

Change-Id: Iccd5829ad1f7bbcf7c1844210a48d44345ed46b7

libraries/onos.robot

diff --git a/libraries/onos.robot b/libraries/onos.robot
index c568baf..a4219f4 100755
--- a/libraries/onos.robot
+++ b/libraries/onos.robot
@@ -808,12 +808,12 @@
     END
     Return From Keyword     ${result}
 
-Count ADDED flows
-    [Documentation]  Count the flows in ADDED state in ONOS
-    [Arguments]  ${ip}    ${port}    ${targetFlows}   ${deviceId}
+Count flows
+    [Documentation]     Count flows in a particular ${state} in ONOS
+    [Arguments]  ${ip}    ${port}    ${targetFlows}   ${deviceId}   ${state}
     ${flows}=    Execute ONOS CLI Command use single connection    ${ip}    ${port}
-    ...     flows -s any ${deviceId} | grep ADDED | wc -l
-    Log     Found ${flows} of ${targetFlows} expected flows on device ${deviceId}
+    ...     flows -s ${state} ${deviceId} | grep -v deviceId | wc -l
+    Log     Found ${state} ${flows} of ${targetFlows} expected flows on device ${deviceId}
     Should Be Equal As Integers    ${targetFlows}    ${flows}
 
 Wait for all flows to in ADDED state
@@ -822,8 +822,15 @@
     ...    ${provisioned}     ${withEapol}    ${withDhcp}     ${withIgmp}     ${withLldp}
     ${targetFlows}=     Calculate flows by workflow     ${workflow}    ${uni_count}    ${olt_count}     ${provisioned}
     ...     ${withEapol}    ${withDhcp}     ${withIgmp}     ${withLldp}
-    Wait Until Keyword Succeeds     10m     5s      Count ADDED flows
-    ...     ${ip}    ${port}  ${targetFlows}  ${deviceId}
+    Wait Until Keyword Succeeds     10m     5s      Count flows
+    ...     ${ip}    ${port}  ${targetFlows}  ${deviceId}   added
+
+Wait for all flows to be removed
+    [Documentation]     Wait for all flows to be removed from a particular device
+    [Arguments]     ${ip}   ${port}     ${deviceId}
+    Wait Until Keyword Succeeds     10m     5s      Count flows
+    ...     ${ip}    ${port}  0  ${deviceId}   any
+
 
 Get Limiting Bandwidth Details
     [Arguments]    ${bandwidth_profile_name}

tests/scale/Voltha_Scale_Tests.robot

diff --git a/tests/scale/Voltha_Scale_Tests.robot b/tests/scale/Voltha_Scale_Tests.robot
index 7dcc4e8..33405e1 100755
--- a/tests/scale/Voltha_Scale_Tests.robot
+++ b/tests/scale/Voltha_Scale_Tests.robot
@@ -259,6 +259,11 @@
         Remove Values From List     ${olt_device_ids}   ${olt_device_id}
     END
 
+    ${onos_devices}=    Compute Device IDs
+    FOR     ${deviceId}     IN  @{onos_devices}
+        Wait for all flows to be removed    ${ONOS_SSH_IP}    ${ONOS_SSH_PORT}  ${deviceId}
+    END
+
     Set Suite Variable    ${olt_device_ids}
 
 *** Keywords ***