commit 2f8a90d7742ae0e412553a67915da696c2f50546
author Shad Ansari <shad@opennetworking.org> Fri Apr 19 01:44:24 2019 -0700
committer Shad Ansari <shad@opennetworking.org> Fri May 17 06:02:09 2019 +0000
tree 42eed07c17c190c0c973f2e8f275b8a039641a82
parent 1e66e2a8314762526f9272f2e14871b246b8c472

Handle multiple onu discover events gracefully

Change-Id: I63831df976654bcb612a06f491932baf7bf1ab5c

voltha/adapters/openolt/openolt_data_model.py

diff --git a/voltha/adapters/openolt/openolt_data_model.py b/voltha/adapters/openolt/openolt_data_model.py
index de43677..03db02a 100644
--- a/voltha/adapters/openolt/openolt_data_model.py
+++ b/voltha/adapters/openolt/openolt_data_model.py
@@ -178,10 +178,9 @@
         if onu_device:
             self.log.debug("data_model onu update", intf_id=intf_id,
                            onu_id=onu_id, serial_number=serial_number)
-            onu_device.oper_status = OperStatus.DISCOVERED
-            onu_device.connect_status = ConnectStatus.REACHABLE
-            self.adapter_agent.update_device(onu_device)
-            return
+            if onu_device.oper_status == OperStatus.ACTIVATING \
+                    or onu_device.oper_status == OperStatus.DISCOVERED:
+                raise ValueError
 
         self.log.debug("data_model onu create", intf_id=intf_id,
                        onu_id=onu_id, serial_number=serial_number)

voltha/adapters/openolt/openolt_device.py

diff --git a/voltha/adapters/openolt/openolt_device.py b/voltha/adapters/openolt/openolt_device.py
index 928d1aa..343f128 100644
--- a/voltha/adapters/openolt/openolt_device.py
+++ b/voltha/adapters/openolt/openolt_device.py
@@ -213,9 +213,13 @@
             if onu_id is None:
                 raise Exception("onu-id-unavailable")
 
-        self.data_model.onu_create(intf_id, onu_id, serial_number_str)
-
-        self.activate_onu(intf_id, onu_id, serial_number, serial_number_str)
+        try:
+            self.data_model.onu_create(intf_id, onu_id, serial_number_str)
+        except ValueError:
+            pass
+        else:
+            self.activate_onu(intf_id, onu_id, serial_number,
+                              serial_number_str)
 
     def onu_indication(self, onu_indication):
         self.log.debug("onu indication", intf_id=onu_indication.intf_id,