commit 37494a747a8c9c8f0891f76d470351f576927d1b
author alshabib <alshabibi.ali@gmail.com> Thu Jan 26 11:59:52 2017 -0800
committer Zsolt Haraszti <zharaszt@ciena.com> Thu Jan 26 22:27:09 2017 -0800
tree 3083d3daf6a2e1fbe42fa978c4ba0b9d0e83f6da
parent 8ffb893566561db58f687ee7920e8a7e9e95e062

Cleaning up TODO items

removing TODO on line 162 of chameleon/grpc_client
and entering it into backlog as CORD-815

removing TODO on line 135 of cli/utils.py
and entering it into backlog as CORD-816

removing TODO on line 155 of cli/utils.py
and entering it into backlog as CORD-817

removing TODO on line 94 of common/utils/consulhelpers.py
and entering it into backlog as CORD-818

Change-Id: I736ea678b16c9b0e85a3cf0aabe96da19caae64d

chameleon/grpc_client/grpc_client.py

diff --git a/chameleon/grpc_client/grpc_client.py b/chameleon/grpc_client/grpc_client.py
index 9b68912..234f24a 100644
--- a/chameleon/grpc_client/grpc_client.py
+++ b/chameleon/grpc_client/grpc_client.py
@@ -159,8 +159,8 @@
                         service_name=service_name)
             yield asleep(1.0)
 
-        # pick a random entry
-        # TODO should we prefer local IP addresses? Probably.
+        # pick local addresses when resolving a service via consul
+        # see CORD-815 (https://jira.opencord.org/browse/CORD-815)
 
         service = services[randint(0, len(services) - 1)]
         endpoint = '{}:{}'.format(service['ServiceAddress'],

cli/utils.py

diff --git a/cli/utils.py b/cli/utils.py
index 7ea9c77..f4111e3 100644
--- a/cli/utils.py
+++ b/cli/utils.py
@@ -132,7 +132,8 @@
         for field in flow['match']['oxm_fields']:
             assert field['oxm_class'].endswith('OPENFLOW_BASIC')
             ofb = field['ofb_field']
-            assert not ofb['has_mask'], 'masked match not handled yet'  # TODO
+            # see CORD-816 (https://jira.opencord.org/browse/CORD-816)
+            assert not ofb['has_mask'], 'masked match not handled yet'
             type = ofb['type'][len('OFPXMT_OFB_'):]
             table.add_cell(i, *field_printers[type](ofb))
 
@@ -151,7 +152,7 @@
 
     table.print_table(header, printfn)
 
-    # TODO groups TBF
+    # see CORD-817 (https://jira.opencord.org/browse/CORD-817)
     assert len(groups) == 0
 
 

common/utils/consulhelpers.py

diff --git a/common/utils/consulhelpers.py b/common/utils/consulhelpers.py
index 3efc7b9..95e6f5b 100644
--- a/common/utils/consulhelpers.py
+++ b/common/utils/consulhelpers.py
@@ -91,8 +91,8 @@
             'Cannot find service {} in consul'.format(service_name))
         os.exit(1)
 
-    # pick a random entry
-    # TODO should we prefer local IP addresses? Probably.
+    # pick local addresses when resolving a service via consul
+    # see CORD-818 (https://jira.opencord.org/browse/CORD-818)
 
     service = services[randint(0, len(services) - 1)]
     endpoint = '{}:{}'.format(service['ServiceAddress'],