commit 8f9f12d373d06c83580858951c60b5dab2959548
author Nicolas Palpacuer <np202g@att.com> Mon Jul 02 12:09:22 2018 -0400
committer Nicolas Palpacuer <np202g@att.com> Wed Jul 11 17:19:19 2018 +0000
tree 3ebcc9d36162f17adbe77bf4effff489189e414a
parent 3d5a58a322590f2fbb21bdb3f8c7dc569149df13

VOL-1046 Not triggering OF port status update on stats changes

Change-Id: I187c37c0828114f6f9490a787cc213bbca3f66a4

voltha/core/logical_device_agent.py

diff --git a/voltha/core/logical_device_agent.py b/voltha/core/logical_device_agent.py
index f18abc0..eaf301a 100644
--- a/voltha/core/logical_device_agent.py
+++ b/voltha/core/logical_device_agent.py
@@ -69,6 +69,7 @@
                 CallbackType.POST_REMOVE, self._port_removed)
 
             self.port_proxy = {}
+            self.port_status_has_changed = {}
 
             self.event_bus = EventBusClient()
             self.packet_in_subscription = self.event_bus.subscribe(
@@ -603,6 +604,9 @@
         self.port_proxy[port.id] = self.core.get_proxy(
             '/logical_devices/{}/ports/{}'.format(self.logical_device_id,
                                                   port.id))
+        self.port_status_has_changed[port.id] = True
+        self.port_proxy[port.id].register_callback(
+            CallbackType.PRE_UPDATE, self._pre_port_changed)
         self.port_proxy[port.id].register_callback(
             CallbackType.POST_UPDATE, self._port_changed)
 
@@ -623,6 +627,9 @@
         self.port_proxy[port.id] = self.core.get_proxy(
             '/logical_devices/{}/ports/{}'.format(self.logical_device_id,
                                                   port.id))
+        self.port_status_has_changed[port.id] = True
+        self.port_proxy[port.id].register_callback(
+            CallbackType.PRE_UPDATE, self._pre_port_changed)
         self.port_proxy[port.id].register_callback(
             CallbackType.POST_UPDATE, self._port_changed)
 
@@ -633,8 +640,12 @@
 
         # Remove the proxy references
         self.port_proxy[port.id].unregister_callback(
+            CallbackType.PRE_UPDATE, self._pre_port_changed)
+        self.port_proxy[port.id].unregister_callback(
             CallbackType.POST_UPDATE, self._port_changed)
         del self.port_proxy[port.id]
+        del self.port_status_has_changed[port.id]
+
 
         self.local_handler.send_port_change_event(
             device_id=self.logical_device_id,
@@ -644,16 +655,24 @@
             )
         )
 
+    def _pre_port_changed(self, port):
+        old_port = self.port_proxy[port.id].get('/')
+        if old_port.ofp_port != port.ofp_port:
+            self.port_status_has_changed[port.id] = True
+        else :
+            self.port_status_has_changed[port.id] = False
+
     def _port_changed(self, port):
         self.log.debug('port-changed', port=port)
-        assert isinstance(port, LogicalPort)
-        self.local_handler.send_port_change_event(
-            device_id=self.logical_device_id,
-            port_status=ofp.ofp_port_status(
-                reason=ofp.OFPPR_MODIFY,
-                desc=port.ofp_port
+        if self.port_status_has_changed[port.id]:
+            assert isinstance(port, LogicalPort)
+            self.local_handler.send_port_change_event(
+                device_id=self.logical_device_id,
+                port_status=ofp.ofp_port_status(
+                    reason=ofp.OFPPR_MODIFY,
+                    desc=port.ofp_port
+                )
             )
-        )
 
     def _port_list_updated(self, _):
         # invalidate the graph and the route table