commit ecb3d1e3d1fe171f82ee5f0b638b42da1ce917a3
author Nicolas Palpacuer <np202g@att.com> Wed Mar 14 17:00:14 2018 -0400
committer Shad Ansari <shad@opennetworking.org> Fri Apr 13 23:13:01 2018 +0000
tree d4fe63424b71ddd43f3aab8f01073910e81c7e15
parent 8956b64d248e78998ebde4eb192f3b46eb2b4ea1

VOL-647 fix: removing the loops that sent redundant messages, removing redundant variable declaration

Change-Id: I4ad691dd04f820482c7cca7c0bb230a5ce6694a5

voltha/adapters/broadcom_onu/broadcom_onu.py

diff --git a/voltha/adapters/broadcom_onu/broadcom_onu.py b/voltha/adapters/broadcom_onu/broadcom_onu.py
index 9504a92..113245a 100644
--- a/voltha/adapters/broadcom_onu/broadcom_onu.py
+++ b/voltha/adapters/broadcom_onu/broadcom_onu.py
@@ -335,12 +335,8 @@
         if event_msg['event'] == 'activation-completed':
 
             if event_msg['event_data']['activation_successful'] == True:
-                for uni in self.uni_ports:
-                    port_no = self.proxy_address.channel_id + uni
-                    yield self.message_exchange(
-                         self.proxy_address.onu_id,
-                         self.proxy_address.onu_session_id,
-                         port_no)
+
+                yield self.message_exchange()
 
                 device = self.adapter_agent.get_device(self.device_id)
                 device.connect_status = ConnectStatus.REACHABLE
@@ -1323,8 +1319,7 @@
             self.log.info('wait-for-response-exception', exc=str(e))
 
     @inlineCallbacks
-    def message_exchange(self, onu, gem, cvid):
-        self.log.info('message_exchange', onu=onu, gem=gem, cvid=cvid)
+    def message_exchange(self):
         # reset incoming message queue
         while self.incoming_messages.pending:
             _ = yield self.incoming_messages.get()
@@ -1573,7 +1568,6 @@
 
     def remove_interface(self, data):
         if isinstance(data, VEnetConfig):
-            parent_port_num = None
             onu_device = self.adapter_agent.get_device(self.device_id)
             ports = self.adapter_agent.get_ports(onu_device.parent_id, Port.ETHERNET_UNI)
             parent_port_num = None