blob: 859f1deb6459148a85bfee609268a9df961263b3 [file] [log] [blame]
Joey Armstrong36c9bcd2023-04-05 19:05:56 -04001# -*- makefile -*-
2# -----------------------------------------------------------------------
Joey Armstrong2c039362024-02-04 18:51:52 -05003# Copyright 2022-2024 Open Networking Foundation (ONF) and the ONF Contributors
Joey Armstrong36c9bcd2023-04-05 19:05:56 -04004#
5# Licensed under the Apache License, Version 2.0 (the "License");
6# you may not use this file except in compliance with the License.
7# You may obtain a copy of the License at
8#
9# http://www.apache.org/licenses/LICENSE-2.0
10#
11# Unless required by applicable law or agreed to in writing, software
12# distributed under the License is distributed on an "AS IS" BASIS,
13# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14# See the License for the specific language governing permissions and
15# limitations under the License.
16# -----------------------------------------------------------------------
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040017# https://gerrit.opencord.org/plugins/gitiles/onf-make
18# ONF.makefile.version = 1.0
19# -----------------------------------------------------------------------
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040020
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040021##-------------------##
22##---] GLOBALS [---##
23##-------------------##
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040024
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040025# Gather sources to check
26# TODO: implement deps, only check modified files
27shell-check-find := find .
28# vendor scripts but they really should be lintable
29shell-check-find += -name 'vendor' -prune
30shell-check-find += -o \( -name '*.sh' \)
31shell-check-find += -type f -print0
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040032
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040033# shell-check := $(env-clean) pylint
34shell-check := shellcheck
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040035
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040036shell-check-args += --check-sourced
37shell-check-args += --external-sources
38
39##-------------------##
40##---] TARGETS [---##
41##-------------------##
42ifndef NO-LINT-SHELL
43 lint : lint-shell
44endif
45
46## -----------------------------------------------------------------------
47## Intent: Perform a lint check on command line script sources
48## -----------------------------------------------------------------------
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040049lint-shell:
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040050 $(shell-check) -V
51 @echo
52 $(HIDE)$(env-clean) $(shell-check-find) \
53 | $(xargs-n1) $(shell-check) $(shell-check-args)
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040054
Joey Armstrong96bcf1b2023-06-27 14:49:40 -040055## -----------------------------------------------------------------------
56## Intent: Display command help
57## -----------------------------------------------------------------------
58help-summary ::
59 @echo ' lint-shell Syntax check shell sources'
60
61# [SEE ALSO]
62# -----------------------------------------------------------------------
63# o https://www.shellcheck.net/wiki/Directive
Joey Armstrong36c9bcd2023-04-05 19:05:56 -040064
65# [EOF]