Remove fixPerms() method

Now that the problem causing "Permission denied" log entries is
understood, the fixPerms() method is no longer needed. All we need to
do is fix all instances where code tries to execute the configuration
file instead of passing it to voltctl.

Also include an extra change in jjb/ to trigger jenkins job in vars/.

Signed-off-by: Roger Luethi <roger@opennetworking.org>
Change-Id: I979e86eeabbb2d1df38286db66754b125f991a5e
diff --git a/jjb/pipeline/voltha/physical-build.groovy b/jjb/pipeline/voltha/physical-build.groovy
index 9dfb588..17d48b3 100755
--- a/jjb/pipeline/voltha/physical-build.groovy
+++ b/jjb/pipeline/voltha/physical-build.groovy
@@ -16,7 +16,6 @@
 
 // NOTE we are importing the library even if it's global so that it's
 // easier to change the keywords during a replay
-
 library identifier: 'cord-jenkins-libraries@master',
     retriever: modernSCM([
       $class: 'GitSCMSource',
diff --git a/vars/installVoltctl.groovy b/vars/installVoltctl.groovy
index 5a0a55b..14057b9 100644
--- a/vars/installVoltctl.groovy
+++ b/vars/installVoltctl.groovy
@@ -47,34 +47,6 @@
 }
 
 // -----------------------------------------------------------------------
-// Intent: Assign perms to fix access problems
-// . /bin/sh: 1: /home/jenkins/.volt/config: Permission denied
-// -----------------------------------------------------------------------
-void fixPerms() {
-    enter('fixPerms')
-
-    sh(label  : 'fixperms',
-       script : """
-
-      umask 022
-
-      declare volt_dir=\$HOME/.volt
-      declare volt_cfg=\$HOME/.volt/config
-
-      echo
-      echo "** Fixing perms: \$volt_cfg"
-      mkdir -p \$volt_dir
-      chmod -R u+w,go-rwx \$volt_dir
-      chmod u=rwx \$volt_dir
-      touch \$volt_cfg
-      /bin/ls -l \$volt_dir
-""")
-
-    leave('fixPerms')
-    return
-}
-
-// -----------------------------------------------------------------------
 // -----------------------------------------------------------------------
 Boolean process(String branch) {
     Boolean ans = true
@@ -193,7 +165,6 @@
 def call(String branch) {
     try {
         enter('main')
-        fixPerms()
         process(branch)
     }
     catch (Exception err) {  // groovylint-disable-line CatchException