Always update dependencies before linting charts
Change-Id: Ie125246d79972e0b920b8fcddfd2b12b35889778
diff --git a/compare_service_chart_versions.sh b/compare_service_chart_versions.sh
index b1023fd..8d6c031 100755
--- a/compare_service_chart_versions.sh
+++ b/compare_service_chart_versions.sh
@@ -21,7 +21,7 @@
REPODIR=${REPODIR:-~/cord}
DEBUG=${DEBUG:-false}
-for CHART in $REPODIR/helm-charts/xos-services/*
+for CHART in "$REPODIR"/helm-charts/xos-services/*
do
APPVERSION=$( awk '/^appVersion:/ { print $2 }' "$CHART/Chart.yaml" )
SVCNAME=$( basename "$CHART")
diff --git a/helmlint.sh b/helmlint.sh
index c068c28..1f97e50 100755
--- a/helmlint.sh
+++ b/helmlint.sh
@@ -49,11 +49,8 @@
echo "Checking chart: $chartdir"
- # update dependencies for profiles/workflows, as they include TOSCA from required charts
- if [[ $chartdir =~ xos-profiles || $chartdir =~ workflows ]] && [ -f "${chartdir}/requirements.yaml" ]
- then
- helm dependency update "${chartdir}"
- fi
+ # update dependencies (if any)
+ helm dependency update "${chartdir}"
# lint the chart (with values.yaml if it exists)
if [ -f "${chartdir}/values.yaml" ]; then
diff --git a/wait_for_pods.sh b/wait_for_pods.sh
index 6d58010..2dedbba 100755
--- a/wait_for_pods.sh
+++ b/wait_for_pods.sh
@@ -28,7 +28,7 @@
KUBECTL_ARGS=${KUBECTL_ARGS:-}
# use namespace if passed as first arg, or "all" for all namespaces
-if [ ! -z "$1" ]
+if [ -n "$1" ]
then
if [[ "$1" == "all" ]]
then