Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 1 | # |
| 2 | # Copyright 2016 the original author or authors. |
| 3 | # |
| 4 | # Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | # you may not use this file except in compliance with the License. |
| 6 | # You may obtain a copy of the License at |
| 7 | # |
| 8 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | # |
| 10 | # Unless required by applicable law or agreed to in writing, software |
| 11 | # distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | # See the License for the specific language governing permissions and |
| 14 | # limitations under the License. |
| 15 | # |
| 16 | |
| 17 | # set default shell |
| 18 | SHELL = bash -e -o pipefail |
| 19 | |
| 20 | # Variables |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 21 | VERSION ?= $(shell cat ./VERSION) |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 22 | |
| 23 | DOCKER_LABEL_VCS_DIRTY = false |
| 24 | ifneq ($(shell git ls-files --others --modified --exclude-standard 2>/dev/null | wc -l | sed -e 's/ //g'),0) |
| 25 | DOCKER_LABEL_VCS_DIRTY = true |
| 26 | endif |
| 27 | ## Docker related |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 28 | DOCKER_EXTRA_ARGS ?= |
| 29 | DOCKER_REGISTRY ?= |
| 30 | DOCKER_REPOSITORY ?= |
| 31 | DOCKER_TAG ?= ${VERSION}$(shell [[ ${DOCKER_LABEL_VCS_DIRTY} == "true" ]] && echo "-dirty" || true) |
| 32 | ADAPTER_IMAGENAME := ${DOCKER_REGISTRY}${DOCKER_REPOSITORY}ofagent-go |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 33 | |
| 34 | ## Docker labels. Only set ref and commit date if committed |
| 35 | DOCKER_LABEL_VCS_URL ?= $(shell git remote get-url $(shell git remote)) |
| 36 | DOCKER_LABEL_VCS_REF = $(shell git rev-parse HEAD) |
| 37 | DOCKER_LABEL_BUILD_DATE ?= $(shell date -u "+%Y-%m-%dT%H:%M:%SZ") |
| 38 | DOCKER_LABEL_COMMIT_DATE = $(shell git show -s --format=%cd --date=iso-strict HEAD) |
| 39 | |
| 40 | DOCKER_BUILD_ARGS ?= \ |
| 41 | ${DOCKER_EXTRA_ARGS} \ |
| 42 | --build-arg org_label_schema_version="${VERSION}" \ |
| 43 | --build-arg org_label_schema_vcs_url="${DOCKER_LABEL_VCS_URL}" \ |
| 44 | --build-arg org_label_schema_vcs_ref="${DOCKER_LABEL_VCS_REF}" \ |
| 45 | --build-arg org_label_schema_build_date="${DOCKER_LABEL_BUILD_DATE}" \ |
| 46 | --build-arg org_opencord_vcs_commit_date="${DOCKER_LABEL_COMMIT_DATE}" \ |
| 47 | --build-arg org_opencord_vcs_dirty="${DOCKER_LABEL_VCS_DIRTY}" |
| 48 | |
| 49 | DOCKER_BUILD_ARGS_LOCAL ?= ${DOCKER_BUILD_ARGS} \ |
| 50 | --build-arg LOCAL_PROTOS=${LOCAL_PROTOS} |
| 51 | |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 52 | # tool containers |
| 53 | VOLTHA_TOOLS_VERSION ?= 1.0.3 |
| 54 | |
| 55 | GO = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app $(shell test -t 0 && echo "-it") -v gocache:/.cache -v gocache-${VOLTHA_TOOLS_VERSION}:/go/pkg voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golang go |
| 56 | GO_JUNIT_REPORT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -i voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-go-junit-report go-junit-report |
| 57 | GOCOVER_COBERTURA = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -i voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-gocover-cobertura gocover-cobertura |
| 58 | GOFMT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app $(shell test -t 0 && echo "-it") voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golang gofmt |
| 59 | GOLANGCI_LINT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app $(shell test -t 0 && echo "-it") -v gocache:/.cache -v gocache-${VOLTHA_TOOLS_VERSION}:/go/pkg voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golangci-lint golangci-lint |
| 60 | HADOLINT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app $(shell test -t 0 && echo "-it") voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-hadolint hadolint |
| 61 | |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 62 | .PHONY: docker-build local-protos local-voltha |
| 63 | |
| 64 | # This should to be the first and default target in this Makefile |
| 65 | help: |
| 66 | @echo "Usage: make [<target>]" |
| 67 | @echo "where available targets are:" |
| 68 | @echo |
| 69 | @echo "docker-build : Build ofagent-go docker image" |
| 70 | @echo "help : Print this help" |
| 71 | @echo "docker-push : Push the docker images to an external repository" |
| 72 | @echo "lint : Run lint verification, depenancy, gofmt and reference check" |
| 73 | @echo "sca : Runs various SCA through golangci-lint tool" |
| 74 | @echo "test : Run unit tests, if any" |
| 75 | @echo |
| 76 | |
| 77 | |
| 78 | ## Local Development Helpers |
| 79 | |
| 80 | local-protos: |
| 81 | ifdef LOCAL_PROTOS |
| 82 | mkdir -p vendor/github.com/opencord/voltha-protos/go |
| 83 | cp -r ${GOPATH}/src/github.com/opencord/voltha-protos/go/* vendor/github.com/opencord/voltha-protos/go |
| 84 | endif |
| 85 | |
| 86 | local-voltha: |
| 87 | ifdef LOCAL_VOLTHA |
| 88 | mkdir -p vendor/github.com/opencord/voltha-go/ |
| 89 | cp -rf ${GOPATH}/src/github.com/opencord/voltha-go/ vendor/github.com/opencord/ |
| 90 | rm -rf vendor/github.com/opencord/voltha-go/vendor |
| 91 | endif |
| 92 | |
| 93 | |
| 94 | ## Docker targets |
| 95 | |
| 96 | docker-build: local-protos local-voltha |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 97 | docker build $(DOCKER_BUILD_ARGS) -t ${ADAPTER_IMAGENAME}:${DOCKER_TAG} -t ${ADAPTER_IMAGENAME}:latest -f docker/Dockerfile.ofagent-go . |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 98 | |
| 99 | docker-push: |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 100 | docker push ${ADAPTER_IMAGENAME}:${DOCKER_TAG} |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 101 | |
| 102 | ## lint and unit tests |
| 103 | |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 104 | lint-dockerfile: |
| 105 | @echo "Running Dockerfile lint check..." |
| 106 | @${HADOLINT} $$(find . -name "Dockerfile.*") |
| 107 | @echo "Dockerfile lint check OK" |
| 108 | |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 109 | lint-style: |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 110 | @echo "Running style check..." |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 111 | @gofmt_out="$$(${GOFMT} -l $$(find . -name '*.go' -not -path './vendor/*'))" ;\ |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 112 | if [ ! -z "$$gofmt_out" ]; then \ |
| 113 | echo "$$gofmt_out" ;\ |
| 114 | echo "Style check failed on one or more files ^, run 'go fmt' to fix." ;\ |
| 115 | exit 1 ;\ |
| 116 | fi |
| 117 | @echo "Style check OK" |
| 118 | |
| 119 | lint-sanity: |
| 120 | @echo "Running sanity check..." |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 121 | @${GO} vet -mod=vendor ./... |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 122 | @echo "Sanity check OK" |
| 123 | |
Don Newton | e0d34a8 | 2019-11-14 10:58:06 -0500 | [diff] [blame] | 124 | lint-mod: |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 125 | @echo "Running dependency check..." |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 126 | @${GO} mod verify |
| 127 | @echo "Dependency check OK. Running vendor check..." |
| 128 | @git status > /dev/null |
| 129 | @git diff-index --quiet HEAD -- go.mod go.sum vendor || (echo "ERROR: Staged or modified files must be committed before running this test" && echo "`git status`" && exit 1) |
| 130 | @[[ `git ls-files --exclude-standard --others go.mod go.sum vendor` == "" ]] || (echo "ERROR: Untracked files must be cleaned up before running this test" && echo "`git status`" && exit 1) |
| 131 | ${GO} mod tidy |
| 132 | ${GO} mod vendor |
| 133 | @git status > /dev/null |
| 134 | @git diff-index --quiet HEAD -- go.mod go.sum vendor || (echo "ERROR: Modified files detected after running go mod tidy / go mod vendor" && echo "`git status`" && exit 1) |
| 135 | @[[ `git ls-files --exclude-standard --others go.mod go.sum vendor` == "" ]] || (echo "ERROR: Untracked files detected after running go mod tidy / go mod vendor" && echo "`git status`" && exit 1) |
| 136 | @echo "Vendor check OK." |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 137 | |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 138 | lint: lint-style lint-sanity lint-mod lint-dockerfile |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 139 | |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 140 | test: |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 141 | @mkdir -p ./tests/results |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 142 | @${GO} test -mod=vendor -v -coverprofile ./tests/results/go-test-coverage.out -covermode count ./... 2>&1 | tee ./tests/results/go-test-results.out ;\ |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 143 | RETURN=$$? ;\ |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 144 | ${GO_JUNIT_REPORT} < ./tests/results/go-test-results.out > ./tests/results/go-test-results.xml ;\ |
| 145 | ${GOCOVER_COBERTURA} < ./tests/results/go-test-coverage.out > ./tests/results/go-test-coverage.xml ;\ |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 146 | exit $$RETURN |
| 147 | |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 148 | sca: |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 149 | @rm -rf ./sca-report |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 150 | @mkdir -p ./sca-report |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 151 | @echo "Running static code analysis..." |
| 152 | @${GOLANGCI_LINT} run --deadline=4m --out-format junit-xml ./... | tee ./sca-report/sca-report.xml |
| 153 | @echo "" |
| 154 | @echo "Static code analysis OK" |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 155 | |
| 156 | clean: |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 157 | rm -rf ./sca-report |
Don Newton | 98fd881 | 2019-09-23 15:15:02 -0400 | [diff] [blame] | 158 | |
| 159 | distclean: clean |
| 160 | rm -rf ${VENVDIR} |
| 161 | |
Kent Hagerman | 6379e09 | 2020-02-18 18:05:57 -0500 | [diff] [blame^] | 162 | mod-update: |
| 163 | ${GO} mod tidy |
| 164 | ${GO} mod vendor |