commit e135d69f06a1d430a65ab9df1d7f344d8e37920c
author A R Karthick <kramanar@ciena.com> Tue Oct 29 00:15:51 2019 +0000
committer Saurav Das <sauravdas@alumni.stanford.edu> Tue Oct 29 16:30:17 2019 -0700
tree dc17ce1e0712ca27e74ce2ec2d4827d810e0c234
parent 8c003b16b554f0b04c0fc7a46df46b2e798eb22f

Remove meters when the device is removed or becomes unavailable.
Amendments:
  Rename removeAllMeters to removeDeviceMetersFromBpMap.
Change-Id: I202c99f9a3fc84d5503273c62efae51fd5d6ddf7

app/src/main/java/org/opencord/olt/impl/Olt.java

diff --git a/app/src/main/java/org/opencord/olt/impl/Olt.java b/app/src/main/java/org/opencord/olt/impl/Olt.java
index 4775cc9..9d5240f 100644
--- a/app/src/main/java/org/opencord/olt/impl/Olt.java
+++ b/app/src/main/java/org/opencord/olt/impl/Olt.java
@@ -1751,6 +1751,7 @@
                                         AccessDeviceEvent.Type.UNI_REMOVED, devId, p)));
                         programmedDevices.remove(devId);
                         removeAllSubscribers(devId);
+                        removeDeviceMetersFromBpMap(devId);
                         post(new AccessDeviceEvent(
                                 AccessDeviceEvent.Type.DEVICE_DISCONNECTED, devId,
                                 null, null));
@@ -1765,6 +1766,7 @@
                         } else {
                             programmedDevices.remove(devId);
                             removeAllSubscribers(devId);
+                            removeDeviceMetersFromBpMap(devId);
                             post(new AccessDeviceEvent(
                                     AccessDeviceEvent.Type.DEVICE_DISCONNECTED, devId,
                                     null, null));
@@ -1794,6 +1796,18 @@
 
             connectPoints.forEach(cp -> programmedSubs.remove(cp));
         }
+
+        private void removeDeviceMetersFromBpMap(DeviceId deviceId) {
+            bpInfoToMeter.values().forEach(meterKeys -> meterKeys.stream()
+                    .filter(meterKey -> meterKey.deviceId().equals(deviceId)).findFirst().
+                            ifPresent(mk -> {
+                                meterKeys.remove(mk);
+                                programmedMeters.remove(mk);
+                                log.info("Deleted from the internal map. MeterKey {}", mk);
+                                log.info("Programmed meters {}", programmedMeters);
+                            }));
+        }
+
     }
 
     private class InternalMeterListener implements MeterListener {
@@ -1843,4 +1857,4 @@
                             }));
         }
     }
-}
\ No newline at end of file
+}