blob: 42345bdba3d476ed35bc5fdc6a36a8ace7f5340d [file] [log] [blame]
Andrew J. Schorr43540882006-11-28 16:36:39 +000012006-11-28 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
2
3 * ospf_vty.c: (ospf_passive_interface_default) Take additional
4 'newval' arg so we can update ospf->passive_interface_default inside
5 this function. More importantly, we now call ospf_if_set_multicast
6 on all ospf_interfaces.
7 (ospf_passive_interface, no_ospf_passive_interface) Fix bug:
8 for 'default' case, argv[0] is undefined, so we must test for
9 (argc == 0) before using argv[0]. And since
10 ospf_passive_interface_default now calls ospf_if_set_multicast as
11 needed, we can just return after calling
12 ospf_passive_interface_default.
13
Andrew J. Schorr8fb8a502006-10-24 19:04:26 +0000142006-10-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
15
16 * ospf_zebra.c: (ospf_redistribute_default_set) Fix bug where
17 a new value for ospf->default_originate was being ignored
18 if a previous 'default-information originate' command
19 had already been processed.
20
Paul Jakma7ffa8fa2006-10-22 20:07:53 +0000212006-10-22 Yar Tikhiy <yar@comp.chem.msu.su>
22
23 * (general) Add support for passive-interface default (with
24 minor edits by Paul Jakma).
25 * ospf_interface.h: Add OSPF_IF_PASSIVE_STATUS macro, looking
26 at configured value, or the global 'default' value, as
27 required.
28 * ospf_interface.c: (ospf_if_new_hook) Leave passive
29 unconfigured per default, allowing global 'default' to
30 take effect for unconfigured interfaces.
31 * ospf_packet.c: (various) use OSPF_IF_PASSIVE_STATUS
32 * ospf_vty.c: (ospf_passive_interface_default) new function,
33 unset passive from all interfaces if default is enabled, as
34 the per-iface settings become redundant.
35 (ospf_passive_interface_update) new func, update passive
36 setting taking global default into account.
37 ({no,}ospf_passive_interface_addr_cmd) Add support for
38 'default' variant of command.
39 (show_ip_ospf_interface_sub) Update to take global
40 default into account when printing passive status.
41 (ospf_config_write) ditto.
42 * ospfd.c: (ospf_new) set global passive-interface default.
43 * ospfd.h: (struct ospf) Add field for global
44 passive-interface.
45
Andrew J. Schorr08c83672006-09-25 13:26:14 +0000462006-09-25 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
47
48 * ospf_packet.c: (ospf_packet_dup, ospf_make_md5_digest)
49 Fix zlog_warn messages to eliminate compiler warnings.
50 (ospf_hello) Improve warning messages to show why we
51 are complaining.
52
Paul Jakmab5aeb442006-08-30 18:47:37 +0000532006-08-28 Andy Gay <andy@andynet.net>
54
55 * ospf_packet.c: (ospf_make_db_desc) Assert added with More-bit
56 fixes does not hold up with addition of Ogier DB-Exchange
57 optimisation, which can empty the db-summary list in between
58 sent DD packets. Remove assert, update More-bit always when
59 in Exchange.
60
Paul Jakma29b5a042006-08-27 08:01:20 +0000612006-08-27 J.J. Krabbendam <jkrabbendam@aimsys.nl>
62
63 * ospfd.c: (ospf_finish_final) default redistribute should be
64 unset too, fixes bug where reconfiguring ospfd completely
65 can no longer enable default redistribution.
66
Paul Jakma2518efd2006-08-27 06:49:29 +0000672006-08-25 Paul Jakma <paul.jakma@sun.com>
68
69 * (general) Bug #134. Be more robust to backward time changes,
70 use the newly added libzebra time functions.
71 In most cases: recent_time -> recent_relative_time()
72 gettimeofday -> quagga_gettime (QUAGGA_CLK_MONOTONIC, ..)
73 time -> quagga_time.
74 (ospf_make_md5_digest) time() call deliberately not changed.
75 (ospf_external_lsa_refresh) remove useless gettimeofday, LSA
76 tv_orig time was already set in ospf_lsa_new, called via
77 ospf_external_lsa_new.
78
Paul Jakmaba122e72006-08-27 06:24:34 +0000792006-08-04 Paul Jakma <paul.jakma@sun.com>
80
81 * ospf_lsdb.c: (ospf_lsdb_delete_entry) new function, consolidate
82 exact same functionality replicated in other functions.
83 (ospf_lsdb_add) Strip out code by using ospf_lsdb_delete_entry.
84 (ospf_lsdb_delete) ditto.
85 (ospf_lsdb_delete_all) ditto.
86
Paul Jakma8dd24ee2006-08-27 06:29:30 +0000872006-08-03 Paul Jakma <paul.jakma@sun.com>
88
89 * ospf_packet.c: (ospf_make_db_desc) Unset the DD More bit
90 after constructing the packet, if appropriate.
91 (ospf_db_desc_proc) Speed up Exchange, slave should raise
92 ExchangeDone earlier, as RFC mandates, by forming its reply
93 before deciding whether both sides are done, avoids a
94 needless round of empty DD packet exchanges at the end of
95 Exchange, hence speeding up ExchangeDone.
Paul Jakmaf0894cf2006-08-27 06:40:04 +000096 Implement draft-ogier-ospf-dbex-opt DB-exchange optimisation.
Paul Jakma8dd24ee2006-08-27 06:29:30 +000097 (ospf_db_desc) use UNSET_FLAG macro.
98
Andrew J. Schorr16700082006-07-27 22:29:06 +0000992006-07-27 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
100
101 * ospfd.c: (ospf_router_id_update) Fix and document the algorithm for
102 selecting the router ID: if there is not a statically configured ID,
103 then stick to the most recent value to avoid disruptive changes.
104 This should fix bug #288.
105
Paul Jakma1fe6ed32006-07-26 09:37:26 +00001062006-07-26 Paul Jakma <paul.jakma@sun.com>
107
108 * ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
109 to the LSA to be 'unlocked', so that, if the LSA is freed, the
110 callers pointer to the LSA can be NULLed out, allowing any further
111 use of that pointer to provoke a crash sooner rather than later.
112 * ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
113 previous. Try annotate 'locking' somewhat to show which 'locks'
114 are protecting what LSA reference, if not obvious.
115 * ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
116 goto, replace with return.
117 * ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
118 the dual-loop predated the delete-safe list-loop macro.
119
Paul Jakma3fed4162006-07-25 20:44:12 +00001202006-07-25 Paul Jakma <paul.jakma@sun.com>
121
122 * ospf_neigbor.h: (struct ospf_neighbor) Add some additional
123 neighbour state statistics fields, timestamps for progressive
124 and regressive state changes, and pointer to event string
125 for the latter state change.
126 * ospf_nsm.c: (nsm_notice_state_change) Update new state changs
127 history as required.
128 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print out above
129 new per-neighbour state change stats.
130
Paul Jakma539e1522006-07-11 17:49:22 +00001312006-07-10 Paul Jakma <paul.jakma@sun.com>
132
133 * ospf_nsm.c: (nsm_change_state) call nsm_clear_adj for all
134 adjacency losses, hence removing need for nsm_reset_nbr.
135 (nsm_reset_nbr) kill it, clear_adj in previous does fine.
136 (nsm_kill_nbr,nsm_start) remove nsm_reset_nbr call.
137 (ospf_nsm_event) Allow NSM function to be NULL, this along with
138 removal of nsm_reset_nbr, allows a bunch of now useless functiosn
139 to be removed.
140 Remove some useless variables.
141 (nsm_ignore) now useless, remove.
142 (nsm_bad_ls_req) ditto
143 (nsm_seq_number_mismatch) "
144 (nsm_oneway_received) "
145 (nsm_inactivity_timer) "
146 (nsm_ll_down) "
147 (NSM) replace removed action functions with NULL.
Paul Jakma3d63f382006-07-11 17:52:53 +0000148 (nsm_notice_state_changes) Move state change logging code to new
149 func to declutter nsm_change_state and ospf_nsm_event.
150 Log event with AdjChange, it's useful to know.
151 (nsm_change_state) move adjchange and snmp logging to previous.
152 (ospf_nsm_event) call nsm_notice_state_changes from here.
153 Move the debug message to entry of function, so it gets out
154 even if something goes wrong.
Paul Jakma90c33172006-07-11 17:57:25 +0000155 Record state change timestamp and event in nbr struct.
156 * ospf_neighbor.h: (struct ospf_neighbor) Add fields to record
157 timestamp of last NSM change and event.
158 * ospf_vty.c: (show_ip_ospf_neighbor_detail_sub) Print
159 last state change timestamp and event, if available.
Paul Jakma539e1522006-07-11 17:49:22 +0000160
Andrew J. Schorr13cd3dc2006-07-11 01:50:30 +00001612006-07-10 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
162
163 * ospf_packet.c: (ospf_hello) Improve NetworkMask mismatch warning
164 message to include interface name and conflicting prefix lengths.
165
Paul Jakma1f2c2742006-07-10 07:45:13 +00001662006-07-07 Paul Jakma <paul.jakma@sun.com>
167
168 * ospf_nsm.h: Add a NSM_Deleted neighbour state, to act as dummy
169 state indicating the neighbour is to be deleted.
170 * ospf_nsm.c: (general) Use the NSM_Deleted state to delete
171 neighbours, thus allowing code to be slightly more obvious
172 in its flow.
173 (nsm_timer_set) Add NSM_Deleted. Add another timer the code
174 missed.
175 (nsm_kill_nbr) No need for special case call to nsm_change_state
176 anymore.
177 Make the assert and error-handling for same case more readable
178 (Andrew Schorr)
179 Remove the call to ospf_nbr_delete, nsm_change_state can do
180 this generally now via NSM_Deleted.
181 (struct ... NSM) Add the dummy NSM_Deleted state, the 3 events
182 that can lead to nsm_kill_nbr all now transition the NBR to
183 NSM_Deleted and the general change_state function can be left
184 to do the work.
185 (ospf_nsm_event) Special casing of events and early-return can
186 be removed now.
187 On transition into Deleted, delete the nbr.
188 * ospf_dump.c: (ospf_nsm_state_msg) Add Deleted.
189
Paul Jakmaaa2737a2006-07-06 11:12:39 +00001902006-07-06 Paul Jakma <paul.jakma@sun.com>
191
192 * ospf_nsm.c: (ospf_nsm_event) LLDown event also results in nbr
193 being deleted, requires early-return too. Likely explains
194 some crash reports after interface events.
195
Paul Jakmaf7a76ab2006-07-04 13:57:49 +00001962006-07-04 Paul Jakma <paul.jakma@sun.com>
197
198 * ospf_nsm.c: (general) Various small cleanups from Andrew's
199 review of last set of patches.
200 (nsm_timer_set) Loading, Full and default can share
201 same code too.
202 (nsm_should_adj) Can just be one big OR.
203 (nsm_twoway_received) Collapse into return statement.
204
Paul Jakmad7b0fb62006-07-04 13:35:24 +00002052006-07-02 Paul Jakma <paul.jakma@sun.com>
206
207 * ospf_nsm.c: (nsm_should_adj) New function, just consolidate the
208 10.4 adjacency check from nsm_twoway_received/nsm_adj_ok.
209 (nsm_twoway_received/nsm_adj_ok) Use former.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000210 (nsm_clear_adj) clear adjacency related state for a
211 neighbour, needed for some state changes from > ExStart down
212 to ExStart or less, which need not go through nsm_reset_nbr.
213 (nsm_reset_nbr) move code to former. Should be static.
Paul Jakmaba0beb42006-07-04 13:44:19 +0000214 (ospf_nsm_event) Don't allow action functions to change
215 next_state if the NSM tables do not indicate next_state is
216 conditional, log warning if one tries - existing code
217 appears fine though.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000218 Remove long dead code.
219 Use nsm_clear_adj for state changes that take down
220 adjacencies to TwoWay/ExStart.
Paul Jakmae55dd532006-07-04 13:46:14 +0000221 (nsm_timer_set) ls_req timer should be OFF in early states.
222 Compact several identical sections.
223 Set inactivity timer to OFF for Down, for documentary
224 purposes.
Paul Jakmad1b1cd82006-07-04 13:50:44 +0000225 (nsm_kill_nbr) Oops, action function shouldn't try return
226 1 for error.
Paul Jakma5db95bc2006-07-04 13:52:29 +0000227 * ospf_lsa.c: (ospf_translated_nssa_refresh) CID #13.
Paul Jakmad7b0fb62006-07-04 13:35:24 +0000228
Andrew J. Schorr1c066bf2006-06-30 16:53:47 +00002292006-06-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
230
231 * ospf_vty.c: (show_ip_ospf_neighbor_id) Should show all instances
232 of that neighbor (since it may appear on multiple interfaces)
233 instead of bailing out after showing the first match.
234
Andrew J. Schorr76947872006-06-30 03:21:05 +00002352006-06-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
236
237 * ospf_nsm.c: (nsm_twoway_received) When deciding whether to
238 change from state Init to ExStart, the test for whether the
239 neighboring router is DR or BDR should be against the
240 local router's notion of DR/BDR, not the neighbor's view.
241
Andrew J. Schorrd7e60dd2006-06-29 20:20:52 +00002422006-06-28 Erik Muller <erikm@internap.com>
243
244 * ospfd.h: Define 2 new struct ospf config flags:
245 OSPF_LOG_ADJACENCY_CHANGES and OSPF_LOG_ADJACENCY_DETAIL
246 * ospf_nsm.c (nsm_change_state): Log adjacency changes if
247 requested.
248 * ospf_vty.c (ospf_log_adjacency_changes): New command function
249 to implement ospf subcommand "log-adjacency-changes [detail]".
250 (no_ospf_log_adjacency_changes) Turn off log-adjacency-changes.
251 (show_ip_ospf) Show whether adjacency changes are logged.
252 (ospf_config_write) Add "log-adjacency-changes [detail]" to config.
253 (ospf_vty_init) Add ospf_log_adjacency_changes and
254 no_ospf_log_adjacency_changes.
255
Paul Jakma9560fa82006-06-26 12:50:06 +00002562006-06-26 Paul Jakma <paul.jakma@sun.com>
257
258 * ospf_abr.c: (general) NSSA translate-candidate ABRs need to
259 be ASBRs, or other routers may rightfully refuse to install
260 translated type-5s LSAs. reported by dendroot@gmail.com.
261 (ospf_abr_nssa_check_status) Detect change in translator
262 state when ABR, and inc/dec redistribute count as when we
263 leave/enter the disabled state - so that translate-enabled
264 ABR properly sets ASBR bit on non-NSSA areas.
265 Run the resulting function through indent to clean it up.
266 * ospf_lsa.c: (router_lsa_flags) For purposes of ASBR bit,
267 NSSA area is same as stub area.
268
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +00002692006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
270
Andrew J. Schorr9aecfae2006-06-24 20:05:02 +0000271 * ospf_snmp.c: (ospfTrapNbrStateChange, ospfTrapIfStateChange) Improve
272 info log message to indicate why the trap is being sent.
273
2742006-06-24 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
275
Andrew J. Schorr0ffb7092006-06-24 19:40:13 +0000276 * ospf_dump.c: (config_write_debug) Fix typo to show debug ospf nsm
277 status properly (not ism status).
278
Andrew J. Schorr6e72cb62006-06-18 00:45:48 +00002792006-06-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
280
281 * ospf_vty.c: ({no_,}ospf_passive_interface) Replace if_lookup_by_name
282 with a call to if_get_by_name -- if the interface does not exist
283 already, it should be created. And remove the obsolete warning
284 message.
285
Paul Jakma429ac782006-06-15 18:40:49 +00002862006-06-15 Paul Jakma <paul.jakma@sun.com>
287
288 * ospf_interface.h: (struct ospf_if_info) Add reference counts
289 for multicast group memberships. Add various macros to help
290 manipulate/check membership state.
291 * ospf_interface.c: (ospf_if_set_multicast) Maintain the
292 ospf_if_info reference counts, and only actually drop
293 memberships if it hits 0, to avoid losing membership when
294 OSPF is disabled on an interface with multiple active OSPF
295 interfaces.
296 * ospf_packet.c: (ospf_{hello,read}) Use the new macros to
297 check/set
298 multicast membership.
299 * ospf_vty.c: (show_ip_ospf_interface_sub) ditto.
300
Paul Jakmaac904de2006-06-15 12:04:57 +00003012006-05-31 Paul Jakma <paul.jakma@sun.com>
302
303 * ospf_lsdb.c: (ospf_lsdb_delete) robustify against NULL arguments,
304 print warning.
305 * ospf_lsa.c: (ospf_discard_from_db) ditto.
306 (ospf_maxage_lsa_remover) Check lsa->lsdb for validity, possible
307 mitigation (but not solution) for bug #269.
308
Paul Jakma88871b12006-06-15 11:41:19 +00003092006-05-30 Paul Jakma <paul.jakma@sun.com>
310
311 * ospf_packet.c: (ospf_read) Debug message about packets
312 received on unenabled interfaces should be conditional on
313 debug being set.
314
Paul Jakmad1c65c22006-06-27 08:01:43 +00003152006-05-23 Paul Jakma <paul.jakma@sun.com>
316
317 * ospf_vty.c: (general) Replace in-place route redistribution
318 command and help strings with the new auto-generated defines
319 from lib/route_types.h
320
Paul Jakmaae128052006-05-12 23:15:30 +00003212006-05-13 Paul Jakma <paul.jakma@sun.com>
322
323 * ospf_lsa.c: (ospf_translated_nssa_refresh) fix the sanity
324 check to match the assert, small error in CID #13 fix.
325
Paul Jakma70461d72006-05-12 22:57:57 +00003262006-05-12 Paul Jakma <paul.jakma@sun.com>
327
328 * ospf_lsa.c: (ospf_lsa_action) Get rid of the ospf_lookup
329 call, which is not checked for NULL return, by stripping out
330 functionality which is never used, hence fixing Coverity CID
331 #29.
332 (struct lsa_action) remove unused member.
Paul Jakmae54e6e52006-05-12 23:11:14 +0000333 (ospf_translated_nssa_refresh) Add non-assert sanity check,
334 in case DEBUG isn't defined.
335 Debug message when no type7 exists should print the ID from
336 the type5, not the type7, fixes CID #13.
337 * ospf_interface.c: (ospf_if_exists) Fix missing NULL return
Paul Jakmae43be0e2006-05-12 23:00:06 +0000338 check on ospf_lookup, CID #27.
Paul Jakma6db3a6f2006-05-12 23:02:46 +0000339 * ospf_asbr.c: (ospf_redistribute_withdraw) remove ospf_lookup
340 call by taking the struct ospf * as argument, which the
341 caller has, fixing CID #28.
342 * ospf_asbr.h: (ospf_redistribute_withdraw) update declaration
343 * ospf_zebra.c: (ospf_redistribute_unset) update call to
344 ospf_redistribute_withdraw to match.
Paul Jakmabfd7c7d2006-05-12 23:04:45 +0000345 * ospf_ia.c: (ospf_update_router_route) ospf->backbone could be
346 NULL when passed to ospf_find_asbr_route_through_area,
347 check for NULL first, CID #14.
Paul Jakmadeb15612006-05-12 23:07:27 +0000348 * ospf_ism.c: (ism_change_state) NULL check on oi->area is
349 useless, it's always valid. Only possibility where it
350 couldn't be is if there is a race between abr_task and
351 cleaning up oi's, in which case a NULL check here isn't going
352 to do anything. Fixes CID #15.
Paul Jakma70461d72006-05-12 22:57:57 +0000353
Paul Jakmacac3b5c2006-05-11 13:31:11 +00003542006-05-11 Paul Jakma <paul.jakma@sun.com>
355
356 * ospf_vty.c: (general) Audit ospf_lookup calls in commands,
357 ensure check for NULL result, make vty messages consistent.
358 (show_ip_ospf_interface) Missing NULL check on ospf_lookup
359 result, fixes Coverity CID #70.
Paul Jakma1a8ec2b2006-05-11 13:34:08 +0000360 (no_ospf_area_filter_list) Check NULL result from
361 ospf_area_lookup_by_area_id, fixes Coverity CID #69
Paul Jakma894f8b62006-05-12 22:50:40 +0000362 * ospf_route.c: (ospf_route_delete_same_ext) Fix deref before
363 NULL check by moving into check-protected block, fix CID #49.
Paul Jakma214a4452006-05-12 22:51:49 +0000364 * ospf_abr.c: (ospf_area_range_cost_set) Shouldn't create a new
365 range, should just lookup to see if one exists, the new range
366 is just leaked. Fixes CID #46.
Paul Jakma4021b602006-05-12 22:55:41 +0000367 * ospf_lsa.c: (ospf_default_originate_timer) Let the thread
368 take (struct ospf *) as thread argument, rather than (struct
369 ospf *)->default_originate, thus avoiding having to call
370 ospf_lookup.
371 * ospf_zebra.c: (ospf_redistribute_default_set) change setup
372 of ospf_default_originate_timer thread to match.
373 * ospfd.c: (ospf_router_id_update) ditto.
Paul Jakmacac3b5c2006-05-11 13:31:11 +0000374
Paul Jakma9c27ef92006-05-04 07:32:57 +00003752006-04-24 Paul Jakma <paul.jakma@sun.com>
376
377 * (general) More Virtual-link fixes, again with much help in
378 testing / debug from Juergen Kammer. Primarily in SPF.
379 * ospf_spf.h: Add guard. ospf_interface.h will include this
380 header.
381 * ospf_interface.h: Modify ospf_vl_lookup definition to take
382 struct ospf as argument, so as to allow for NULL area
383 argument.
384 (struct ospf_vl_data) Remove out_oi, instead add a struct
385 vertex_nexthop, to use as initial nexthop for backbone paths
386 through a vlink.
387 * ospf_interface.c: (ospf_vl_lookup) Modified to allow
388 NULL area to be passed to indicate "any" (first) area.
389 Add extra debug.
390 (ospf_vl_set_params) vl_oi -> nexthop. Add extra debug.
391 (ospf_vl_up_check) Fix debug, inet_ntoa returns a static
392 buffer..
393 * ospf_route.c: (ospf_intra_add_router) Vlinks dont go through
394 backbone, don't bother checking.
395 * ospf_spf.c: (static struct list vertex_list) Record vertices
396 that will need to be freed.
397 (cmp) Order network before router vertices, as required,
398 wasn't implemented.
399 (vertex_nexthop_free) Mild additional robustness check.
400 (vertex_parent_free) Take void argument, as this function
401 is passed as list deconstructor for vertex parent list.
402 (ospf_vertex_new) More debug. Set deconstructor for parent
403 list. Track allocated vertices on the vertex_list.
404 (ospf_vertex_free) Get rid of the tricky recursive cleanup of
405 vertices. Now frees only the given vertex.
406 (ospf_vertex_add_parent) Fix assert.
407 (ospf_nexthop_calculation) Fix calculation of nexthop for
408 VLink vertices, lookup the vl_data and use its previously
409 recorded nexthop information.
410 (ospf_spf_calculate) Vertices are freed simply by deleting
411 vertex_list nodes and letting ospf_vertex_free as deconstructor
412 work per-node.
413 (ospf_spf_calculate_timer) Trivial optimisation, leave
414 backbone SPF calculation till last to reduce SPF churn on
415 VLink updates.
416 * ospf_vty.c: (ospf_find_vl_data) update call to ospf_vl_lookup
417 (no_ospf_area_vlink_cmd) ditto.
418 (show_ip_ospf_interface_sub) For Vlinks, the peer address is
419 more interesting than the output interface.
420
Paul Jakma478aab92006-04-03 21:25:32 +00004212006-04-03 Paul Jakma <paul.jakma@sun.com>
422
423 * (general) Fix issues with handling of Vlinks and entries
424 in the nbrs route-table which were highlighted by the
425 nsm/nbr_self fixes from bug #234. Many thanks to Juergen
426 Kammer for his help and efforts in testing out debug patches to
427 pinpoint the issue.
428 * ospf_interface.c: (ospf_vl_new) Add nbr_self for Vlink.
429 * ospf_neighbor.c: (ospf_nbr_key) new static function, helper
430 to create key in nbrs table for a given nbr.
431 (ospf_nbr_delete) Use ospf_nbr_key. Add an assert() to
432 document an expected state.
433 (ospf_nbr_add_self) Ditto.
434 (ospf_nbr_lookup_by_addr) Add an assert.
435 * ospf_nsm.c: (nsm_kill_nbr) Can never kill the nbr_self
436 psuedo-neighbour.
437
Paul Jakma075c2012006-03-30 14:34:31 +00004382006-03-27 Paul Jakma <paul.jakma@sun.com>
439
440 * ospf_lsa.c: (ospf_lsa_checksum) Add an explicit cast to avoid
441 the ambiguities of ANSI and C99 C with respect to type
442 conversion. Detailed problem report and test case with
443 example data supplied by Dmitry Ivanov <dimss@telecentrs.lv>.
444
Paul Jakma1a8ee0e2006-03-30 14:20:00 +00004452006-03-25 Paul Jakma <paul.jakma@sun.com>
446
447 * ospf_interface.c: (ospf_if_lookup_recv_if) Ignore loopbacks,
448 we can never ever receive packets on those. Should fix
449 case where CARP is run with address in same subnet as real
450 interface. Problem report and diagnosis thanks to:
451 Landon Fuller <landonf@opendarwin.org>.
452 However, ospf_read() still can't deal deterministically with
453 multiple interfaces in same subnet.
454
Paul Jakmac2b478d2006-03-30 14:16:11 +00004552006-03-23 Steve Lawson <steve.lawson@aheadcomusa.com>
456
457 * ospf_lsa.c: (ospf_lsa_install) Fix incorrect byte-order
458 conversion of OSPF_MAX_SEQUENCE_NUMBER
459
paule8e19462006-01-19 20:16:55 +00004602006-01-19 Paul Jakma <paul.jakma@sun.com>
461
462 * (general) various miscellaneous compiler warning fixes.
463 Remove redundant break statements from switch clauses
464 which return.
465 return from main, not exit, cause it annoys SOS.
466 Remove stray semi-colons which cause empty-statement
467 warnings.
468
paul779adb02006-01-18 15:07:38 +00004692006-01-18 Juergen Kammer <j.kammer@eurodata.de>
470
471 * ospf_lsa.c: (ospf_router_lsa_new) dont take reference to the
472 stream data until it is constructed, data reference is
473 volatile due to the potential resize in link_info_set
474
4752006-01-18 Paul Jakma <paul.jakma@sun.com>
476
477 * ospf_lsa.c: (link_info_set) Resize the stream if required and
478 possible. Return number of links added.
479 (lsa_link_*_set) use return value from previous.
480 * ospf_lsa.h: Add OSPF_ROUTER_LSA_LINK_SIZE define.
481
paulc6371712006-01-17 17:49:53 +00004822006-01-17 Paul Jakma <paul.jakma@sun.com>
483
484 * ospf_packet.c: (ospf_verify_header) print out the types
485 involved if there's a mismatch.
486 * ospf_zebra.c: (ospf_zebra_add) Adjust to new zserv format.
487
paul818e56c2006-01-10 23:27:05 +00004882006-01-10 Len Sorensen <lennartsorensen@ruggedcom.com>
489
490 * (general) Bug #234, see also [quagga-dev 3902].
491 Fix problem with nbr_self not being properly reinitialised
492 when an interface comes up, after having been down.
paul1a643f82006-01-11 01:08:19 +0000493 Some re-arrangement done by Paul Jakma, any bugs introduced
494 on top of Len's suggested changes are his.
paul818e56c2006-01-10 23:27:05 +0000495 * ospf_neighbor.c: (ospf_nbr_add_self) centralise
496 initialisation of nbr_self parameters here.
497 * ospf_interface.c: (ospf_if_new) deleting initialisation of
498 parameters of nbr_self, just rely on call to
499 ospf_nbr_add_self.
500 (ospf_if_cleanup) ditto.
501 * ospfd.c: (ospf_network_run) ditto.
502
paul98429f62006-01-10 22:11:54 +00005032006-01-10 Juris Kalnins <juris@mt.lv>
504
505 * ospf_zebra.c: (ospf_interface_address_delete) fix rare leak of
506 struct connected in an error case.
paul818e56c2006-01-10 23:27:05 +0000507 * ospf_packet.c: (ospf_make_md5_digest) fix odd, if not
508 undefined effect, assignment of an increment expression.
paul98429f62006-01-10 22:11:54 +0000509
paul86752842006-01-10 20:34:46 +00005102006-01-10 Paul Jakma <paul.jakma@sun.com>
511
512 * ospfd.c: (ospf_network_run) checking to see if router-id
513 is set should be on ospf->router_id, not router_id_static.
514 This was causing ospfd to not start if router-id had not
515 been configured statically.
516 (ospf_if_update) ditto.
paulc42c1772006-01-10 20:36:49 +0000517 * ospf_vty.c: (config_write_ospf_distribute) trim down
518 redundant strings.
paul86752842006-01-10 20:34:46 +0000519
paul00c290e2005-11-26 09:21:43 +00005202005-11-26 Paul Jakma <paul.jakma@sun.com>
521
522 * ospf_api.c: (struct opaque_lsa) change from gcc zero-length
523 array to C99 incomplete type array.
paulc9c93d52005-11-26 13:31:11 +0000524 * (general) s/graceful/deferred/ in all files, the former term
525 is confusing wrt OSPF Graceful-Restart.
526 * ospfd.c: (ospf_deferred_shutdown_check) dont return
527 a function which returns void. SOS complains about this.
528 (ospf_finish)
paul00c290e2005-11-26 09:21:43 +0000529
paulb29800a2005-11-20 14:50:45 +00005302005-11-20 Paul Jakma <paul.jakma@sun.com>
531
532 * ospfd.h: remove the OSPF_ROUTER_ID_UPDATE_DELAY define
533 (struct ospf) remove the router_id timer thread.
534 remove export of ospf_router_id_update_timer.
535 * ospfd.c: (ospf_router_id_update) call ospf_if_update to
536 poke interfaces into action after ID has been configured.
537 (ospf_router_id_update_timer) removed.
538 (ospf_finish_final) t_router_id_update timer is gone.
539 (ospf_network_run) router-id update timer gone.
540 call ospf_router_id_update directly if ID not configured.
541 In the per-iface loop, don't ospf_if_up interfaces if
542 ID is still not configured. The update function will call
543 ospf_if_update anyway.
544 (ospf_if_update) ID update timer is gone. Just return if no
545 ID is set.
546 * ospf_vty.c: (ospf_router_id) call ospf_router_id_update, no
547 timer needed.
548 * ospf_zebra.c: (ospf_router_id_update_zebra) call
549 ospf_router_id_update directly, not via timer.
paulc24d6022005-11-20 14:54:12 +0000550 * ospf_abr.c: (ospf_abr_announce_network_to_area) check
551 returned LSA of ospf_summary_lsa_refresh and print warning if
552 it failed.
553 (ospf_abr_announce_network_to_area) similar
554 (ospf_abr_announce_rtr_to_area) similar
555 * ospf_lsa.c: (ospf_router_lsa_new) check LSA returned is valid.
556 (ospf_router_lsa_originate) similar
557 (ospf_router_lsa_refresh, ospf_network_lsa_new) similar
558 (ospf_summary_lsa_new) Check ID is valid.
559 (ospf_summary_lsa_originate) ditto, and check returned LSA from
560 previous function is !NULL.
561 (ospf_summary_lsa_refresh) check ospf_summary_lsa_new return
562 is !NULL.
563 (ospf_summary_asbr_lsa_new) ID valid check.
564 (ospf_summary_asbr_lsa_originate) similar.
paulb29800a2005-11-20 14:50:45 +0000565
ajs70cd3472005-11-16 19:33:22 +00005662005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
567
ajs649654a2005-11-16 20:17:52 +0000568 * ospf_dump.h: Define OSPF_TIME_DUMP_SIZE as appropriate buffer size
569 for use with ospf_timer_dump and ospf_timeval_dump.
570 * ospf_vty.c: Change all buffer sizes used with ospf_timer_dump and
571 ospf_timeval_dump to have size OSPF_TIME_DUMP_SIZE.
572 (show_ip_ospf_interface_sub) Fix possible buffer overflow in
573 call to ospf_timer_dump.
574
5752005-11-16 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
576
ajs70cd3472005-11-16 19:33:22 +0000577 * ospf_ism.h: (OSPF_ISM_TIMER_OFF) Improve macro syntax by enclosing
578 in 'do {...} while(0)'.
579
paul31a59762005-11-14 11:11:11 +00005802005-11-14 Paul Jakma <paul.jakma@sun.com>
581
582 * ospfd.c: (ospf_new) stub-shutdown should just default to
583 unconfigured, too strange otherwise.
584 (ospf_finish_final) t_opaque_lsa_self TIMER_OFF should be
585 preprocessor conditional on HAVE_OPAQUE_LSA.
586 * ospfd.h: (struct ospf) remove the SHUTDOWN_DEFAULT define.
587 no longer used, plus it wasn't in range that the command
588 accepted.
589 * ospf_zebra.h: Depends on vty.h, include it.
590
paul58e1bef2005-11-11 12:10:03 +00005912005-11-11 Paul Jakma <paul.jakma@sun.com>
592
593 * ospf_spf.c: (ospf_canonical_nexthops_free) Free only
594 the nexthops pointing to the root vertex. We may visit a
595 vertex twice or the vertex may have some inherited nexthops,
596 if we free other nexthops we could crash.
597
paulc8c15212005-11-04 12:31:39 +00005982005-11-04 Paul Jakma <paul.jakma@sun.com>
599
600 * ospf_{dump,spf,vty}.c: Oops, use the internal tv_sub
601 function rather than unportable timersub.
602
paul484315f2005-11-03 09:08:29 +00006032005-11-03 Paul Jakma <paul.jakma@sun.com>
604
605 * ospf_apiserver.c: (apiserver_sync_callback) stray semi-colon
606 * ospf_packet.c: include checksum.h, remove the in_cksum extern
607 * prototypes.
608 * ospf_te.h: Add braces, quell warning.
paul6d452762005-11-03 11:15:44 +0000609 * ospf_packet.c: Change level of some warnings to
610 informational.
paulc8c15212005-11-04 12:31:39 +0000611
paul88d6cf32005-10-29 12:50:09 +00006122005-10-29 Paul Jakma <paul.jakma@sun.com>
613
614 * (general) RFC3137 stub-router support
615 * ospfd.h: Add OSPF_OUTPUT_COST_INFINITE define.
616 (struct ospf_master) Add a OSPF_MASTER_SHUTDOWN flag for
617 options, to allow shutdown to distinguish between complete
618 shutdown and shutdown of a subset of ospf instances.
619 (struct ospf)
620 Add stub_router_{startup,shutdown_}time, configuration of startup
621 and shutdown time for stub-router.
622 Add t_graceful_shutdown struct thread, timer for graceful
623 shutdown, if needed.
624 (struct ospf_area) Add stub_router_state - run time state of
625 stub-router for an area. Add flags for ADMIN, IS and WAS
626 states.
627 Add t_stub_router, timer thread to resend router-lsa for an
628 area.
629 * ospf_lsa.c: (ospf_link_cost) new simple function to spit out
630 either the given lnks cost or infinite cost if stub-router is
631 in effect.
632 (lsa_link_{ptop,broadcast,virtuallink,ptomp}_set) use
633 previous function for transit-links.
634 (ospf_stub_router_timer) timer thread for end of startup stub
635 router. Change state as required for the area and setup
636 re-origination of router-lsa.
637 (ospf_stub_router_check) Check/do whether stub-router should be
638 enabled, and whether it requires timer to be setup.
639 (ospf_router_lsa_new) call previous function at top.
640 (ospf_router_lsa_originate) no external callers, made static.
641 * ospf_lsa.h: (ospf_router_lsa_originate) removed.
642 * ospf_main.c: (sigint) make static.
643 remove call to exit, as ospf_terminate now deals with
644 exiting.
645 * ospf_route.c: (ospf_terminate) removed, now in ospfd.c.
646 * ospf_vty.c: (show_ip_ospf_area) print out state of
647 stub-router, if active.
648 (show_ip_ospf) print out configuration of stub-router
649 support, and details of graceful-shutdown if the timer is
650 active.
651 ((no)?ospf_max_metric_router_lsa_{admin,startup,shutdown}) new
652 commands to (de-)?configure stub-router support.
653 (config_write_stub_router) write out config of stub-router.
654 (ospf_config_write) call previous.
655 (ospf_vty_init) install the new stub-router commands.
656 * ospfd.c: various functions made static.
657 (ospf_new) Set defaults for stub-router. Graceful shutdown
658 is made to default on, just to be adventerous.
659 (ospf_graceful_shutdown_finish) new function, final part of
660 shutdown.
661 (ospf_graceful_shutdown_timer) timer thread wrapper for
662 graceful-shutdown.
663 (ospf_graceful_shutdown_check) check whether to setup timer
664 for shutdown or proceed directly to final shutdown.
665 (ospf_terminate) moved here from ospf_route.c, call
666 ospf_finish for each instance.
667 (ospf_finish) renamed to ospf_finish_final and made static.
668 (ospf_finish) new function, exported wrapper around
669 ospf_graceful_shutdown_check.
670 (ospf_finish_final) complete shutdown of an instance.
671 Add missing TIMER_OFF's of two timer threads.
672 (ospf_area_free) opaque self lsa timer should be turned off.
673
paulb8ad39d2005-10-23 15:23:05 +00006742005-10-23 Paul Jakma <paul.jakma@sun.com>
675
paule029d442005-10-23 15:26:24 +0000676 * ospf_apiserver.c: (ospf_apiserver_term) This function should
677 not have side-effects (eg segv) if no apiserver instances are
678 active, ie be robust.
paulb8ad39d2005-10-23 15:23:05 +0000679 * ospf_vty.c: (show_ip_ospf) fix display of SPF timer if it
680 has not yet been run.
681
paulf9ad9372005-10-21 00:45:17 +00006822005-10-21 Paul Jakma <paul.jakma@sun.com>
683
paulea4ffc92005-10-21 20:04:41 +0000684 * ospf_dump.c: (ospf_timeval_dump) fix ms adjustment, thanks to
685 Andrew Schorr.
686 * ospf_vty.c: (ospf_config_write) fix write out of spf timers
687 configuration.
688
6892005-10-21 Paul Jakma <paul.jakma@sun.com>
690
pauld24f6e22005-10-21 09:23:12 +0000691 * (general) SPF millisecond resolution timer with adaptive,
692 linear back-off holdtime. Prettification of ospf_timer_dump.
693 * ospf_dump.c: (ospf_timeval_dump) new function. The guts of
694 ospf_timer_dump, but made to be more dynamic in printing out
695 the relative timeval, sliding the precision printed out
696 according to the value.
697 (ospf_timer_dump) guts moved to ospf_timeval_dump.
698 * ospf_dump.h: export ospf_timeval_dump.
699 * ospf_flood.c: (ospf_flood) remove gettimeofday, use
700 the libzebra exported recent_time instead, as it's not
701 terribly critical to have time exactly right - the dropped
702 LSA will be retransmited to us if we don't ACK it.
703 * ospf_packet.c: (ospf_ls_upd_timer) Ditto, but here we're
704 not transmitting, just putting LSA back on update transmit list.
705 * ospfd.h: delay and holdtimes should be unsigned.
706 Add spf_max_holdtime and spf_hold_multiplier.
707 Update default defines for delay and hold time to be in msec.
708 (struct ospf) change the SPF timestamp to a struct timeval.
709 Remove ospf_timers_spf_(un)?set.
710 * ospfd.c: (ospf_timers_spf_{set,unset}) removed.
711 (ospf_new) initialise spf_max_holdtime and spf_hold_multiplier
712 * ospf_spf.c: (ospf_spf_calculate) SPF timestamp is a timeval
713 now, update with gettimeofday.
714 (ospf_spf_calculate_schedule) Change SPF timers to millisecond
715 resolution.
716 Make the holdtime be adaptive, with a linear increase in
717 holdtime ever consecutive SPF run which occurs within holdtime
718 of previous SPF, bounded by spf_max_holdtime.
719 * ospf_vty.c: Update spf timers commands.
720 (ospf_timers_spf_set) trivial helper.
721 (ospf_timers_throttle_spf_cmd) new command to set SPF delay,
722 initial hold and max hold times with millisecond resolution.
723 (ospf_timers_spf_cmd) Deprecated. Accept the old values,
724 convert to msec, truncate to new limits.
725 (no_ospf_timers_throttle_spf_cmd) set timers to defaults.
726 (no_ospf_timers_spf_cmd) deprecated form, same as previous.
727 (show_ip_ospf_cmd) Display SPF parameters and times.
728 (show_ip_ospf_neighbour_header) Centralise the 'sh ip os ne'
729 header.
730 (show_ip_ospf_neighbor_sub) Fix the field widths. Get rid of
731 the multiple spaces which were making the lines even longer.
732 (show_ip_ospf_neighbor_cmd) Use show_ip_ospf_neighbour_header
733 (show_ip_ospf_neighbor_all_cmd) ditto and fix the field
734 widths for NBMA neighbours.
735 (show_ip_ospf_neighbor_int) Use header function.
736 (show_ip_ospf_nbr_nbma_detail_sub) use sizeof for timebuf,
737 local array - safer.
738 (show_ip_ospf_neighbor_detail_sub) ditto
739 (ospf_vty_init) install the new SPF throttle timer commands.
740
7412005-10-21 Paul Jakma <paul.jakma@sun.com>
742
paulf9ad9372005-10-21 00:45:17 +0000743 * (general) OSPF fast, sub-second hello and 1s dead-interval
744 support.
745 * ospf_dump.c: (ospf_timer_dump) Print out milliseconds too.
746 Callers typically specify a length of 9, so most see
747 millisecs unless they specify the additional length.
748 * ospf_interface.h: (struct ospf_interface) new interface param,
749 fast_hello.
750 * ospf_interface.c: (ospf_if_table_lookup) add brackets,
751 gcc warning fix.
752 (ospf_new_if_params) Initialise fast_hello param.
753 (ospf_free_if_params) Check whether fast_hello is configured.
754 (ospf_if_new_hook) set fast_hello to default.
755 * ospf_ism.h: Wrap OSPF_ISM_TIMER_ON inside do {} while (0) to
756 prevent funny side-effects from its if statement when this
757 macro is used conditionally by other macros.
758 (OSPF_ISM_TIMER_MSEC_ON) new macro, set in milliseconds.
759 (OSPF_HELLO_TIMER_ON) new macro to set hello timer according
760 to whether fast_hello is set.
761 * ospf_ism.c: Update all setting of the hello timer to use
762 either OSPF_ISM_TIMER_MSEC_ON or OSPF_HELLO_TIMER_ON. The
763 former is used when hello is to be sent immediately.
764 * ospf_nsm.c: ditto
765 * ospf_packet.c: (ospf_hello) hello-interval is not checked
766 for mismatch if fast_hello is set.
767 (ospf_read) Annoying nit, fix "no ospf_interface" to be debug
768 rather than a warning, as it can be perfectly normal to
769 receive packets when logical subnets are used.
770 (ospf_make_hello) Set hello-interval to 0 if fast-hellos are
771 configured.
772 * ospf_vty.c: (ospf_auto_cost_reference_bandwidth) annoying
773 nit, don't vty_out if this command is given, it gets tired
774 quick.
775 (show_ip_ospf_interface_sub) Print the hello-interval
776 according to whether fast-hello is set or not.
777 Print the extra 5 millisec characters from (ospf_timer_dump)
778 if fast-hello is configured.
779 (ospf_vty_dead_interval_set) new function, common to all
780 forms of dead-interval command, to set dead-interval and
781 fast-hello correctly. If a dead-interval is given, unset
782 fast-hello, else if a hello-multiplier is set, set
783 dead-interval to 1 and fast-hello to given multiplier.
784 (ip_ospf_dead_interval_addr_cmd) use
785 ospf_vty_dead_interval_set().
786 (ip_ospf_dead_interval_minimal_addr_cmd) ditto.
787 (no_ip_ospf_dead_interval) Unset fast-hello.
788 (no_ip_ospf_hello_interval) Bug-fix, unset of hello-interval
789 should set it to OSPF_HELLO_INTERVAL_DEFAULT, not
790 OSPF_ROUTER_DEAD_INTERVAL_DEFAULT.
791 (config_write_interface) Write out fast-hello.
792 (ospf_config_write) Write a comment about
793 "auto-cost reference-bandwidth" having to be equal on all
794 routers. Hopefully just as noticeable as old practice of
795 writing to vty, but less annoying.
796 (ospf_vty_if_init) install the two new dead-interval
797 commands.
798 * ospfd.h: Add defines for OSPF_ROUTER_DEAD_INTERVAL_MINIMAL
799 and OSPF_FAST_HELLO_DEFAULT.
800
pauleb3da6d2005-10-18 04:20:33 +00008012005-10-18 Paul Jakma <paul.jakma@sun.com>
802
803 * (general) SPF memory management cleanup and fix for rare
804 double-free bug.
805 * ospf_spf.h: (struct vertex_parent) New struct to hold parent
806 specific data, eg the backlink and the parent vertex pointer,
807 and point to the appropriate general struct vertex_nexthop.
808 (struct vertex_nexthop) remove parent vertex pointer, so
809 this struct can be shared across vertices.
810 (struct vertex) rename list child to list children. Remove
811 list of nexthops, replace with list of vertex_parents.
812 * ospf_spf.c: (update_stat) trivial, remove cast from void *.
813 (vertex_nexthop_new) remove init of parent - field is gone
814 from struct vertex_nexthop.
815 (ospf_canonical_nexthops_free) Remove the canonical
816 vertex_nexthop memory objects. These are the vertex_nexthops
817 attached to the first level of router vertices from the root.
818 (vertex_parent_new) new function, create a vertex_parent.
819 (vertex_parent_free) ditto, but free it.
820 (ospf_vertex_new) Update to match changes to struct vertex.
821 (ospf_vertex_free) Recursively free a struct vertex and its
822 children. The parent list is used as a reference count.
823 vertex_nexthops must be free seperately, if required.
824 (ospf_vertex_dump) update to match struct vertex changes.
825 Print out backlink of parents too.
826 (ospf_vertex_add_parent) ditto.
827 (ospf_lsa_has_link) update comment.
828 (ospf_nexthop_add_unique) removed, not needed anymore.
829 (ospf_nexthop_merge) ditto.
830 (ospf_spf_consider_nexthop) renamed to ospf_spf_add_parent.
831 Simplified to just create vertex_parent and add it.
832 (ospf_spf_flush_parents) new function, flush out the parent
833 list.
834 (ospf_nexthop_calculation) Take the relevant route_lsa_link
835 as an argument, which simplifies things and removes the need
836 for the hack in ospf_nexthop_add_unique - ospf_spf_next
837 already knew exactly which link the cost calculated was for.
838 Update to match struct vertex changes too.
839 (ospf_spf_next) Don't create a vertex for W unnecessarily, if
840 it's there's a vertex already created for W, use it, and
841 hence there's no need to free it either.
842 Update some manipulation/comparisons of distance to match.
843 Flush the parent list if a lower cost path is found.
844 (ospf_spf_route_free) unused, removed.
845 (ospf_spf_dump) match the struct vertex changes, and dump the
846 ifname if possible.
847 (ospf_spf_calculate) At end of SPF, free the canonical nexthops
848 and call ospf_vertex_free on the root vertex to free the
849 entire tree.
850 * ospf_interface.c: (ospf_vl_set_params) match struct vertex
851 changes.
852 * ospf_route.c: (ospf_intra_route_add) ditto
853 (ospf_route_copy_nexthops_from_vertex) ditto
854
paul36238142005-10-11 04:12:54 +00008552005-10-11 Paul Jakma <paul.jakma@sun.com>
856
857 * ospf_api.c: sign warnings.
858 * ospf_apiserver.c: sign warning and convert all the struct
859 in_addr initialisations so as not to make assumptions about
860 how this struct is organised, initialise the s_addr member
861 explicitely.
862 * ospf_packet.c: Add const qualifier to auth_key.
863
vincent77df1f72005-10-06 07:46:22 +00008642005-10-06 Alain Ritoux <alain.ritoux@6wind.com>
865
866 * ospf_snmp.c: Avoid mixing interface and ospf_interface objects
867 which now allows snmpwalk to work with ospfIfTable and
868 also with ospfIfMetricTable
869
ajsf52d13c2005-10-01 17:38:06 +00008702005-10-01 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
871
872 * ospf_dump.c: Remove local hard-coded table ospf_redistributed_proto.
873 (ospf_redist_string) New function implemented using new library
874 function zebra_route_string(). Note that there are a few differences
875 in the output that will result: the new function returns strings
876 that are lower-case, whereas the old table was mixed case. Also,
877 the old table mapped ZEBRA_ROUTE_OSPF6 to "OSPFv3", whereas the
878 new function returns "ospf6".
879 * ospfd.h: Remove extern struct message ospf_redistributed_proto[],
880 and add extern const char *ospf_redist_string(u_int route_type)
881 instead.
882 * ospf_asbr.c: (ospf_external_info_add) In two messages, use
883 ospf_redist_string instead of LOOKUP(ospf_redistributed_proto).
884 * ospf_vty.c: Remove local hard-coded table distribute_str.
885 (config_write_ospf_redistribute,config_write_ospf_distribute): Use
886 new library function zebra_route_string() instead of distribute_str[].
887 * ospf_zebra.c: (ospf_redistribute_set,ospf_redistribute_unset,
888 ospf_redistribute_default_set,ospf_redistribute_check)
889 In debug messages, use ospf_redist_string() instead of
890 LOOKUP(ospf_redistributed_proto).
891
jardin6638c1a2005-10-01 00:08:54 +00008922005-09-30 Vincent Jardin <vincent.jardin@6wind.com>
893
894 * ospf_dump.c, ospf_ia.c, ospf_spf.c, ospf_ase.c:
895 remove unused DEBUG
896
vincentba682532005-09-29 13:52:57 +00008972005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
898
vincent5e4914c2005-09-29 16:34:30 +0000899 * ospf_ism.c: generate SNMP traps on Interface state change
900 * ospf_nsm.c: generate SNMP traps on Neighbour state change
901 * ospf_snmp.[ch]: support for SNMP traps for interface and neighbours.
902
9032005-09-29 Alain Ritoux <alain.ritoux@6wind.com>
904
vincentba682532005-09-29 13:52:57 +0000905 * ospf_vty.c: forece default route LSA to be re_issued whenever
906 cost is changed ( [no] ip ospf area XXX default-cost YYY)
907 Support ignore-mtu option
908 * ospfd.h: define OSPF_MTU_IGNORE_DEFAULT
909 * ospf_packet.c: support ignore-mtu option
910 * ospf_interface.h: field added for skipping MTU check
911 * ospf_interface.c: fix memory leak in ospf_crypt_key_delete()
912 Set mtu_ignore field to default value
913 * ospf_abr.[ch]: export ospf_abr_announce_network_to_area()
914 * ospf_ism.h: add MACRO to convert internal ISM status into SNMP
915 correct values
916 * ospf_snmp.c: add sanity check on LSA type in lsdb_lookup_next()
917 convert OSPFIFSTATE internal status into SNMP values
918
vincentc1a03d42005-09-28 15:47:44 +00009192005-09-28 Alain Ritoux <alain.ritoux@6wind.com>
920
921 * ospf_packet.c: use new md5 API
922
ajs5339cfd2005-09-19 13:28:05 +00009232005-09-19 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
924
925 * ospf_lsa.h: (ospf_external_lsa_flush) Comment out the 5th argument
926 (nexthop) since it is not used in the function (except inside
927 some commented-out code).
928 * ospf_lsa.c: (ospf_external_lsa_flush,ospf_external_lsa_refresh)
929 Comment out the 5th argument to ospf_external_lsa_flush.
930 * ospf_asbr.c: (ospf_redistribute_withdraw) Comment out 5th arg
931 to ospf_external_lsa_flush.
932 * ospf_vty.c: (no_ospf_default_information_originate) Eliminate 5th
933 uninitialized nexthop arg to ospf_external_lsa_flush.
934 * ospf_zebra.c: (ospf_zebra_read_ipv4) Comment out 5th arg
935 to ospf_external_lsa_flush.
936 * ospfd.c: (ospf_network_set) Comment out 5th arg
937 to ospf_external_lsa_flush.
938
ajse6a0bf92005-09-17 18:53:38 +00009392005-09-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
940
941 * ospf_opaque.c:
942 (ospf_opaque_lsa_refresh_schedule,ospf_opaque_lsa_flush_schedule)
943 No need to call ospf_lookup(), just use lsa0->area->ospf instead.
944
hassobb5b7552005-08-21 20:01:15 +00009452005-08-21 Hasso Tepper <hasso at quagga.net>
946
947 * ospf_vty.c: Make "show ip ospf neighbor xxx" commands work.
948 Interface should be specified by name now.
949
hasso54bedb52005-08-17 13:31:47 +00009502005-08-17 Hasso Tepper <hasso at quagga.net>
951
952 * ospf_vty.c: Check carefully if interface exists before trying to
953 print info about it.
954
hasso01018ce2005-08-05 07:40:15 +00009552005-08-05 Hasso Tepper <hasso at quagga.net>
956
957 * ospf_zebra.c: Don't assert/stop before type == ZEBRA_ROUTE_MAX if
958 dealing with routemaps. There is ospf->route_map[ZEBRA_ROUTE_MAX]
959 for default-information.
960
paulc8987752005-07-26 06:07:22 +00009612005-07-26 Paul Jakma <paul.jakma@sun.com>
962
963 * ospf_abr.c: (ospf_abr_announce_network_to_area) SET_FLAG
964 should be on lsa not old, which may be freed for one thing,
965 obviously.
966
pauld57834f2005-07-12 20:04:22 +00009672005-07-12 Paul Jakma <paul.jakma@sun.com>
968
969 * ospfd.h: add OSPF_ABR_DEFAULT for convenience, make
970 OSPF_ABR_CISCO be the default ABR type.
971 * ospfd.c: (ospf_new) initialise abr_type to OSPF_ABR_DEFAULT
972 * ospf_vty.c: (no_ospf_abr_type_cmd) add standard as a negatable
973 abr_type. default abr_type should be OSPF_ABR_DEFAULT.
974 (ospf_config_write) test whether default abr_type against
975 OSPF_ABR_DEFAULT, rather than any specific ABR_TYPE.
976
hasso8469bd72005-06-20 20:50:10 +00009772005-06-20 Hasso Tepper <hasso at quagga.net>
hassof4833e92005-06-20 20:42:26 +0000978
979 * ospf_nsm.c: Make database exchange for NSSA database work.
980
paul7461d452005-06-13 13:57:16 +00009812005-06-13 Paul Jakma <paul.jakma@sun.com>
982
983 * ospf_spf.c: Try get more information on a SEGV under
984 ospf_spf_vertex_add_parent.
985 (ospf_vertex_free) NULL out the child and nexthop lists
986 (ospf_vertex_add_parent) nexthop and child can not be NULL
987 vertex_nexthop's parent->child list can not be NULL
988 (ospf_spf_next) w and cw are per-loop iteration variables, move
989 declarations into loop body.
990
hasso1ddd7292005-06-07 19:54:04 +00009912005-06-07 Hasso Tepper <hasso at quagga.net>
992
993 * ospf_apiserver.c: Fix obvious error in notifying clients about ISM
994 changes - oi->ifp->status doesn't give to us info about ISM,
995 oi->state does.
996
paul7e440862005-06-01 11:20:51 +00009972005-06-01 Akihiro Mizutani <mizutani@net-chef.net>
998
999 * ospf_ism.c (ospf_elect_bdr/ospf_elect_dr): Fix DR election bug.
1000
paul500e4182005-05-26 17:11:13 +000010012005-05-26 Paul Jakma <paul.jakma@sun.com>
1002
1003 * ospf_abr.c: (ospf_abr_update_aggregate) Fix comment, cost bug itself
1004 had been fixed long ago by Sowmini.
1005
paula3387a42005-05-18 23:29:57 +000010062005-05-19 Paul Jakma <paul.jakma@sun.com>
1007
1008 * ospf_interface.c: (ospf_if_table_lookup) Fix a serious bug
1009 a less serious one.
1010 1: this function is supposed to lookup
1011 entries in the oifs ospf_interface route_table and return either
1012 an existing oi or NULL to indicate not found, its caller depends
1013 on this, yet this function uses route_node_get which /always/
1014 returns a route_node - one is created if none exists. Use
1015 route_node_lookup instead. This should fix root cause of the
1016 reports of the (ospf_add_to_if) assert being hit.
1017 2: oi's are inserted into this table with prefixlength set to
1018 /32 (indeed, it should be a hash table, not a route_table),
1019 however prefixlength to lookup was not changed, if no valid entry
1020 can be inserted other than /32, then nothng but /32 should be
1021 looked up. This possibly only worked by fluke..
1022 Fix confirmed by 2 reporters (one list, one IRC), definitely a
1023 backport candidate once it has been incubated in HEAD for a while.
1024 Thanks to Patrick Friedel and Ivan Warren for testing.
1025
paul69310a62005-05-11 18:09:59 +000010262005-05-11 Paul Jakma <paul.jakma@sun.com>
1027
1028 * (general) Fix memory leaks in opaque AS-scope LSAs, reported and
1029 with much debugging done by by scott collins <scollins@agile.tv>.
1030 * ospf_lsa.c: (ospf_discard_from_db) dont call
1031 ospf_ase_unregister_external_lsa for opaque-lsa's, opaques are
1032 never registered with ase in the first place.
1033 * ospf_packet.c: (general) Disabuse opaque related code of its
1034 tendency to try gather up things into temporary lists.
1035 (ospf_ls_upd) remove the temporary lists opaque uses, call
1036 opaque functions inline, just like all other types.
1037 (ospf_ls_ack) ditto.
1038 (ospf_recv_packet) fixup sign warning.
1039 * ospf_opaque.c: (general) fix the unneeded use of lists, and
1040 untwist some of the logic.
1041 (ospf_opaque_self_originated_lsa_received) take a single LSA
1042 as argument, not a list of them. Remove the list loop. Logic
1043 otherwise unchanged.
1044 (ospf_opaque_ls_ack_received) Mostly ditto. But untwist the logic,
1045 move the actions up into the switch block, remove the goto's and
1046 sanitise the logic near the end a bit.
1047 * ospf_opaque.h: Adjust definitions of aforementioned functions
1048 in ospf_opaque.c to match.
1049
paul42c98192005-05-07 02:22:51 +000010502005-05-07 Yar Tikhiy <yar@comp.chem.msu.su>
1051
1052 * ospf_network.c: Log ifindex on multicast membership leave/join
1053 events.
1054
paul4dadc292005-05-06 21:37:42 +000010552005-05-06 Paul Jakma <paul.jakma@sun.com>
1056
1057 * (general) extern and static qualifiers added.
1058 unspecified arguments in definitions fixed, typically they should
1059 be 'void'.
1060 function casts added for callbacks.
1061 Guards added to headers which lacked them.
1062 Proper headers included rather than relying on incomplete
1063 definitions.
1064 gcc noreturn function attribute where appropriate.
1065 * ospf_opaque.c: remove the private definition of ospf_lsa's
1066 ospf_lsa_refresh_delay.
1067 * ospf_lsa.h: export ospf_lsa_refresh_delay
1068 * ospf_packet.c: (ospf_make_md5_digest) make *auth_key const,
1069 correct thing to do - removes need for the casts later.
1070 * ospf_vty.c: Use vty.h's VTY_GET_INTEGER rather than ospf_vty's
1071 home-brewed versions, shuts up several warnings.
1072 * ospf_vty.h: remove VTY_GET_UINT32. VTY_GET_IPV4_ADDRESS and
1073 VTY_GET_IPV4_PREFIX moved to lib/vty.h.
1074 * ospf_zebra.c: (ospf_distribute_list_update_timer) hacky
1075 overloading of the THREAD_ARG pointer should at least use
1076 uintptr_t.
1077
paul9e67dc22005-04-15 12:10:17 +000010782005-04-15 Zhipeng Gong <zpgong@cdc.3upsystems.com>
1079
1080 * ospf_abr.c: (ospf_abr_announce_network_to_area) dont forget
1081 to approve LSAs for the case where metric has changed, lsa gets
1082 flushed otherwise. (backport candidate).
1083
ajs634f9ea2005-04-11 15:51:40 +000010842005-04-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1085
1086 * ospf_zebra.c (ospf_zebra_add): Call zclient_send_message instead
1087 of writen.
1088
ajsd2fc8892005-04-02 18:38:43 +000010892005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1090
ajse4319de2005-04-02 23:23:55 +00001091 * ospf_interface.h: (ospf_if_lookup_by_name) Remove declaration of a
1092 function that does not exist.
1093
10942005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1095
ajs21fefa92005-04-02 23:16:41 +00001096 * ospf_zebra.c: (zebra_interface_if_lookup) Must use
1097 if_lookup_by_name_len.
1098
10992005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1100
ajsa3491982005-04-02 22:50:38 +00001101 * ospf_interface.c: (ospf_vl_new) Use strnlen to fix call to if_create.
1102
11032005-04-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1104
ajsd2fc8892005-04-02 18:38:43 +00001105 * ospf_vty.c: (show_ip_ospf_interface_sub) Show ifindex and interface
1106 flags to help with debugging.
1107 * ospf_zebra.c: (ospf_interface_delete) After deleting, set ifp->ifindex
1108 to IFINDEX_INTERNAL.
1109 (zebra_interface_if_lookup) Make function static. Tighten up code.
1110
ajsaca72fd2005-03-31 15:18:21 +000011112005-03-31 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1112
1113 * ospf_dump.c: (show_debugging_ospf) Show if ospf event debugging
1114 is turned on.
1115
ajsfd651fa2005-03-29 16:08:16 +000011162005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1117
ajsa608bbf2005-03-29 17:03:49 +00001118 * ospf_zebra.c: (ospf_interface_state_up) If the MTU of an operative
1119 interface changes, print a debug message and call ospf_if_reset()
1120 to simulate down/up on the interface.
1121 * ospf_interface.h: Declare new function ospf_if_reset().
1122 * ospf_interface.c: (ospf_if_reset) New function to call ospf_if_down
1123 and ospf_if_up for all ospf interfaces attached to an interface.
1124
11252005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1126
ajs5dcbdf82005-03-29 16:13:49 +00001127 * ospf_packet.c: (ospf_write_frags) Enhance error message to
1128 show MTU. Also make function static.
1129 (ospf_write) Enhance error message to show interface name and MTU.
1130 Also make function static.
1131
11322005-03-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1133
1134 * ospf_vty.c: (show_ip_ospf_interface_sub) Display interface MTU and
1135 bandwidth; this is useful for debugging problems. Also, the function
1136 should be static.
ajsfd651fa2005-03-29 16:08:16 +00001137
hasso1b639042005-03-27 13:32:25 +000011382005-03-27 Hasso Tepper <hasso at quagga.net>
1139
1140 * ospf_snmp.c: Don't crash in snmp query if ospf instance doesn't
1141 exist at all.
1142
hasso343f5cc2005-03-25 19:48:40 +000011432005-03-25 Hasso Tepper <hasso at quagga.net>
1144
1145 * ospfd.h: Include log.h, fixes compile with gcc-4.0.
1146
ajs9dbc7972005-03-13 19:27:22 +000011472005-03-13 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1148
1149 * ospf_lsa.c: (ospf_lsa_refresh_walker) If the system clock jumps
1150 backward, then current time may be less than
1151 ospf->lsa_refresher_started. This was causing invalid values
1152 for ospf->lsa_refresh_queue.index resulting in infinite loops.
1153 Problem fixed by casting the expression to unsigned before taking
1154 the modulus.
1155
ajs5c333492005-02-23 15:43:01 +000011562005-02-23 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1157
1158 * ospfd.h: Add new field struct stream *ibuf to struct ospf.
1159 * ospfd.c: (ospf_new) Check return code from ospf_sock_init.
1160 Allocate ibuf using stream_new(OSPF_MAX_PACKET_SIZE+1).
1161 (ospf_finish) Call stream_free(ospf->ibuf.
1162 * ospf_packet.c: (ospf_read) Call stream_reset(ospf->ibuf) and then
1163 pass it to ospf_recv_packet for use in receiving the packet
1164 (instead of allocating a new stream for each packet received).
1165 Eliminate all calls to stream_free(ibuf).
1166 (ospf_recv_packet) The struct stream *ibuf is now passed in as
1167 an argument. No need to use recvfrom to peek at the packet
1168 header (to see how big it is), just use ospf->ibuf which is
1169 always large enough (this eliminates a system call to recvfrom).
1170 Therefore, no need to allocate a stream just for this packet,
1171 and no need to free it when done.
1172
hasso462f20d2005-02-23 11:29:02 +000011732005-02-23 Vincenzo Eramo <eramo at infocom.ing.uniroma1.it>
1174
1175 * ospf_lsa.h: New flag to the LSA structure for the SPF calculation.
1176 * ospf_lsdb.h: Export ospf_lsdb_clean_stat() function.
1177 * ospf_spf.h: Add link to the LSA stat structure into vertex.
1178 * ospf_spf.c: New functions cmp() and update_stat() to manage
1179 candidates. Remove ospf_spf_has_vertex(), ospf_vertex_lookup(),
1180 ospf_install_candidate() and ospf_spf_register() functions not needed
1181 any more. Update ospf_vertex_new(), ospf_spf_next() and
1182 ospf_spf_calculate() functions to use pqueue instead of linked list.
1183
hassoe40dcce2005-02-21 14:58:42 +000011842005-02-21 Hasso Tepper <hasso at quagga.net>
1185
1186 * ospf_ase.c: Don't show messages related to the ase calculations if
1187 we are not debugging.
1188
hasso306541b2005-02-19 17:58:40 +000011892005-02-19 Hasso Tepper <hasso at quagga.net>
1190
1191 * ospf_api.h: char isn't always signed, but it has to be it here.
1192
paulfa81b712005-02-19 01:19:20 +000011932005-02-19 Paul Jakma <paul.jakma@sun.com>
1194
1195 * ospf_packet.c: (ospf_stream_copy) remove
1196 (ospf_packet_dup) use stream_copy instead of ospf_stream_copy
1197
ajs038163f2005-02-17 19:55:59 +000011982005-02-17 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1199
1200 * ospf_packet.c: (ospf_recv_packet) If there is somehow a runt
1201 packet in the queue, it must be discarded. Improve warning messages.
1202 Fix scope to static.
1203 (ospf_read) Fix bug: should reset the read thread in all cases
1204 to make sure we continue to get incoming messages.
1205
paul658b03a2005-02-15 10:10:55 +000012062005-02-15 Paul Jakma <paul.jakma@sun.com>
1207
1208 * ospf_packet.c: (ospf_recv_packet) Fix silly error wrt allocating
1209 ibuf. Thanks Andrew.
1210
paulbfdc44a2005-02-14 23:48:42 +000012112005-02-14 Paul Jakma <paul.jakma@sun.com>
1212
1213 * ospf_packet.c: (ospf_recv_packet) use stream_recvmsg.
1214
hasso082253f2005-02-11 08:31:54 +000012152005-02-11 Hasso Tepper <hasso at quagga.net>
1216
1217 * ospf_lsdb.c: Fix sum of checksums calculation.
1218
ajs083ee9d2005-02-09 15:35:50 +000012192005-02-09 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1220
1221 * ospf_packet.c: (ospf_write) If sendmsg fails, give more info in the
1222 error message.
1223
ajsba6454e2005-02-08 15:37:30 +000012242005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1225
ajs8cfde372005-02-08 15:59:16 +00001226 * ospf_interface.h: Reduce structure padding by putting new u_char
1227 field multicast_memberships in a better spot (grouped with
1228 other u_char fields type and state).
1229
12302005-02-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1231
ajsba6454e2005-02-08 15:37:30 +00001232 * ospf_interface.h: Improve passive_interface comment. Add new
1233 multicast_memberships bitmask to struct ospf_interface to track
1234 active multicast subscriptions. Declare new function
1235 ospf_if_set_multicast.
1236 * ospf_interface.c: (ospf_if_set_multicast) New function to configure
1237 multicast memberships properly based on the current
1238 multicast_memberships status and the current values of the
1239 ospf_interface state, type, and passive_interface status.
1240 (ospf_if_up) Remove call to ospf_if_add_allspfrouters (this is
1241 now handled by ism_change_state's call to ospf_if_set_multicast).
1242 (ospf_if_down) Remove call to ospf_if_drop_allspfrouters (now
1243 handled by ism_change_state).
1244 * ospf_ism.c: (ospf_dr_election) Remove logic to join or leave
1245 the DRouters multicast group (now handled by ism_change_state's call
1246 to ospf_if_set_multicast).
1247 (ism_change_state) Add call to ospf_if_set_multicast to change
1248 multicast memberships as necessary to reflect the new interface state.
1249 * ospf_packet.c: (ospf_hello) When a Hello packet is received on a
1250 passive interface: 1. Increase the severity of the error message
1251 from LOG_INFO to LOG_WARNING; 2. Add more information to the error
1252 message (packet destination address and interface address);
1253 and 3. If the packet was sent to ospf-all-routers, then try
1254 to fix the multicast group memberships.
1255 (ospf_read) When a packet is received on an interface whose state
1256 is ISM_Down, enhance the warning message to show the packet
1257 destination address, and try to update/fix the multicast group
1258 memberships if the packet was sent to a multicast address.
1259 When a packet is received for ospf-designated-routers, but the
1260 current interface state is not DR or BDR, then increase the
1261 severity level of the error message from LOG_INFO to LOG_WARNING,
1262 and try to fix the multicast group memberships.
1263 * ospf_vty.c: (ospf_passive_interface) Call ospf_if_set_multicast for
1264 any ospf interface that may have changed from active to passive.
1265 (no_ospf_passive_interface) Call ospf_if_set_multicast for
1266 any ospf interface that may have changed from passive to active.
1267 (show_ip_ospf_interface_sub) Show multicast group memberships.
1268
paul3a9eb092005-02-08 11:29:41 +000012692005-02-08 Paul Jakma <paul@dishone.st>
1270
1271 * ospf_packet.c: (various) Remove unneeded stream_set_putp abuse.
1272
ajs847947f2005-02-02 18:38:48 +000012732005-02-02 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1274
1275 * ospf_packet.c: (ospf_read) Fix bug: must check for state ISM_Down,
1276 not for event ISM_InterfaceDown. And improve the message by
1277 adding the interface flags.
1278
ajs0b7d97d2005-01-30 17:24:02 +000012792005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1280
1281 * ospf_network.c: (ospf_sock_init) Save errno before calling
1282 ospfd_privs.change.
1283
ajsc3eab872005-01-29 15:52:07 +000012842005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1285
1286 * ospf_packet.c: (ospf_packet_add) If oi->obuf is NULL, print
1287 an error message and return.
1288 (ospf_read) If the interface state is ISM_InterfaceDown, issue
1289 a warning message and ignore the packet.
1290
gdt86f1fd92005-01-10 14:20:43 +000012912005-01-10 Greg Troxel <gdt@fnord.ir.bbn.com>
1292
1293 * ospf_packet.h: Remove commented out definition of
1294 OSPF_MAX_PACKET; neither it or the uncommented one are used any more.
1295
1296 * ospf_packet.c (ospf_make_ls_upd): Leave room for authentication
1297 when deciding if an update will fit.
1298 (ospf_packet_authspace): Factor out calculation of size required
1299 for authentication.
1300 (ospf_make_db_desc): Use ospf_max_packet, not OSPF_MAX_PACKET.
1301 Don't confuse readers that there is a macro.
1302
ajs3dc56b52004-12-30 15:11:19 +000013032004-12-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1304
1305 * ospf_network.c: Improve all setsockopt error messages to give detailed
1306 information on the arguments.
1307
ajsb87f7722004-12-29 20:41:26 +000013082004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1309
ajs17eaa722004-12-29 21:04:48 +00001310 * ospf_packet.c: (ospf_db_desc) Reduce severity of "Negotiation done"
1311 messages from LOG_WARNING to LOG_INFO, since this seems to be
1312 normal.
1313
13142004-12-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1315
ajsb87f7722004-12-29 20:41:26 +00001316 * ospf_packet.c: (ospf_read) Always look up the interface if
1317 ospf_recv_packet returns NULL ifp, since some platforms such
1318 as Solaris 8 appear to support ifindex retrieval but don't.
1319
hasso1d806282004-12-22 09:43:20 +000013202004-12-22 Hasso Tepper <hasso at quagga.net>
1321
1322 * ospf_dump.c: Show debug configuration in vtysh.
hassoc6b87812004-12-22 13:09:59 +00001323 * ospf_vty.c: Fix "show ip ospf" output. Router can't be elected in
1324 any case if it's configured as "translate-never".
hassofe71a972004-12-22 16:16:02 +00001325 * ospf_lsdb.[ch]: New function to calculate sum of checksums.
1326 * ospf_vty.c: Bugfix to show really number of AS external LSAs, not
1327 number of all LSAs with AS scope, this includes opaque as LSAs as
1328 well, show this number separately. Show numbers and sums of
1329 checksums for each type of LSAs.
1330 * ospf_lsa.c: Calculate checksum before putting LSA into database.
hasso1d806282004-12-22 09:43:20 +00001331
ajsbc18d612004-12-15 15:07:19 +000013322004-12-15 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1333
1334 * ospf_interface.h: Declare new function ospf_default_iftype.
1335 * ospf_interface.c: (ospf_default_iftype) New function to centralize
1336 this logic in one place.
1337 * ospf_zebra.c: (ospf_interface_add) Use new function
1338 ospf_default_iftype.
1339 * ospf_vty.c: (no_ip_ospf_network,config_write_interface) Fix logic
1340 by using new function ospf_default_iftype.
1341
ajs3aa8d5f2004-12-11 18:00:06 +000013422004-12-11 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1343
1344 * ospf_packet.c: (ospf_db_desc) Should be static, not global.
1345 (ospf_hello,ospf_db_desc,ospf_ls_upd,ospf_ls_ack) Improve warning
1346 messages to include identifying information (e.g. router id).
1347 * ospf_nsm.c: (nsm_change_state) Improve info message to include
1348 router id and state names.
1349
gdt91f3e522004-12-09 14:51:03 +000013502004-12-09 Greg Troxel <gdt@fnord.ir.bbn.com>
1351
gdt3fb9de72004-12-09 16:30:04 +00001352 * ospf_apiserver.c (ospf_apiserver_term): Obtain struct
1353 ospf_apiserver * from listnode. Remove unused variables. Follows
1354 suggestion from Jay Fenlason.
gdt91f3e522004-12-09 14:51:03 +00001355
ajs9b0e25c2004-12-08 19:06:51 +000013562004-12-08 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1357
1358 * *.c: Change level of debug messages to LOG_DEBUG.
1359
ajs274a4a42004-12-07 15:39:31 +000013602004-12-07 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1361
1362 * ospf_main.c: (main) The 2nd argument to openzlog has been removed.
1363
ajs887c44a2004-12-03 16:36:46 +000013642004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1365
ajs1210fa62004-12-03 16:43:24 +00001366 * ospf_packet.c: (ospf_db_desc) Reduce priority on a debug message
1367 from LOG_NOTICE to LOG_DEBUG.
1368
13692004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1370
ajs887c44a2004-12-03 16:36:46 +00001371 * ospf_main.c: (sigint) Use zlog_notice for termination message.
1372 (main) Issue a startup announcement using zlog_notice.
1373
ajsbec595a2004-11-30 22:38:43 +000013742004-11-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1375
1376 * ospf_packet.c: (ospf_db_desc_proc) Fix spelling of packet in warning
1377 message and in comment.
1378 (ospf_db_desc) Warning message that a packet is being discarded
1379 should give the router id of the packet source. Fix spelling
1380 of packet in two warning messages.
1381 (ospf_ls_req) Warning message that a link state request is being
1382 discarded should give the router id of the neighbor that sent it.
1383
ajs5b85fac2004-11-26 19:36:42 +000013842004-11-26 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
1385
1386 * ospf_main.c: Remove #include "debug.h" (was not being used, and
1387 lib/debug.h has now been deleted).
1388
hassoc0652302004-11-25 19:33:48 +000013892004-11-25 Hasso Tepper <hasso at quagga.net>
1390
1391 * ospf_main.c: Make group to run as configurable.
1392
gdt69e13252004-11-15 18:51:15 +000013932004-11-15 Greg Troxel <gdt@fnord.ir.bbn.com>
1394
1395 * ospf_packet.c (ospf_recv_packet): Assume CMSG_SPACE is present
1396 and works (lib/zebra.h provides if OS doesn't).
1397
paul788dab12004-11-15 11:48:37 +000013982004-11-15 Paul Jakma <paul@dishone.st>
1399
1400 * ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
1401
paul05e85fa2004-11-12 10:52:19 +000014022004-11-12 Paul Jakma <paul@dishone.st>
1403
1404 * ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
1405 ignore stub area summary default. Even so it seems a strange
1406 check, add a comment to that effect.
1407
paulf3ae74c2004-11-04 20:35:31 +000014082004-11-04 Paul Jakma <paul@dishone.st>
1409
1410 * ospfd.c: (ospf_network_match_iface) revert to previous network
1411 statement match behaviour.
1412
paul62d8e962004-11-02 20:26:45 +000014132004-11-02 Paul Jakma <paul@dishone.st>
1414
1415 * ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
1416 to it. Add convenience pointer to msg->msg_iov[1], and use this,
1417 fixing the unfortunate borkenness introduced in moving of this code
1418 to a function.
1419 (ospf_write) remove iovp and fix up call to previous.
1420 (ospf_ls_upd_packet_new) cast size to long int - unfortunately
1421 glibc's size_t format modifier is not portable.
1422
paul37ccfa32004-10-31 11:24:51 +000014232004-10-31 Paul Jakma <paul@dishone.st>
1424
1425 * ospf_packet.c: (ospf_write_frags) Add debug output
1426 (ospf_write) set type early, so we can pass it to
1427 ospf_write_frags.
1428 (ospf_ls_upd_packet_new) print size in debug output when too large
1429 packet is encountered.
paul64511f32004-10-31 18:01:13 +00001430 * ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
1431 THREAD_ARG to store an integer, but it should at least use same
1432 same type to retrieve the value. Assert value is sane.
paul37ccfa32004-10-31 11:24:51 +00001433
paulac191232004-10-22 12:05:17 +000014342004-10-22 Paul Jakma <paul@dishone.st>
1435
1436 * ospf_network.c: (ospf_sock_init) call neutral setsock_ifindex()
1437 function.
1438 * ospf_packet.c: (ospf_read) manually look up ifindex
paul4ccb2c42004-10-22 22:52:33 +00001439 if system could not have returned one, eg openbsd, thanks to Rivo
1440 Nurges for highlighting problem and fix.
paul06f953f2004-10-22 17:00:38 +00001441 Change setsockopt_pktinfo to setsockopt_ifindex.
paulac191232004-10-22 12:05:17 +00001442
hasso3fb9cd62004-10-19 19:44:43 +000014432004-10-19 Andrew J. Schorr <aschorr@telemetry-investments.com>
1444
1445 * ospf_snmp.c: (ospf_snmp_if_update) Fix logic to handle PtP links
1446 with dedicated subnets properly.
1447 * ospf_lsa.c: (lsa_link_ptop_set) ditto.
1448 * ospfd.c: (ospf_network_match_iface) ditto.
1449 (ospf_network_run) ditto.
1450 * ospf_interface.c: (ospf_if_is_configured) ditto.
1451 (ospf_if_lookup_by_prefix) ditto.
1452 (ospf_if_lookup_recv_if) ditto.
1453 * ospf_vty.c: (show_ip_ospf_interface_sub) Display the peer or
1454 broadcast address if present.
1455
hassod68614d2004-10-13 09:32:48 +000014562004-10-13 Hasso Tepper <hasso at quagga.net>
1457
1458 * ospf_main.c: Unbreak compilation with ospfapi disabled.
hassoc75105a2004-10-13 10:33:26 +00001459 * ospf_snmp.c: Remove defaults used to initialize smux connection to
1460 snmpd. Connection is initialized only if smux peer is configured.
hassod68614d2004-10-13 09:32:48 +00001461
hassof4d58ce2004-10-12 06:13:54 +000014622004-10-12 Hasso Tepper <hasso at quagga.net>
1463
1464 * ospf_main.c, ospf_opaque.c: Unbreak ospfclient compilation - move
1465 static variable from ospf_main.c into ospf_opaque.c.
1466
hassoc3abdb72004-10-11 16:27:03 +000014672004-10-11 Hasso Tepper <hasso at quagga.net>
1468
1469 * ospf_main.c, ospf_opaque.c: Disable ospfapi init by default. New
1470 command line switch to enable it.
1471
paul6b333612004-10-11 10:11:25 +000014722004-10-11 Paul Jakma <paul@dishone.st>
1473
1474 * ospf_dump.c: (ospf_ip_header_dump) Assume header is in host order
1475 remove ntohs that should have dissappeared. Take struct ip
1476 as argument, caller has to know there's an IP header at start of
1477 stream anyway.
1478 * ospf_dump.h: update declaration of ospf_ip_header_dump.
1479 * ospf_packet.c: (ospf_write) correct call to
1480 sockopt_iphdrincl_swab_htosys which was munging the header.
1481 (ospf_recv_packet) ip_len is needed for old OpenBSD fixup.
1482 (ospf_read) sockopt_iphdrincl_swab_systoh ip header as soon as
1483 we have it.
paul6c835672004-10-11 11:00:30 +00001484 * (global) Const char update and signed/unsigned fixes.
1485 * (various headers) size defines should be unsigned.
1486 * ospf_interface.h: remove duplicated defines, include the
1487 authoritative header - though, these defines should probably
1488 be moved to a dedicated header, or ospfd.h.
1489 * ospf_lsa.h: (struct lsa) ls_seqnum should be unsigned.
1490 * ospf_packet.c: (ospf_write) cast result of shift to unsigned.
paul6b333612004-10-11 10:11:25 +00001491
hassoeb1ce602004-10-08 08:17:22 +000014922004-10-08 Hasso Tepper <hasso at quagga.net>
1493
1494 * *.[c|h]: Fix compiler warnings: make some strings const, signed ->
1495 unsigned, remove unused variables etc.
1496
gdt54ade992004-10-07 19:38:20 +000014972004-10-07 Greg Troxel <gdt@claude.ir.bbn.com>
1498
1499 * ospf_apiserver.c (ospf_apiserver_unregister_opaque_type): Don't
1500 use of variable names 'node' and 'nextnode' to avoid possible
1501 conflict with list macros. Move variable declaration inside for
1502 loop after a statement to top of function.
1503
paulaa20c6f2004-10-07 14:19:36 +000015042004-10-07 Paul Jakma <paul@dishone.st>
1505
1506 * ospf_snmp.c: Missed list typedef update
1507 * ospf_dump.c: Include sockopt.h for header swab functions.
1508
paul18b12c32004-10-05 14:38:29 +000015092004-10-05 Paul Jakma <paul@dishone.st>
1510
1511 * ospf_packet.c: replace ospf_swap_iph_to... with
1512 sockopt_iphdrincl_swab_...
1513
hasso18a6dce2004-10-03 18:18:34 +000015142004-10-03 James R. Leu <jleu at mindspring.com>
1515
1516 * ospf_zebra.c: Read router id related messages from zebra daemon.
1517 Schedule router-id update thread if it's changed.
1518 * ospfd.c: Remove own router-id selection function. Use router id from
1519 zebra daemon if it isn't manually overriden in configuration.
1520
paul68defd62004-09-27 07:27:13 +000015212004-09-27 Paul Jakma <paul@dishone.st>
1522
paul6a99f832004-09-27 12:56:30 +00001523 * ospf_dump.c: (ospf_ip_header_dump) Use HAVE_IP_HDRINCL_BSD_ORDER
1524 Apply to offset too. Print ip_cksum, lets not worry about
1525 possible 2.0.37 compile problems.
1526 * ospf_packet.c: (ospf_swap_iph_to{n,h}) Use
1527 HAVE_IP_HDRINCL_BSD_ORDER.
1528 (ospf_recv_packet) ditto.
1529 (ospf_write) Fixup iov argument to ospf_write_frags.
1530 (struct msghdr).msg_name is caddr_t on most platforms.
paul68defd62004-09-27 07:27:13 +00001531 (ospf_recv_packet) ditto. And msg_flags is not always there
1532 memset struct then set fields we care about rather than
1533 initialise all fields individually.
1534
hassoc9e52be2004-09-26 16:09:34 +000015352004-09-26 Hasso Tepper <hasso at quagga.net>
1536
1537 * ospf_abr.c, ospf_dump.c, ospf_lsa.c, ospf_packet.c, ospf_vty.c,
1538 ospf_zebra.c: Fix compiler warnings.
1539
paul87d6f872004-09-24 08:01:38 +000015402004-09-24 Paul Jakma <paul@dishone.st>
1541
1542 * ospf_apiserver.{c,h}: lists typedef removal cleanup.
1543 update some list loops to LIST_LOOP. some miscellaneous indent
1544 fixups.
1545 (ospf_apiserver_unregister_opaque_type) fix listnode_delete of
1546 referenced node in loop.
paul1603c062004-09-24 08:23:24 +00001547 (ospf_apiserver_term) loops calling ospf_apiserver_free, which
1548 deletes referenced nodes from apiserver_list, fixed.
paul87d6f872004-09-24 08:01:38 +00001549 * ospf_interface.h: lists typedef removal cleanup.
1550 * ospf_opaque.{c,h}: lists typedef removal cleanup. update some list
1551 loops to LIST_LOOP. miscellaneous style and indent fixups.
1552 * ospf_te.{c,h}: ditto
1553 * ospf_packet.c: lists typedef removal cleanup.
paula2570682004-09-24 08:09:57 +00001554 (ospf_write) ifdef fragmentation support. move actual
1555 fragmentation out to a new, similarly ifdefed, function.
1556 (ospf_write_frags) fragmented write support, moved from previous.
paul87d6f872004-09-24 08:01:38 +00001557
hasso52dc7ee2004-09-23 19:18:23 +000015582004-09-23 Hasso Tepper <hasso at quagga.net>
1559
1560 * *.[c|h]: list -> struct list *, listnode -> struct listnode *.
1561
paul68b73392004-09-12 14:21:37 +000015622004-09-12 Paul Jakma <paul@dishone.st>
1563
1564 * ospf_packet.c: Fix bugzilla #107
1565 (ospf_packet_max) get rid of the magic 88 constant
1566 (ospf_swab_iph_ton) new function. set ip header to network order,
1567 taking BSDisms into account.
1568 (ospf_swab_iph_toh) the inverse.
1569 (ospf_write) Add support for IP fragmentation, will only work on
1570 linux though, other kernels make it impossible. get rid of the
1571 magic 4 constant.
1572 (ospf_make_ls_upd) Bound check to end of stream, not to
1573 interface mtu.
1574 (ospf_ls_upd_packet_new) New function, allocate upd packet
1575 taking oversized LSAs into account.
1576 (ospf_ls_upd_queue_send) use ospf_ls_upd_packet_new to allocate,
1577 rather than statically allocating mtu sized packet buffer, which
1578 actually was wrong - it didnt take ip header into account, which
1579 should not be included in packet buffer.
1580 (ospf_ls_upd_send_queue_event) minor tweaks and remove
1581 TODO comment.
1582
gdt630e4802004-08-31 17:28:41 +000015832004-08-31 David Wiggins <dwiggins@bbn.com>
1584
1585 * ospf_spf.c (ospf_spf_calculate): Many more comments and debug
1586 print statements. New function ospf_vertex_dump used in debugging.
1587
15882004-08-31 David Wiggins <dwiggins@bbn.com>
1589
1590 * ospf_spf.h (struct vertex): Comments for flags and structure members.
1591
15922004-08-31 David Wiggins <dwiggins@bbn.com>
1593
1594 * ospf_route.c: When finding an alternate route, log cost as well.
1595
15962004-08-31 David Wiggins <dwiggins@bbn.com>
1597
1598 * ospf_interface.c (ospf_lookup_if_params): Initialize af in
1599 struct prefix allocated on stack.
1600
16012004-08-31 David Wiggins <dwiggins@bbn.com>
1602
1603 * ospf_packet.c (ospf_ls_ack_send_delayed): In p2mp mode, send
1604 acks to AllSPFRouters, rather than All-DR.
1605
hasso7b901432004-08-31 13:37:42 +000016062004-08-27 Hasso Tepper <hasso at quagga.net>
1607
1608 * ospf_vty.c: Don't print ospf network type under interface only
1609 if interface is in broadcast mode and interface type really is
1610 broadcast. Fixes Bugzilla #108.
1611
gdtd7d93992004-08-27 12:03:42 +000016122004-08-27 David Wiggins <dwiggins@bbn.com>
1613
1614 * ospf_spf.c (ospf_nexthop_calculation): Initialize address family
1615 in on-stack struct prefix_ipv4. Fixes point-to-multipoint SPF
1616 calculation.
1617
gdtd0deca62004-08-26 13:14:07 +000016182004-08-26 Greg Troxel <gdt@fnord.ir.bbn.com>
1619
1620 * ospf_packet.c (ospf_recv_packet): adjust size declaration of
gdtd7d93992004-08-27 12:03:42 +00001621 buffer used to get interface index so that it compiles on other
1622 than Linux and includes the required alignment space. Probably
1623 this was only working on sparc/sparc64 because most of
1624 sockaddr_dl was not being written.
gdtd0deca62004-08-26 13:14:07 +00001625
paul863082d2004-08-19 04:43:43 +000016262004-08-19 Paul Jakma <paul@dishone.st>
1627
1628 * ospf_packet.c: update to match sockopt renames.
1629
paul75ee0b82004-08-05 09:10:31 +000016302004-08-04 Paul Jakma <paul@dishone.st>
1631
1632 * ospf_spf.c: (ospf_spf_consider_nexthop) Add comment about issue.
1633 Compare only against list head - all nexthops must be same cost
1634 anyway, fixes a reference-listnode-after-delete bug noted by
1635 Kir Kostuchenko.
1636 (ospf_nexthop_calculation) Use ospf_spf_consider_nexthop for all
1637 candidates attached to root.
1638
paul36c64ef2004-07-27 11:19:11 +000016392004-07-27 Paul Jakma <paul@dishone.st>
1640
paul48fe13b2004-07-27 17:40:44 +00001641 * ospf_packet.c: (ospf_ls_upd_send_queue_event) fix thinko from
1642 last fix for ospfd wedging due to oversize LSAs: dont list loop on
1643 ospf_ls_upd_queue_send() - guaranteed segfault.
1644
16452004-07-27 Paul Jakma <paul@dishone.st>
1646
paul36c64ef2004-07-27 11:19:11 +00001647 * ospf_opaque.c: (ospf_opaque_lsa_flush_schedule) do not NULL out
1648 the LSA as then free_opaque_info_per_id() can never unlock (and
1649 free) the LSA. Reported by Gunnar Stigen.
1650
paul2dd8bb42004-07-23 15:13:48 +000016512004-07-23 Paul Jakma <paul@dishone.st>
1652
1653 * ospf_network.c: Replace PKTINFO/RECVIF with call to
1654 setsockopt_pktinfo
1655 * ospf_packet.c: Use getsockopt_pktinfo_ifindex and
1656 SOPT_SIZE_CMSG_PKTINFO_IPV4.
1657
paul59ea14c2004-07-14 20:50:36 +000016582004-07-14 Paul Jakma <paul@dishone.st>
1659
1660 * ospf_packet.c: (ospf_ls_upd_send_queue_event) Partial fix for
1661 problem reported by Peter Frost amongst others, where function
1662 will spin indefinitely if update list contains LSAs greater than
1663 MTU-headers or other condition leading to update list never being
1664 cleared. Problem of what to do with these LSAs remains.
1665 (ospf_make_ls_upd) add comment about large LSA problem,
1666 indentation cleanup.
1667
gdtb2c1b282004-07-01 12:35:36 +000016682004-07-01 Greg Troxel <gdt@fnord.ir.bbn.com>
1669
1670 * Makefile.am (lib_LTLIBRARIES): make libospf shared
1671
gdt87efd642004-06-30 17:36:11 +000016722004-06-30 Greg Troxel <gdt@poblano.ir.bbn.com>
1673
1674 * Makefile.am: Add shlib support.
1675
hassobeebba72004-06-20 21:00:27 +000016762004-06-10 Hasso Tepper <hasso@estpak.ee>
1677
1678 * *: Removed ifdefs HAVE_NSSA.
1679
paul553ff112004-06-06 09:41:00 +000016802004-06-06 Paul Jakma <paul@dishone.st>
1681
1682 * ospf_dump.c,ospf_lsa.c: Fix typos of merge of previous.
1683 ospf_flood.c: (ospf_process_self_originated_lsa) fix zlog format
1684
paul0c2be262004-05-31 14:16:54 +000016852004-05-31 Sagun Shakya <sagun.shakya@sun.com>
1686
1687 * ospf_dump.c: (ospf_lsa_header_dump) LOOKUP can return null if
1688 index is out of range.
1689 ospf_flood.c: endianness fix
1690 ospf_lsa.c: Missing ntohl's on (struct lsa *)->data->ls_seqnum
1691 in various places.
1692
hassodd669bb2004-05-10 07:43:59 +000016932004-05-10 Hasso Tepper <hasso@estpak.ee>
1694
1695 * ospf_zebra.c, ospfd.c: Move ospf_prefix_list_update() function
1696 to ospf_zebra.c from ospfd.c and add redistribution updates if
1697 route-map is used in redistribution.
1698 * ospf_main.c: Remove now useless call to ospf_init().
1699
paul0a589352004-05-08 11:48:26 +000017002004-05-08 Paul Jakma <paul@dishone.st>
1701
1702 * ospf_zebra.c: Sync with lib/zclient changes
1703
pauld3f0d622004-05-05 15:27:15 +000017042004-05-05 Paul Jakma <paul@dishone.st>
1705
paul5bd41892004-05-05 17:29:24 +00001706 * ospf_network.c: (ospf_sock_init) Check whether IP_HDRINCL is
1707 defined. Warn at compile and runtime. Use
1708 IPTOS_PREC_INTERNETCONTROL otherwise.
pauld3f0d622004-05-05 15:27:15 +00001709 * ospf_packet.c: (ospf_associate_packet_vl) cleanup, move
1710 some of the checks up to ospf_read, return either a
1711 virtual link oi, or NULL.
1712 (ospf_read) Cleanup, make it responsible for checks. Remove
1713 the nbr lookup - moved to ospf_neighbor. Adjust all nbr
1714 lookups to use new wrappers exported by ospf_neighbor.
1715 * ospf_neighbor.h: Add ospf_neigbour_get and ospf_nbr_lookup.
1716 * ospf_neighbor.c: (ospf_neigbour_get) Index ospf_interface
1717 neighbour table by router-id for virtual-link ospf_interfaces,
1718 not by peer_addr (which breaks for asymmetric vlinks)
1719 (ospf_nbr_lookup) add a wrapper for nbr lookups to deal with
1720 above.
paulcd59da62004-05-05 17:26:55 +00001721 * ospf_interface.c: (ospf_vl_set_params) Catch changes of interface
1722 address for either end of a virtual-link, and hence potential cost
1723 changes.
1724
hassoa0a39762004-04-23 08:51:10 +000017252004-04-22 Hasso Tepper <hasso@estpak.ee>
1726
1727 * ospf_zebra.c: Don't ignore reject/bh routes, it's the only way
1728 to "summarize" routes in ASBR at the moment.
1729
hasso8585d4e2004-04-20 17:25:12 +000017302004-04-20 Hasso Tepper <hasso@estpak.ee>
1731
1732 * ospfd.c: Unset NP flag if area is going to be normal or stub.
1733 Fixes UNH OSPF_NSSA.1.2a comment.
1734 * ospf_abr.c: Originate default into stub/nssa area even if
1735 summaries are disabled.
1736 * ospf_zebra.c: Don't attempt to redistribute 127.0.0.0/8.
1737
hassoc266ac72004-04-19 17:31:00 +000017382004-04-19 Hasso Tepper <hasso@estpak.ee>
1739
1740 * ospf_vty.c: Don't warn that export- and import-list can't be
1741 configured to backbone area if they are applied and are working
1742 fine.
1743
hasso128d31d2004-04-04 12:52:33 +000017442004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1745
1746 * ospf_packet.c: Don't drop packets in Solaris x86.
1747 [quagga-dev 1005].
1748
hasso0d85b992004-03-18 19:18:33 +000017492004-03-18 Amir Guindehi <amir@datacore.ch>
1750
1751 * ospf_opaque.c: Attempt to correct the incorrect behavior of
1752 Quagga's ospfd in the special situation that a node's opaque
1753 capability has changed as "ON -> OFF -> ON". [quagga-dev 843].
1754
paul7f352b82004-02-19 19:37:47 +000017552004-02-19 Sowmini Varadhan <sowmini.varadhan@sun.com>
1756
1757 * ospf_abr.c: (ospf_abr_update_aggregate) UNH 3.12b,c, address range
1758 should be configured with the highest cost path within the range,
1759 not lowest.
1760
paul940b01a2004-02-17 20:07:30 +000017612004-02-17 Paul Jakma <paul@dishone.st>
1762
1763 * ospf_zebra.c: (ospf_interface_delete) Do not delete the interface
1764 params, nor the interface structure, if an interface delete
1765 message is received from zebra.
1766 * ospf_interface.c: (ospf_if_delete_hook) Delete the interface
1767 params and interface, ie that which was previously removed in
1768 (ospf_interface_delete) above.
1769
hasso2db3d052004-02-11 21:52:13 +000017702004-02-11 Hasso Tepper <hasso@estpak.ee>
1771 * ospf_interface.c, ospf_zebra.c: Don't attempt to read path->oi->ifp
1772 if oi doesn't exist any more.
1773
hassocb05eb22004-02-11 21:10:19 +000017742004-02-11 Vadim Suraev <vadim.suraev@terayon.com>
1775 * ospf_packet.c (ospf_ls_upd): Router should flush received network
1776 LSA if it was originated with older router-id ([zebra 14710] #6).
1777
17782003-12-08 Mattias Amnefelt <mattiasa@kth.se>
paul239aecc2003-12-08 10:34:54 +00001779
1780 * ospf_packet.c: (ospf_recv_packet) OpenBSD now leaves iph.ip_len
1781 network byte order.
1782
gdt8f40e892003-12-05 14:01:43 +000017832003-12-05 Greg Troxel <gdt@poblano.ir.bbn.com>
1784
1785 * ospfd.c (ospf_network_match_iface): Rewrite code for clarity
1786 while trying not to change semantics. Add ifdefed-out code to
1787 avoid matching ppp interfaces whose destination address does not
1788 also match the prefix under consideration, to help out people with
1789 problems due to as-yet-unfixed bugs with p2p interfaces coming and
1790 going.
1791
paul736d3442003-07-24 23:22:57 +000017922003-07-25 kamatchi soundaram <kamatchi@tdd.sj.nec.com>
1793
1794 * ospf_packet.c (ospf_ls_upd_send_queue_event): get next route
1795 node in body of the loop to avoid chance that route node
1796 is unlocked and deleted before the next iteration tries to
1797 get next route node.
1798
paul0a825c72003-05-24 13:48:16 +000017992003-05-24 Kenji Yabuuchi
1800
1801 * ospf_interface.c(ospf_if_lookup_recv_if): Use the most specific
1802 match for interface lookup.
1803
paul551a8972003-05-18 15:22:55 +000018042003-05-18 Hasso Tepper <hasso@estpak.ee>
paul445f1432003-05-16 19:00:31 +00001805
paul551a8972003-05-18 15:22:55 +00001806 * ospf_vty.c: Show NSSA LSA route info in "show ip ospf database"
1807 output
paul445f1432003-05-16 19:00:31 +00001808
pauld7480322003-05-16 17:31:51 +000018092003-05-16 Hasso Tepper <hasso@estpak.ee>
1810
1811 * ospf_lsa.c: Fix handling of NSSA
1812
paul551a8972003-05-18 15:22:55 +000018132003-04-23 Hasso Tepper <hasso@estpak.ee>
1814
1815 * ospf_vty.c: fix "router xxx" node commands in vtysh
1816
paul445f1432003-05-16 19:00:31 +000018172003-04-19 Hasso Tepper <hasso@estpak.ee>
1818
1819 * {ospf_abr,ospfd}.c: area id's DECIMAL -> ADDRESS
1820 * ospf_routemap.c: sync daemon's route-map commands to have same
1821 syntax.
1822
18232003-04-19 Sergey Vyshnevetskiy <serg@vostok.net>
1824
1825 * ospf_packet.c: Add missing param to zlog
1826 * ospf_flood.c: remove unused vars
1827
18282003-04-17 Denis Ovsienko <zebra@pilot.org.ua>
1829
1830 * ospf_interface.c: fix incorrect memset
1831
paul28a13842003-05-16 20:30:37 +000018322003-04-10 Amir Guindehi <amir@datacore.ch>
paul445f1432003-05-16 19:00:31 +00001833
1834 * ospf_lsa.[ch]: opaque LSA fix, use ospf_lookup.
1835
18362003-04-03 David Watson <dwatson@eecs.umich.edu>
1837
1838 * ospf_lsa.c: byte order fix
1839
paul07661cb2003-03-18 00:03:05 +000018402002-03-17 Amir Guindehi <amir@datacore.ch>
1841
1842 * ospf_apiserver.[ch]: Merge Ralph Keller's OSPFAPI support.
1843 * ospf_api.[ch]: Merge Ralph Keller's OSPFAPI support.
1844 * ospfclient: OSPFAPI demonstration client.
1845
18462003-01-23 Masahiko Endo <endo@suri.co.jp>
1847
1848 * ospf_ism.c: NSM event schedule bug fix.
1849
18502002-10-30 Greg Troxel <gdt@ir.bbn.com>
1851
1852 * ospf_packet.c (ospf_make_md5_digest): MD5 length fix.
1853
paul718e3742002-12-13 20:15:29 +000018542002-10-23 endo@suri.co.jp (Masahiko Endo)
1855
1856 * ospf_opaque.c: Update Opaque LSA patch.
1857
18582002-10-23 Ralph Keller <keller@tik.ee.ethz.ch>
1859
1860 * ospf_vty.c (show_ip_ospf_database): Fix CLI parse.
1861
18622002-10-23 Juris Kalnins <juris@mt.lv>
1863
1864 * ospf_interface.c (ospf_if_stream_unset): When write queue
1865 becomes empty stop write timer.
1866
18672002-10-10 Greg Troxel <gdt@ir.bbn.com>
1868
1869 * ospf_packet.c (ospf_check_md5_digest): Change >= to > to make it
1870 conform to RFC.
1871
18722002-07-07 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1873
1874 * zebra-0.93 released.
1875
18762002-06-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1877
1878 * ospf_spf.c (ospf_nexthop_calculation): Add NULL set to oi and
1879 check of l2. Reported by: Daniel Drown <dan-zebra@drown.org>
1880 (ospf_lsa_has_link): LSA Length calculation fix. Reported by:
1881 Paul Jakma <paulj@alphyra.ie>.
1882
1883 * ospfd.c (ospf_if_update): Fix nextnode reference bug. Reported
1884 by: juris@mt.lv.
1885
18862002-01-21 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1887
1888 * ospfd.c: Merge [zebra 11445] Masahiko ENDO's Opaque-LSA support.
1889
18902001-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
1891
1892 * ospf_interface.c (ospf_add_to_if): Use /32 address to register
1893 OSPF interface information.
1894 (ospf_delete_from_if): Likewise.
1895
1896 * ospf_zebra.c (ospf_interface_address_delete): Likewise.
1897
18982001-08-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1899
1900 * ospf_zebra.c (ospf_redistribute_unset): When redistribute type
1901 is OSPF, do not unset redistribute flag.
1902
19032001-08-19 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1904
1905 * zebra-0.92a released.
1906
19072001-08-15 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1908
1909 * zebra-0.92 released.
1910
19112001-08-12 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1912
1913 * ospfd.c (ospf_config_write): auto-cost reference-bandwidth
1914 configuration display.
1915
19162001-07-24 David Watson <dwatson@eecs.umich.edu>
1917
1918 * ospf_spf.c (ospf_spf_next): Modify ospf_vertex_add_parent to
1919 check for an existing link before connecting the parent and child.
1920 ospf_nexthop_calculation is also modified to check for duplicate
1921 entries when copying from the parent. Finally, ospf_spf_next
1922 removes duplicates when it merges two equal cost candidates.
1923
19242001-07-23 itojun@iijlab.net
1925
1926 * ospfd.c (show_ip_ospf_neighbor): Check ospf_top before use it
1927 [zebra 8549].
1928
19292001-07-23 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1930
1931 * ospf_packet.c (ospf_write): Remove defined(__OpenBSD__) to make
1932 it work on OpenBSD.
1933
19342001-06-26 Kunihiro Ishiguro <kunihiro@zebra.org>
1935
1936 * ospf_zebra.c (config_write_ospf_default_metric): Display
1937 default-metric configuration.
1938
19392001-06-18 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1940
1941 * ospf_ia.h (OSPF_EXAMINE_SUMMARIES_ALL): Remove old macros.
1942
19432001-05-28 Kunihiro Ishiguro <kunihiro@ipinfusion.com>
1944
1945 * ospf_snmp.c (ospfIfEntry): Fix interface lookup bug to avoid
1946 crush.
1947 (ospfIfMetricEntry): Likewise.
1948
19492001-03-18 Kunihiro Ishiguro <kunihiro@zebra.org>
1950
1951 * ospf_packet.c (ospf_read): Fix typo. Reported by: "Jen B
1952 Lin'Kova" <jen@stack.net>.
1953
19542001-03-15 Gleb Natapov <gleb@nbase.co.il>
1955
1956 * ospf_interface.c (ip_ospf_network): Set interface parameter.
1957 (interface_config_write): Add check for OSPF_IFTYPE_LOOPBACK.
1958
1959 * ospf_zebra.c (ospf_interface_add): Set interface parameter.
1960
19612001-02-21 Kunihiro Ishiguro <kunihiro@zebra.org>
1962
1963 * ospf_packet.c (ospf_recv_packet): Solaris also need to add
1964 (iph.ip_hl << 2) to iph.ip_len.
1965
19662001-02-09 Kunihiro Ishiguro <kunihiro@zebra.org>
1967
1968 * ospfd.h (OSPF_LS_REFRESH_TIME): Fix OSPF_LS_REFRESH_TIME value.
1969 Suggested by: David Watson <dwatson@eecs.umich.edu>.
1970
1971 * ospf_zebra.c (zebra_init): Remove zebra node.
1972
1973 * ospfd.c (ospf_area_range_set): Function name is changed from
1974 ospf_ara_range_cmd.
1975 (ospf_area_range_unset): New function which separated from DEFUN.
1976 New commands are added:
1977 "no area A.B.C.D range A.B.C.D/M advertise"
1978 "no area <0-4294967295> range A.B.C.D/M advertise"
1979 "no area A.B.C.D range A.B.C.D/M not-advertise"
1980 "no area <0-4294967295> range A.B.C.D/M not-advertise"
1981
1982 * ospf_lsa.c (ospf_lsa_more_recent): Fix previous change.
1983
19842001-02-08 Matthew Grant <grantma@anathoth.gen.nz>
1985
1986 * ospf_network.c (ospf_if_add_allspfrouters): Use
1987 setsockopt_multicast_ipv4.
1988 (ospf_if_drop_allspfrouters): Likewise.
1989
1990 * ospf_lsa.c (ospf_router_lsa_install): Add rt_recalc flag.
1991 (ospf_network_lsa_install): Likewise.
1992 (ospf_summary_lsa_install): Likewise.
1993 (ospf_summary_asbr_lsa_install): Likewise.
1994 (ospf_external_lsa_install): Likewise.
1995 (ospf_lsa_install): Call ospf_lsa_different to check this LSA is
1996 new one or not.
1997
19982001-02-08 Kunihiro Ishiguro <kunihiro@zebra.org>
1999
2000 * ospf_zebra.c (ospf_interface_delete): Do not free interface
2001 structure when ospfd receive interface delete message to support
2002 pseudo interface.
2003
20042001-02-01 Dick Glasspool <dick@ipinfusion.com>
2005
2006 * ospfd.c (area_range_notadvertise): Change area range "suppress"
2007 command to "not-advertise".
2008
2009 * ospfd.h (OSPF_LS_REFRESH_TIME): Change OSPF_LS_REFRESH_TIME from
2010 1800 to 60.
2011
2012 * ospf_abr.c (ospf_abr_update_aggregate): When update_aggregate is
2013 updating the area-range, the lowest cost is now saved.
2014
2015 * ospf_lsa.c (ospf_lsa_more_recent): Routing to compare sequence
2016 numbers rather than creating overflow during calculation.
2017
20182001-02-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2019
2020 * zebra-0.91 is released.
2021
20222001-01-31 Kunihiro Ishiguro <kunihiro@zebra.org>
2023
2024 * ospf_packet.c (ospf_db_desc_proc): Do not continue process when
2025 NSM_SeqNumberMismatch is scheduled.
2026 (ospf_ls_req): Free ls_upd when return from this function.
2027 (ospf_ls_upd_timer): When update list is empty do not call
2028 ospf_ls_upd_send(). Suggested by: endo@suri.co.jp (Masahiko
2029 Endo).
2030
20312001-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
2032
2033 * ospf_lsa.c (ospf_maxage_flood): Flood LSA when it reaches
2034 MaxAge. RFC2328 Section 14.
2035 (ospf_maxage_lsa_remover): Call above function during removing
2036 MaxAge LSA.
2037
20382001-01-26 Dick Glasspool <dick@ipinfusion.com>
2039
2040 * ospf_flood.c (ospf_flood_through_as): Function is updated for
2041 NSSA Translations now done at ospf_abr.c with no change in P-bit.
2042
2043 * ospf_lsa.c (ospf_get_nssa_ip): Get 1st IP connection for Forward
2044 Addr.
2045 (ospf_install_flood_nssa): Leave Type-7 LSA at Lock Count = 2.
2046
2047 * ospf_ase.c (ospf_ase_calculate_route): Add debug codes.
2048
2049 * ospf_abr.c (ospf_abr_translate_nssa): Recalculate LSA checksum.
2050
2051 * ospf_packet.h (OSPF_SEND_PACKET_LOOP): Added for test packet.
2052
2053 * ospf_dump.c (ospf_lsa_type_msg): Add OSPF_GROUP_MEMBER_LSA and
2054 OSPF_AS_NSSA_LSA.
2055
2056 * ospfd.c (data_injection): Function to inject LSA. This is
2057 debugging command.
2058
20592001-01-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2060
2061 * ospf_route.c (ospf_route_match_same): Remove function.
2062 (ospf_route_match_same_new): Renamed to ospf_route_match_same.
2063
2064 * ospf_zebra.c (ospf_interface_address_delete): Add check for
2065 oi->address. Suggested by Matthew Grant
2066 <grantma@anathoth.gen.nz>.
2067 (ospf_zebra_add): Remove function.
2068 (ospf_zebra_add_multipath): Rename to ospf_zebra_add.
2069
2070 * ospf_interface.c: Remove HAVE_IF_PSEUDO part.
2071
2072 * ospf_zebra.c: Likewise.
2073
20742001-01-10 Kunihiro Ishiguro <kunihiro@zebra.org>
2075
2076 * ospf_ase.c: Remove OLD_RIB part.
2077
2078 * ospf_route.c: Likewise.
2079
2080 * zebra-0.90 is released.
2081
2082 * ospf_packet.c (ospf_recv_packet): Use ip_len adjestment code to
2083 NetBSD.
2084
20852001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2086
2087 * ospf_route.c (ospf_route_delete): Use
2088 ospf_zebra_delete_multipath.
2089
20902001-01-09 Matthew Grant <grantma@anathoth.gen.nz>
2091
2092 * ospf_interface.c (ospf_if_cleanup): Function name is renamed
2093 from ospf_if_free(). Rewrite whole procudure to support primary
2094 address deletion.
2095
2096 * ospf_zebra.c (ospf_interface_address_delete): Add primary
2097 address deletion process.
2098
20992001-01-09 Kunihiro Ishiguro <kunihiro@zebra.org>
2100
2101 * ospf_packet.c (ospf_recv_packet): OpenBSD has same ip_len
2102 treatment like FreeBSD.
2103
21042001-01-09 endo@suri.co.jp (Masahiko Endo)
2105
2106 * ospf_packet.c (ospf_recv_packet): FreeBSD kernel network code
2107 strips IP header size from receiving IP Packet. So we adjust
2108 ip_len to whole IP packet size by adding IP header size.
2109
21102001-01-08 endo@suri.co.jp (Masahiko Endo)
2111
2112 * ospf_network.c (ospf_serv_sock): When socket() is failed return
2113 immediately.
2114 (ospf_serv_sock): Close socket when it is not used.
2115
2116 * ospf_packet.c (ospf_write): Set sin_len when HAVE_SIN_LEN is
2117 defined.
2118 (ospf_write): When bind is fined, close sock.
2119
21202001-01-07 Gleb Natapov <gleb@nbase.co.il>
2121
2122 * ospf_zebra.c (ospf_interface_state_up): Fixes coredump that
2123 appears when you try to configure bandwidth on the ppp interface
2124 that is not yet configured in ospfd.
2125
21262001-01-07 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2127
2128 * ospf_route.c (show_ip_ospf_route_external): "show ip ospf route"
2129 will print nexthops for AS-external routes.
2130
2131 * ospf_ase.c (ospf_ase_route_match_same): New function to compare
2132 ASE route under multipath environment.
2133 (ospf_ase_compare_tables): Likewise.
2134
21352001-01-01 Kunihiro Ishiguro <kunihiro@zebra.org>
2136
2137 * ospfd.h (OSPF_VTYSH_PATH): Change "/tmp/ospfd" to "/tmp/.ospfd".
2138
21392000-12-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2140
2141 * ospf_route.c (ospf_route_install): Install multipath information
2142 to zebra daemon.
2143
2144 * ospf_zebra.c (ospf_zebra_add_multipath): Function for passing
2145 multipath information to zebra daemon.
2146
21472000-12-25 Dick Glasspool <dick@ipinfusion.com>
2148
2149 * ospf_packet.c (ospf_write): Call ospf_packet_delete when sendto
2150 fail.
2151 (DISCARD_LSA): Add argument N for logging point of DISCARD_LSA is
2152 called.
2153
2154 * ospf_lsa.c (ospf_external_lsa_refresh): NSSA install_flood will
2155 leave Type-7 LSA at Lock Count = 2.
2156
2157 * ospf_flood.c (ospf_flood_through): Flood_though_as updated for
2158 NSSA no P-bit off during Area flooding, but P-bit is turned off
2159 for mulitple NSSA AS flooding.
2160
2161 * ospf_ase.c (ospf_ase_calculate_timer): Added calculations for
2162 Type-7 LSDB.
2163
2164 * ospf_abr.c (ospf_abr_translate_nssa): Removed one unlock call.
2165 (ospf_abr_announce_nssa_defaults): Corrected Debug from EVENT to
2166 NSSA.
2167
21682000-12-25 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2169
2170 * ospf_zebra.c (ospf_zebra_read_ipv4): Checking the age of the
2171 found LSA and if the LSA is MAXAGE we should call refresh instead
2172 of originate.
2173
21742000-12-18 Dick Glasspool <dick@ipinfusion.com>
2175
2176 * ospf_abr.c: Removed redundant "...flood" in
2177 announce_network_to_area(). Repaired nssa Unlock by using
2178 discard.
2179
2180 * ospf_packet.c: Removed old NSSA translate during mk_ls_update.
2181
2182 * ospfd.c: Free up all data bases including NSSA.
2183
2184 * ospf_lsa.c: Now allow removal of XLATE LSA's Check in
2185 discard_callback. Added routine to get ip addr from within the
2186 ifp.
2187
2188 * ospf_flood.c: Now set Forward Address for outgoing Type-7.
2189
2190 * ospf_lsa.h: Added prototype for the below. struct in_addr
2191 ospf_get_ip_from_ifp (struct interface *ifp).
2192
21932000-12-14 Gleb Natapov <gleb@nbase.co.il>
2194
2195 * ospf_packet.c (ospf_recv_packet): New OSPF pakcet read method.
2196 Now maximum packet length may be 65535 bytes (maximum IP packet
2197 length).
2198
2199 * ospf_interface.c (ospf_if_stream_set): Don't make input buffer.
2200
2201 * ospfd.c (config_write_network_area): Remove unnecessary area
2202 lookup code.
2203
22042000-12-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2205
2206 * ospf_packet.c (ospf_read): Accept packet bigger than MTU value.
2207
22082000-12-13 Gleb Natapov <gleb@nbase.co.il>
2209
2210 * ospfd.c (config_write_network_area): Fix bug in
2211 config_write_network_area function.
2212
22132000-12-12 Gleb Natapov <gleb@nbase.co.il>
2214
2215 * ospf_abr.c (ospf_abr_announce_network_to_area): Make Summary
2216 LSA's origination and refreshment as same as other type of LSA.
2217
2218 * ospf_lsa.c (ospf_summary_lsa_refresh): Return struct ospf_lsa *.
2219
2220 * ospf_lsa.c (ospf_summary_asbr_lsa_refresh): Likewise.
2221
22222000-12-08 Dick Glasspool <dick@ipinfusion.com>
2223
2224 The bulk of NSSA changes are contained herein; This version will
2225 require manual setting of "always" for NSSA Translator, and will
2226 not perform aggregation yet.
2227
2228 * ospf_dump.c: "debug ospf nssa" is added.
2229
2230 * ospf_dump.h: Likewise.
2231
2232 * ospf_packet.c (ospf_hello): Display router ID on Bad NSSA Hello.
2233
2234 * ospfd.c: Discard_LSA to stay away from LOCAL_XLT Process NSSA
2235 'never, candidate, always'. Change "suppress" to "not-advertise".
2236
2237 * ospfd.h: Add TranslatorRole to struct ospf_area. Add anyNSSA to
2238 struct ospf.
2239
2240 * ospf_ase.c (ospf_ase_calculate_route): External to stay away
2241 from LOCAL_XLT
2242
2243 * ospf_nsm.c (ospf_db_summary_add): External to stay away from
2244 LOCAL_XLT
2245
2246 * ospf_abr.c: Major logic added for abr_nssa_task(). If ABR, and
2247 NSSA translator, then do it. Approve the global list, and flush
2248 any unapproved.
2249
2250 * ospf_lsa.h: New LSA flag OSPF_LSA_LOCAL_XLT to indicate that the
2251 Type-5 resulted from a Local Type-7 translation; not used for
2252 flooding, but used for flushing.
2253
2254 * ospf_flood.c: New NSSA flooding.
2255
22562000-12-08 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2257
2258 * ospfd.c (ospf_find_vl_data): New function for looking up virtual
2259 link data.
2260 (ospf_vl_set_security): Virtual link configuration with
2261 authentication.
2262 (ospf_vl_set_timers): Set timers for virtual link.
2263
2264 * New commands are added.
2265 "area A.B.C.D virtual-link A.B.C.D"
2266 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535>"
2267 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> authentication-key AUTH_KEY"
2268 "area A.B.C.D virtual-link A.B.C.D authentication-key AUTH_KEY"
2269 "area A.B.C.D virtual-link A.B.C.D hello-interval <1-65535> retransmit-interval <3-65535> transmit-delay <1-65535> dead-interval <1-65535> message-digest-key <1-255> md5 KEY"
2270 "area A.B.C.D virtual-link A.B.C.D message-digest-key <1-255> md5 KEY"
2271
2272 * ospf_packet.c (ospf_check_md5_digest): Add neighbor's
2273 cryptographic sequence number treatment.
2274 (ospf_check_auth): OSPF input buffer is added to argument.
2275 (ospf_read): Save neighbor's cryptographic sequence number.
2276
2277 * ospf_nsm.c (nsm_change_status): Clear cryptographic sequence
2278 number when neighbor status is changed to NSM down.
2279
2280 * ospf_neighbor.c (ospf_nbr_new): Set zero to crypt_seqnum.
2281
2282 * ospf_neighbor.h (struct ospf_neighbor): Add cryptographic
2283 sequence number to neighbor structure.
2284
22852000-11-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2286
2287 * ospf_snmp.c (ospfIfLookup): OSPF MIB updates.
2288 (ospfExtLsdbEntry): Add OspfExtLsdbTable treatment.
2289
22902000-11-28 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2291
2292 * ospfd.c (ospf_interface_down): Clear a ls_upd_queue queue of the
2293 interface.
2294 (ospf_ls_upd_queue_empty): New function to empty ls update queue
2295 of the OSPF interface.
2296 (no_router_ospf): 'no router ospf' unregister redistribution
2297 requests from zebra.
2298
22992000-11-28 Kunihiro Ishiguro <kunihiro@zebra.org>
2300
2301 * ospf_ism.c (ism_change_status): Increment status change number.
2302
2303 * ospf_interface.h (struct ospf_interface): Add new member for
2304 status change statistics.
2305
2306 * Makefile.am: Update dependencies.
2307
2308 * ospf_zebra.c (ospf_interface_add): OSPF SNMP interface update.
2309 (ospf_interface_delete): OSPF SNMP interface delete.
2310
2311 * ospf_snmp.h: New file is added.
2312
23132000-11-23 Dick Glasspool <dick@ipinfusion.com>
2314
2315 * ospfd.h: Add new ospf_area structure member for
2316 NSSATranslatorRole and NSSATranslator state.
2317
2318 * ospfd.c: Provided for eventual commands to specify NSSA
2319 elections for "translator- ALWAYS/NEVER/CANDIDATE". Provided for
2320 decimal integer version of area-suppress.
2321
2322 * ospf_flood.c: Flood Type-7's only into NSSA (not AS).
2323
2324 * ospf_lsa.c: Undo some previous changes for NSSA. If NSSA
2325 translator, advertise Nt bit.
2326
2327 * ospf_route.c: 1st version of "sh ip os border-routers".
2328
23292000-11-23 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2330
2331 * ospfd.c (area_vlink): Virtual link can not configured in stub
2332 area.
2333
23342000-11-23 Gleb Natapov <gleb@nbase.co.il>
2335
2336 * ospf_packet.c (ospf_db_desc): In states Loading and Full the
2337 slave must resend its last Database Description packet in response
2338 to duplicate Database Description packets received from the
2339 master. For this reason the slave must wait RouterDeadInterval
2340 seconds before freeing the last Database Description packet.
2341 Reception of a Database Description packet from the master after
2342 this interval will generate a SeqNumberMismatch neighbor
2343 event. RFC2328 Section 10.8
2344 (ospf_make_db_desc): DD Master flag treatment.
2345
2346 * ospf_nsm.c (nsm_twoway_received): Move DD related procedure to
2347 nsm_change_status().
2348 (nsm_bad_ls_req): Likewise.
2349 (nsm_adj_ok): Likewise.
2350 (nsm_seq_number_mismatch): Likewise.
2351 (nsm_oneway_received): Likewise.
2352
2353 * ospf_neighbor.h (struct ospf_neighbor): New structure member
2354 last_send_ts for timestemp when last Database Description packet
2355 was sent.
2356
2357 * ospf_nsm.c (ospf_db_desc_timer): Make it sure nbr->last_send is
2358 there. Call ospf_db_desc_resend() in any case.
2359
23602000-11-16 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2361
2362 * ospf_lsa.c (lsa_link_broadcast_set): When there is no DR on
2363 network (suppose you have only one router with interface priority
2364 0). It's router LSA does not contain the link information about
2365 this network.
2366
2367 * ospf_nsm.c (nsm_timer_set): When you change a priority of
2368 interface from/to 0 ISM_NeighborChange event should be scheduled
2369 in order to elect new DR/BDR on the network.
2370
2371 * ospf_interface.c (ip_ospf_priority): Likewise.
2372
2373 * ospf_flood.c (ospf_ls_retransmit_add): When we add some LSA into
2374 retransmit list we need to check whether the present old LSA in
2375 retransmit list is not more recent than the new
2376 one.
2377
23782000-11-09 Dick Glasspool <dick@ipinfusion.com>
2379
2380 * ospf_packet.c: Allows for NSSA Type-7 LSA's throughout the NSSA
2381 area. Any that exit the NSSA area are translated to type-5 LSA's.
2382 The instantiated image is restored after translation.
2383 (ospf_ls_upd_send_list): Renamed to ospf_ls_upd_queu_send().
2384 (ospf_ls_upd_send): Old function which enclosed by #ifdef 0 is
2385 removed.
2386 (ospf_ls_ack_send): Likewise.
2387
2388 * ospf_flood.c: NSSA-LSA's without P-bit will be restricted to
2389 local area. Otherwise they are allowed out the area to be
2390 translated by ospf_packet.c.
2391
2392 * ospf_lsa.c: Undo some previous changes for NSSA.
2393
2394 * ospf_lsdb.h: New access for type 7.
2395
23962000-11-07 Kunihiro Ishiguro <kunihiro@zebra.org>
2397
2398 * ospf_route.c (ospf_path_exist): New function to check nexthop
2399 and interface are in current OSPF path or not.
2400 (ospf_route_copy_nexthops_from_vertex): Add nexthop to OSPF path
2401 when it is not there. Reported by Michael Rozhavsky
2402 <mrozhavsky@opticalaccess.com>
2403
24042000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2405
2406 * ospf_dump.c (config_write_debug): Add seventh string "detail" is
2407 added for flag is OSPF_DEBUG_SEND | OSPF_DEBUG_RECV |
2408 OSPF_DEBUG_DETAIL.
2409
24102000-11-06 Michael Rozhavsky <mrozhavsky@opticalaccess.com>
2411
2412 * ospf_lsa.c (router_lsa_flags): ASBR can't exit in stub area.
2413
24142000-11-06 Kunihiro Ishiguro <kunihiro@zebra.org>
2415
2416 * ospf_lsa.c (ospf_router_lsa_originate): Reduce unconditional
2417 logging.
2418
24192000-11-06 Dick Glasspool <dick@ipinfusion.com>
2420
2421 * ospfd.h: Add ait_ntoa function prototype.
2422
2423 * ospfd.c (ait_ntoa): New function for displaying area ID and
2424 Stub/NSSA status.
2425 (show_ip_ospf_interface_sub): Use ait_ntoa.
2426 (show_ip_ospf_nbr_static_detail_sub): Likewise.
2427 (show_ip_ospf_neighbor_detail_sub): Likewise.
2428
2429 * ospf_route.c (ospf_intra_route_add): Set external routing type
2430 to ospf route.
2431 (ospf_intra_add_router): Likewise.
2432 (ospf_intra_add_transit): Likewise.
2433 (ospf_intra_add_stub): Likewise.
2434 (ospf_add_discard_route): Likewise.
2435 (show_ip_ospf_route_network): Use ait_ntoa.
2436 (show_ip_ospf_route_network): Likewise.
2437 (show_ip_ospf_route_router): Likewise.
2438
2439 * ospf_lsa.c (show_lsa_detail): Use ait_ntoa.
2440 (show_lsa_detail_adv_router): Likewise.
2441 (show_ip_ospf_database_summary): Likewise.
2442
2443 * ospf_route.h (struct route_standard): Add new member
2444 external_routing.
2445
2446 * ospf_ia.c (process_summary_lsa): Set external routing tyep to ospf
2447 route.
2448 (ospf_update_network_route): Likewise.
2449 (ospf_update_router_route): Likewise.
2450
24512000-11-04 Kunihiro Ishiguro <kunihiro@zebra.org>
2452
2453 * ospf_flood.c (ospf_process_self_originated_lsa): Enclose
2454 OSPF_AS_NSSA_LSA treatment with #ifdef HAVE_NSSA.
2455
24562000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2457
2458 * Unconditional logging is enclosed with if (IS_DEBUG_OSPF_EVENT).
2459 Please specify "debug ospf event" for enable logging.
2460
2461 * ospf_ism.c: Do not extern debug flag varible. It is done by
2462 ospf_debug.h
2463 * ospf_asbr.c: Likewise.
2464 * ospf_lsa.c: Likewise.
2465 * ospf_nsm.c: Likewise.
2466 * ospf_zebra.c: Likewise.
2467
2468 * ospf_dump.c (debug_ospf_event): New command "debug ospf event"
2469 is added.
2470
2471 * ospfd.c (router_ospf): Change logging from vty_out() to
2472 zlog_info().
2473 (ospf_area_stub_cmd): Likewise.
2474
2475 * ospf_dump.h: Extern term_debug flags.
2476 (OSPF_DEBUG_EVENT): Add new flag.
2477 (IS_DEBUG_OSPF_EVENT): Add new macro.
2478
24792000-11-03 Dick Glasspool <dick@ipinfusion.com>
2480
2481 * ospf_flood.c (ospf_process_self_originated_lsa):
2482 OSPF_AS_NSSA_LSA is treated as same as OSPF_AS_EXTERNAL_LSA.
2483 (ospf_flood): Type-5's have no change. Type-7's can be received,
2484 and will Flood the AS as Type-5's They will also flood the local
2485 NSSA Area as Type-7's. The LSDB will be updated as Type-5's, and
2486 during re-fresh will be converted back to Type-7's (if within an
2487 NSSA).
2488 (ospf_flood_through): Incoming Type-7's were allowed here if our
2489 neighbor was an NSSA. So Flood our area with the Type-7 and also
2490 if we are an ABR, flood thru AS as Type-5.
2491
2492 * ospf_lsa.c (ospf_external_lsa_refresh): Flood NSSA both NSSA
2493 area and other area.
2494
2495 * ospf_packet.c (ospf_db_desc_proc): When AS External LSA is
2496 exists in DD packet, make it sure that this area is not stub.
2497 (ospf_ls_upd_list_lsa): When LSA type is NSSA then set lsa's area
2498 to NULL.
2499 (ospf_ls_upd): If the LSA is AS External LSA and the area is stub
2500 then discard the lsa. If the LSA is NSSA LSA and the area is not
2501 NSSA then discard the lsa.
2502
25032000-11-03 Kunihiro Ishiguro <kunihiro@zebra.org>
2504
2505 * ospfd.c (ospf_interface_run): Fix bug of Hello packet's option
2506 is not properly set when interface comes up.
2507
25082000-11-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2509
2510 * ospfd.h (OSPF_OPTION_O): Add new hello header option.
2511
25122000-11-01 Dick Glasspool <dick@ipinfusion.com>
2513
2514 * ospf_lsa.h: Define OSPF_MAX_LSA to 8 when HAVE_NSSA is enabled.
2515 (OSPF_GROUP_MEMBER_LSA): Define OSPF_GROUP_MEMBER_LSA.
2516
2517 * ospf_lsa.c (show_database_desc): Add "Group Membership LSA"
2518 string.
2519
25202000-10-31 Dick Glasspool <dick@ipinfusion.com>
2521
2522 * ospf_lsa.h (OSPF_AS_NSSA_LSA): Define OSPF_AS_NSSA_LSA.
2523
2524 * ospf_lsa.c (show_ip_ospf_database): NSSA database display
2525 function is added. ALIASES which have "show ip ospf database
2526 nssa-external" is added.
2527 (show_ip_ospf_border_routers): New command "show ip ospf
2528 border-routers" is added.
2529
25302000-10-30 Dick Glasspool <dick@ipinfusion.com>
2531
2532 * ospfd.c (router_ospf): NSSA Enabled message is added for
2533 testing.
2534 (ospf_area_type_set): Are type set for NSSA area.
2535 (ospf_area_stub_cmd): Special translation of no_summary into NSSA
2536 and summary information. If NSSA is enabled pass the information
2537 to ospf_area_type_set().
2538 (area_nssa): New commands are added:
2539 "area A.B.C.D nssa"
2540 "area <0-4294967295> nssa"
2541 "area A.B.C.D nssa no-summary"
2542 "area <0-4294967295> nssa no-summary"
2543 (ospf_no_area_stub_cmd): Special translation of no_summary into
2544 NSSA and summary information. If external_routing is
2545 OSPF_AREA_NSSA unset area with ospf_area_type_set (area,
2546 OSPF_AREA_DEFAULT).
2547 (show_ip_ospf_area): Display NSSA status.
2548 (config_write_ospf_area): Show NSSA configuration.
2549
2550 * ospf_packet.c (ospf_hello): For NSSA support, ensure that NP is
2551 on and E is off.
2552
25532000-10-26 Gleb Natapov <gleb@nbase.co.il>
2554
2555 * ospf_lsa.c (ospf_network_lsa_body_set): The network-LSA lists
2556 those routers that are fully adjacent to the Designated Router;
2557 each fully adjacent router is identified by its OSPF Router ID.
2558 The Designated Router includes itself in this list. RFC2328,
2559 Section 12.4.2.
2560
25612000-10-23 Jochen Friedrich <jochen@scram.de>
2562
2563 * ospf_snmp.c: ospf_oid and ospfd_oid are used in smux_open after
2564 it is registered. So those variables must be static.
2565
25662000-10-18 K N Sridhar <sridhar@euler.ece.iisc.ernet.in>
2567
2568 * ospfd.c: Add area_default_cost_decimal_cmd and
2569 no_area_default_cost_decimal_cmd alias.
2570
25712000-10-05 Gleb Natapov <gleb@nbase.co.il>
2572
2573 * ospfd.c (ospf_network_new): Fix setting area format.
2574 (no_router_ospf): Check area existance when calling
2575 ospf_interface_down().
2576
2577 * ospf_flood.c (ospf_external_info_check): Fix bug of refreshing
2578 default route.
2579
25802000-10-02 Kunihiro Ishiguro <kunihiro@zebra.org>
2581
2582 * zebra-0.89 is released.
2583
25842000-09-29 Kunihiro Ishiguro <kunihiro@zebra.org>
2585
2586 * ospf_snmp.c (ospfHostEntry): OSPF Host MIB is implemented.
2587
2588 * ospfd.c (ospf_nbr_static_cmp): OSPF neighbor is sorted by it's
2589 address.
2590
25912000-09-28 Michael Rozhavsky <mike@nbase.co.il>
2592
2593 * ospf_interface.c (ospf_if_free): Fix deleting self neighbor twice.
2594
25952000-09-27 Kunihiro Ishiguro <kunihiro@zebra.org>
2596
2597 * ospf_packet.c (ospf_read): Solaris on x86 has ip_len with host
2598 byte order.
2599
26002000-09-25 Toshiaki Takada <takada@zebra.org>
2601
2602 * ospfd.c (ospf_compatible_rfc1583), (no_ospf_compatible_rfc1583):
2603 Add CISCO compatible command.
2604
26052000-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
2606
2607 * ospf_abr.c (ospf_area_range_lookup): New function is added for
2608 area range lookup in OSPF-MIB.
2609 (ospf_area_range_lookup_next): Likewise.
2610
26112000-09-22 Kunihiro Ishiguro <kunihiro@zebra.org>
2612
2613 * ospfd.c (no_router_ospf): Delete virtual link before deleting
2614 area structure.
2615
2616 * ospf_lsa.c (ospf_external_lsa_refresh_type): Check
2617 EXTERNAL_INFO(type).
2618
2619 * ospfd.c (no_router_ospf): Call ospf_vl_delete() instead of
2620 ospf_vl_data_free().
2621
2622 * ospf_interface.c (ospf_vl_shutdown): Execute ISM_InterfaceDown
2623 when ospf_vl_shutdown is called.
2624 (ospf_vl_delete): Call ospf_vl_shutdown() to delete virtual link
2625 interface's thread.
2626
26272000-09-21 Gleb Natapov <gleb@nbase.co.il>
2628
2629 * ospf_lsa.c: New implementation of OSPF refresh.
2630
26312000-09-20 Kunihiro Ishiguro <kunihiro@zebra.org>
2632
2633 * ospf_snmp.c (ospfLsdbLookup): Add LSDB MIB implementation.
2634
26352000-09-18 Kunihiro Ishiguro <kunihiro@zebra.org>
2636
2637 * ospf_snmp.c (ospfStubAreaEntry): Add OSPF stub area MIB.
2638
26392000-09-18 Gleb Natapov <gleb@nbase.co.il>
2640
2641 * ospf_route.h (route_standard): Change member from `struct area'
2642 to area_id.
2643
2644 * ospf_abr.c (ospf_abr_announce_network), (ospf_abr_should_announce),
2645 (ospf_abr_process_network_rt), (ospf_abr_announce_rtr),
2646 (ospf_abr_process_router_rt):
2647 * ospf_ase.c (ospf_find_asbr_route),
2648 (ospf_find_asbr_router_through_area),
2649 * ospf_ia.c (ospf_find_abr_route), (ospf_ia_router_route),
2650 (process_summary_lsa), (ospf_update_network_route),
2651 (ospf_update_router_route):
2652 * ospf_route.c (ospf_intra_route_add), (ospf_intra_add_router),
2653 (ospf_intra_add_transit), (ospf_intra_add_stub),
2654 (ospf_route_table_dump), (show_ip_ospf_route_network),
2655 (show_ip_ospf_route_router), (ospf_asbr_route_cmp),
2656 (ospf_prune_unreachable_routers):
2657 * ospf_spf.c (ospf_rtrs_print):
2658 * ospfd.c (ospf_rtrs_free): Fix the struct change above.
2659
26602000-09-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2661
2662 * ospf_network.c (ospf_serv_sock_init): Enclose SO_BINDTODEVICE
2663 with ifdef.
2664
26652000-09-13 Gleb Natapov <gleb@nbase.co.il>
2666
2667 * ospf_ism.c (ospf_elect_dr), (ospf_elect_bdr): Fix DR election.
2668
2669 * ospf_network.c (ospf_serv_sock_init): Add socket option
2670 SO_BINDTODEVICE on read socket.
2671
2672 * ospf_packet.c (ospf_hello): Ignore Hello packet if E-bit does
2673 not match.
2674
2675 * ospfd.c (ospf_area_check_free), (ospf_area_get),
2676 (ospf_area_add_if): New function added.
2677
26782000-09-13 Kunihiro Ishiguro <kunihiro@zebra.org>
2679
2680 * ospf_route.c (ospf_intra_add_router): Update ABR and ASBR router
2681 count.
2682
2683 * ospf_spf.c (ospf_spf_init): Rest ABR and ASBR router count
2684 starting SPF calculation.
2685
2686 * ospfd.h (struct ospf_area): Add ABR and ASBR router count.
2687
26882000-09-12 Kunihiro Ishiguro <kunihiro@zebra.org>
2689
2690 * ospfd.c (ospf_area_id_cmp): New area structure is sorted by area
2691 ID.
2692
2693 * ospf_lsa.c (ospf_router_lsa_originate): For OSPF MIB update
2694 lsa_originate_count.
2695 (ospf_network_lsa_originate): Likewise.
2696 (ospf_summary_lsa_originate): Likewise.
2697 (ospf_summary_asbr_lsa_originate): Likewise.
2698 (ospf_external_lsa_originate): Likewise.
2699
27002000-09-11 Kunihiro Ishiguro <kunihiro@zebra.org>
2701
2702 * ospf_snmp.c (ospf_variables): ospfRouterID's type RouterID
2703 syntax is IpAddress.
2704 (ospf_admin_stat): New function for OSPF administrative status
2705 check.
2706
27072000-09-10 Jochen Friedrich <jochen@scram.de>
2708
2709 * ospf_snmp.c: Implement OSPF MIB skeleton.
2710
27112000-09-08 Kunihiro Ishiguro <kunihiro@zebra.org>
2712
2713 * ospf_snmp.c: New file is added.
2714
27152000-09-07 David Lipovkov <davidl@nbase.co.il>
2716
2717 * ospf_zebra.c (ospf_interface_delete): Add pseudo interface
2718 treatment.
2719
2720 * ospf_interface.c (interface_config_write): Likewise.
2721
27222000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2723
2724 * zebra-0.88 is released.
2725
27262000-08-17 Michael Rozhavsky <mike@nbase.co.il>
2727
2728 * ospfd.c (ospf_area_free): Remove virtual link configuration only
2729 when Area is removed.
2730
27312000-08-17 Kunihiro Ishiguro <kunihiro@zebra.org>
2732
2733 * ospfd.c (network_area): Revert check for EXTERNAL_INFO
2734 (ZEBRA_ROUTE_CONNECT).
2735 (no_network_area): Likewise.
2736
27372000-08-16 Kunihiro Ishiguro <kunihiro@zebra.org>
2738
2739 * ospfd.h (struct ospf): Add distance_table and
2740 distance_{all,intra,inter,external}.
2741
2742 * ospf_zebra.c: Add OSPF distance related functions.
2743
27442000-08-15 Gleb Natapov <gleb@nbase.co.il>
2745
2746 * ospf_asbr.c (ospf_external_info_find_lsa): New function added.
2747
2748 * ospf_lsa.c (ospf_default_external_info),
2749 (ospf_default_originate_timer), (ospf_external_lsa_refresh_default):
2750 New function added.
2751
2752 * ospf_zebra.c
2753 (ospf_default_information_originate_metric_type_routemap),
2754 (ospf_default_information_originate_always_metric_type_routemap):
2755 Change name and add route-map function.
2756 (ospf_default_information_originate_metric_routemap),
2757 (ospf_default_information_originate_routemap),
2758 (ospf_default_information_originate_type_metric_routemap):
2759 New DEFUN added.
2760
27612000-08-14 Kunihiro Ishiguro <kunihiro@zebra.org>
2762
2763 * ospf_zebra.c (zebra_interface_if_set_value): Change ifindex
2764 restore size from two octet to four.
2765
27662000-08-14 Michael Rozhavsky <mike@nbase.co.il>
2767
2768 * ospf_ase.c (ospf_ase_incremental_update): Implement incremental
2769 AS-external-LSA in 16.6 of RFC2328.
2770
27712000-08-14 Matthew Grant <grantma@anathoth.gen.nz>
2772
2773 * ospf_interface.c (ospf_if_get_output_cost): Change cost
2774 calculation algorithm.
2775
2776 * ospf_packet (ospf_ls_upd): Fix problem of LSA retransmitting.
2777
27782000-08-11 Michael Rozhavsky <mike@nbase.co.il>
2779
2780 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix maxage remover for
2781 AS-external-LSAs.
2782
27832000-08-10 Toshiaki Takada <takada@zebra.org>
2784
2785 * ospfd.c (auto_cost_reference_bandwidth): New DEFUN added.
2786 `auto-cost reference-bandwidth' OSPF router command added.
2787
27882000-08-08 Gleb Natapov <gleb@nbase.co.il>
2789
2790 * ospf_routemap.c (ospf_route_map_update): New function added.
2791 Add route-map event hook.
2792
27932000-08-08 Toshiaki Takada <takada@zebra.org>
2794
2795 * ospf_zebra.c (ospf_distribute_check_connected): If redistribute
2796 prefix is connected route on OSPF enabled interface, suppress to
2797 announce it.
2798
27992000-08-08 Matthew Grant <grantma@anathoth.gen.nz>
2800
2801 * ospf_interface.c (ospf_if_get_output_cost):
2802 New function added. Handle bandwidth parameter for cost
2803 calculation.
2804
28052000-08-08 Michael Rozhavsky <mike@nbase.co.il>
2806
2807 * ospf_interface.c (interface_config_write): Show interface
2808 configuration regardless interface is down.
2809
2810 * ospf_ase.c (ospf_ase_caocluate_route): Whole rewritten external
2811 route calculate function.
2812
28132000-08-08 Gleb Natapov <gleb@nbase.co.il>
2814
2815 * ospf_routemap.c: New file added.
2816
2817 * ospf_asbr.c (ospf_reset_route_map_set_values),
2818 (ospf_route_map_set_compare): New function added.
2819
2820 * ospf_lsa.c (ospf_external_lsa_body_set): Set routemap metric
2821 with AS-external-LSA.
2822
28232000-08-05 Kunihiro Ishiguro <kunihiro@zebra.org>
2824
2825 * ospf_ase.c (ospf_ase_calculate_route_add): Pass new->cost to
2826 ospf_zebra_add as metric.
2827 (ospf_ase_calculate_route_add): Likewise.
2828
2829 * ospf_route.c (ospf_route_install): Pass or->cost to
2830 ospf_zebra_add as metric.
2831
2832 * ospf_zebra.c (ospf_zebra_add): Add metric arguemnt.
2833 (ospf_zebra_delete): Likewise.
2834
28352000-08-03 Matthew Grant <grantma@anathoth.gen.nz>
2836
2837 * ospf_flood.c (ospf_flood_delayed_lsa_ack): New function added.
2838 Dispatch delayed-ACK with flooding AS-external-LSA across virtual
2839 link.
2840
28412000-07-31 Matthew Grant <grantma@anathoth.gen.nz>
2842
2843 * ospfd.c (show_ip_ospf_area): Fix lack of VTY_NEWLINE when
2844 `show ip ospf'.
2845
2846 * ospf_interface.c (ospf_if_free): Fix bug of crash with
2847 Point-to-Point interface.
2848
28492000-07-27 Michael Rozhavsky <mike@nbase.co.il>
2850
2851 * ospf_flood.c (ospf_process_self_originated_lsa):
2852 Make sure to clear LSA->param (redistributed external information)
2853 before refreshment.
2854
28552000-07-27 Gleb Natapov <gleb@nbase.co.il>
2856
2857 * ospfd.c (refresh_group_limit), (refresh_per_slice),
2858 (refresh_age_diff): New defun added. Refresher related parameter
2859 can be configurable.
2860
28612000-07-27 Akihiro Mizutani <mizutani@dml.com>
2862
2863 * ospf_interface.c (interface_config_write): Print `description'
2864 config directive to work.
2865
28662000-07-24 Akihiro Mizutani <mizutani@dml.com>
2867
2868 * ospf_interface.c (ospf_if_init): Use install_default for
2869 INTERFACE_NODE.
2870
28712000-07-24 Gleb Natapov <gleb@nbase.co.il>
2872
2873 * ospf_packet.c (ospf_ls_upd_send_list), (ospf_ls_upd_send_event),
2874 (ospf_ls_ack_send_list), (ospf_ls_ack_send_event): New function added.
2875 This make sending always as many LS update/Ack combined in one ospf
2876 packet.
2877
28782000-07-24 Gleb Natapov <gleb@nbase.co.il>
2879
2880 * ospf_packet.c (ospf_ls_upd_list_lsa): Set NULL to lsa->area if
2881 LSA is AS-external-LSA.
2882
2883 * ospf_nsm.c (nsm_reset_nbr): Do not cancel Inactivity timer.
2884
28852000-07-21 Toshiaki Takada <takada@zebra.org>
2886
2887 * ospf_zebra.c (ospf_default_originate_timer): Set timer for
2888 `default-information originate'. Fix some default originate
2889 related functions.
2890
28912000-07-12 Toshiaki Takada <takada@zebra.org>
2892
2893 * ospf_lsa.c (stream_put_ospf_metric): New function added.
2894
28952000-07-12 Toshiaki Takada <takada@zebra.org>
2896
2897 * ospf_lsa.c (show_ip_ospf_database_router),
2898 (show_ip_ospf_database_network), (show_ip_ospf_database_summary),
2899 (show_ip_ospf_database_summary_asbr), (show_ip_ospf_database_externel),
2900 (show_router_lsa), (show_any_lsa), (show_router_lsa_self),
2901 (show_any_lsa_self): Functions removed.
2902
2903 (show_lsa_prefix_set), (show_lsa_detail_proc), (show_lsa_detail),
2904 (show_lsa_detail_adv_router_proc), (show_lsa_detail_adv_router):
2905 New functions added. Replace above functions.
2906
2907 (show_ip_ospf_database_all), (show_ip_ospf_database_self_originated):
2908 Functions removed.
2909 (show_ip_ospf_database_summary): New functions added. Replace
2910 above functions.
2911
2912 (show_ip_ospf_database_cmd): DEFUN rearranged.
2913 (show_ip_ospf_database_type_id_cmd),
2914 (show_ip_ospf_database_type_id_adv_router_cmd),
2915 (show_ip_ospf_database_type_is_self_cmd): New ALIASes added.
2916 (show_ip_ospf_database_type_adv_rotuer_cmd): New DEFUN added.
2917 (show_ip_ospf_database_type_self_cmd): New ALIAS added.
2918
29192000-07-11 Toshiaki Takada <takada@zebra.org>
2920
2921 * ospf_asbr.c (ospf_external_info_new),
2922 (ospf_external_info_free): New functions added.
2923
2924 * ospf_lsa.h (ospf_lsa): Add new member `void *param' to set
2925 origination parameter for external-LSA.
2926 Remove member `redistribute'.
2927
2928 * ospf_zebra.c (ospf_redistirbute_set): When `redistribute'
2929 command executed, metric and metric-type values are overridden.
2930 If one of those is changed refresh AS-external-LSAs for appropriate
2931 type.
2932
29332000-07-11 Michael Rozhavsky <mike@nbase.co.il>
2934
2935 * ospf_lsa.c (ospf_summary_lsa_refresh),
2936 (ospf_summary_asbr_lsa_refresh): Make sure to refresh summary-LSAs.
2937
2938 * ospf_abr.c (set_metric): New function added.
2939
29402000-07-07 Toshiaki Takada <takada@zebra.org>
2941
2942 * ospf_zebra.c (ospf_default_information_originate_metric_type),
2943 (ospf_default_information_originate_type_metric): New defun added.
2944 Metic and Metric type can be set to default route.
2945 (ospf_default_information_originate_always_metric_type):
2946 (ospf_default_information_originate_always_type_metric):
2947 New defun added. Metric and Metric type can be set to default
2948 always route.
2949
2950 * ospf_zebra.c (ospf_default_metric), (no_ospf_default_metric):
2951 New defun added.
2952
29532000-07-06 Gleb Natapov <gleb@nbase.co.il>
2954
2955 * ospf_flood.c (ospf_flood_through_area): Fix bug of considering
2956 on the same interface the LSA was received from.
2957
29582000-07-06 Michael Rozhavsky <mike@nbase.co.il>
2959
2960 * ospfd.c (ospf_config_write): Fix bug of printing `area stub'
2961 command with `write mem'.
2962
2963 * ospfd.c (no_router_ospf): Remove installed routes from zebra.
2964
2965 * ospf_zebra.c (ospf_interface_delete): Fix function to handle
2966 zebra interface delete event.
2967
29682000-07-06 Toshiaki Takada <takada@zebra.org>
2969
2970 * ospf_zebra.c (ospf_default_information_originate),
2971 (ospf_default_information_originate_always): New DEFUN added.
2972
29732000-07-05 Michael Rozhavsky <mike@nbase.co.il>
2974
2975 * ospf_route.c (ospf_terminate): Make sure to remove external route
2976 when SIGINT received.
2977
29782000-07-03 Gleb Natapov <gleb@nbase.co.il>
2979
2980 * ospf_flood.c, ospf_ism.c, ospf_lsa,c, ospfd.c: Make sure to free
2981 many structure with `no router ospf'.
2982
29832000-06-30 Gleb Natapov <gleb@nbase.co.il>
2984
2985 * ospf_neighbor.c (ospf_nbr_new),
2986 ospf_nsm.c (nsm_timer_set): Start LS update timer only
2987 when neighbor enters Exchange state.
2988
29892000-06-29 Gleb Natapov <gleb@nbase.co.il>
2990
2991 * ospf_nsm.c (nsm_timer_set), (nsm_exchange_done),
2992 ospf_packet.c (ospf_db_desc_proc):
2993 Do not cancel DD retransmit timer when Master.
2994
29952000-06-29 Gleb Natapov <gleb@nbase.co.il>
2996
2997 * ospf_abr.c (ospf_abr_announce_network_to_area),
2998 (ospf_abr_announce_rtr_to_area)
2999 ospf_ase.c (ospf_ase_rtrs_register_lsa),
3000 ospf_flood.c (ospf_process_self_originated_lsa),
3001 (ospf_flood_through_area), (ospf_ls_request_delete),
3002 ospf_interface.c (ospf_if_free),
3003 ospf_ism.c (ism_change_status),
3004 ospf_lsa.c (ospf_router_lsa_update_timer),
3005 (ospf_router_lsa_install), (ospf_network_lsa_install),
3006 (ospf_lsa_maxage_delete), (ospf_lsa_action),
3007 (ospf_schedule_lsa_flood_area),
3008 ospf_nsm.c (nsm_change_status),
3009 ospf_packet.c (ospf_make_ls_req_func), (ospf_make_ls_ack):
3010 Use ospf_lsa_{lock,unlock} for all looking-up of LSA.
3011
3012 * ospf_flood.c (ospf_ls_request_free): Function deleted.
3013
3014 * ospf_lsa.c (ospf_discard_from_db): New function added.
3015
30162000-06-26 Toshiaki Takada <takada@zebra.org>
3017
3018 * ospfd.h (ospf): struct member `external_lsa' name changed to
3019 `lsdb'.
3020
30212000-06-26 Toshiaki Takada <takada@zebra.org>
3022
3023 * ospf_lsa.c (ospf_lsa_install), (ospf_router_lsa_install),
3024 (ospf_network_lsa_install), (ospf_summary_lsa_install),
3025 (ospf_summary_asbr_lsa_install), (ospf_external_lsa_install):
3026 Functions re-arranged.
3027
3028 * ospf_lsa.c (IS_LSA_MAXAGE), (IS_LSA_SELF): Macro added.
3029
30302000-06-20 Michael Rozhavsky <mike@nbase.co.il>
3031
3032 * ospf_packet.c (ospf_ls_req), (ospf_ls_upd), (ospf_ls_ack): Add
3033 verification of LS type.
3034
30352000-06-20 Gleb Natapov <gleb@nbase.co.il>
3036
3037 * ospf_ase.c (ospf_ase_calculate_timer): Add more sanity check
3038 whether rn->info is NULL.
3039
30402000-06-20 Toshiaki Takada <takada@zebra.org>
3041
3042 * ospfd.c (show_ip_ospf_interface_sub): Show Router-ID of both
3043 DR and Backup correctly with `show ip ospf interface' command.
3044
30452000-06-20 Toshiaki Takada <takada@zebra.org>
3046
3047 * ospf_lsa.c (ospf_lsa_lock), (ospf_lsa_unlock),
3048 (ospf_lsa_discard): These functions are used for avoiding
3049 unexpected reference to freed LSAs.
3050
30512000-06-13 Kunihiro Ishiguro <kunihiro@zebra.org>
3052
3053 * ospf_packet.c (ospf_ls_upd): Initialize lsa by NULL to avoid
3054 warning.
3055
30562000-06-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3057
3058 * ospf_ase.h (ospf_ase_rtrs_register_lsa): Add prototype.
3059
30602000-06-12 Toshiaki Takada <takada@zebra.org>
3061
3062 * ospf_lsa.c (ospf_external_lsa_install): Make sure to register
3063 LSA to rtrs_external when replacing AS-external-LSAs in LSDB.
3064 Fix core dump.
3065
30662000-06-10 Toshiaki Takada <takada@zebra.org>
3067
3068 * ospf_lsdb.c (id_to_prefix), (ospf_lsdb_hash_key),
3069 (ospf_lsdb_hash_cmp), (ospf_lsdb_new), (ospf_lsdb_iterator),
3070 (lsdb_free), (ospf_lsdb_free), (ospf_lsdb_add), (ospf_lsdb_delete),
3071 (find_lsa), (ospf_lsdb_lookup), (find_by_id),
3072 (ospf_lsdb_lookup_by_id), (ospf_lsdb_lookup_by_header): Functinos
3073 removed for migration to new_lsdb.
3074
3075 * ospf_lsa.c (ospf_summary_lsa_install),
3076 (ospf_summary_asbr_lsa_install), (ospf_maxage_lsa_remover),
3077 (ospf_lsa_maxage_walker), (ospf_lsa_lookup),
3078 (ospf_lsa_lookup_by_id): Use new_lsdb instead of ospf_lsdb.
3079 (count_lsa), (ospf_lsa_count_table), (ospf_lsa_count),
3080 (ospf_get_free_id_for_prefix): Funcitions removed.
3081
30822000-06-09 Gleb Natapov <gleb@nbase.co.il>
3083
3084 * ospf_ism.c (ism_interface_down): Prevent some unneeded DR changes.
3085
3086 * ospf_packet.c (ospf_db_desc_proc): Fix memory leak.
3087 (ospf_hello): Always copy router-ID when hello is received.
3088
30892000-06-08 Gleb Natapov <gleb@nbase.co.il>
3090
3091 * ospf_lsa.h (struct ospf_lsa): Add member of pointer to struct
3092 ospf_area.
3093
30942000-06-08 Michael Rozhavsky <mike@nbase.co.il>
3095
3096 * ospf_ase.c (ospf_asbr_route_same): New function added.
3097 This function makes sure external route calculation more
3098 precisely.
3099
31002000-06-07 Michael Rozhavsky <mike@nbase.co.il>
3101
3102 * ospf_ism.c (ism_change_status): Use ospf_lsa_flush_area for
3103 network-LSA deletion instead of using ospf_lsdb_delete.
3104 Also cancel network-LSA origination timer.
3105
31062000-06-07 Levi Harper <lharper@kennedytech.com>
3107
3108 * ospf_interface.c (ospf_if_down): Close read fd when an interface
3109 goes down.
3110
31112000-06-05 Kunihiro Ishiguro <kunihiro@zebra.org>
3112
3113 * ospf_asbr.c (ospf_external_info_lookup): Add explicit brace for
3114 avoid ambiguous else.
3115
3116 * ospf_flood.c (ospf_external_info_check): Likewise.
3117
31182000-06-05 Toshiaki Takada <takada@zebra.org>
3119
3120 * ospf_nsm.c (nsm_adj_ok): Fix bug of DR election.
3121
31222000-06-04 Toshiaki Takada <takada@zebra.org>
3123
3124 * ospf_zebra.c (ospf_default_information_originate),
3125 (no_ospf_default_information_originate): New DEFUN added.
3126
31272000-06-03 Toshiaki Takada <takada@zebra.org>
3128
3129 * ospf_lsa.h, ospf_asbr.h (external_info): Struct moved from
3130 ospf_lsa.h to ospf_asbr.h.
3131
3132 * ospf_lsa.c, ospf_asbr.c (ospf_external_info_add),
3133 (ospf_external_info_delete): Function moved from ospf_lsa.c
3134 to ospf_asbr.c.
3135
31362000-06-03 Toshiaki Takada <takada@zebra.org>
3137
3138 * ospf_flood.c (ospf_external_info_check): New function added.
3139 (ospf_process_self_orignated_lsa): Make sure to flush
3140 self-originated AS-external-LSA, when router reboot and no longer
3141 originate those AS-external-LSA.
3142
31432000-06-02 Toshiaki Takada <takada@zebra.org>
3144
3145 * ospf_network.c (ospf_serv_sock): Remove SO_DONTROUTE
3146 socket option.
3147
3148 * ospf_packet.c (ospf_write): Set MSG_DONTROUTE flag for
3149 unicast destination packets.
3150
31512000-06-02 Toshiaki Takada <takada@zebra.org>
3152
3153 * ospf_lsdb.c (new_lsdb_delete): Delete entry from LSDB only when
3154 specified LSA matches.
3155
31562000-06-02 Gleb Natapov <gleb@nbase.co.il>
3157
3158 * ospf_network.c (ospf_serv_sock): Set SO_DONTROUTE
3159 socket option.
3160
31612000-06-01 Akihiro Mizutani <mizutani@dml.com>
3162
3163 * ospf_dump.c: Replace string `Debugging functions\n' with DEBUG_STR.
3164 Replace string `OSPF information\n' with OSPF_STR.
3165
31662000-06-01 Toshiaki Takada <takada@zebra.org>
3167
3168 * ospf_lsdb.[ch]: Use new_lsdb struct for network-LSA instead of
3169 ospf_lsdb.
3170
31712000-06-01 Toshiaki Takada <takada@zebra.org>
3172
3173 * ospf_dump.c (config_debug_ospf_packet), (config_debug_ospf_event),
3174 (config_debug_ospf_ism), (config_debug_ospf_nsm),
3175 (config_debug_ospf_lsa), (config_debug_ospf_zebra),
3176 (term_debug_ospf_packet), (term_debug_ospf_event),
3177 (term_debug_ospf_ism), (term_debug_ospf_nsm),
3178 (term_debug_ospf_lsa), (term_debug_ospf_zebra): Repalce debug_ospf_*
3179 variable to use for debug option flags.
3180
3181 (debug_ospf_packet), (debug_ospf_ism), (debug_ospf_nsm),
3182 (debug_ospf_lsa), (debug_ospf_zebra): Set {config,term}_debug_*
3183 flags when vty->node is CONFIG_NODE, otherwise set only term_debug_*
3184 flags.
3185
3186 * ospf_dump.h (CONF_DEBUG_PACKET_ON), (CONF_DEBUG_PACKET_OFF),
3187 (TERM_DEBUG_PACKET_ON), (TERM_DEBUG_PACKET_OFF),
3188 (CONF_DEBUG_ON), (CONF_DEBUG_OFF), (IS_CONF_DEBUG_OSPF_PACKET),
3189 (IS_CONF_DEBUG_OSPF): New Macro added.
3190
31912000-05-31 Toshiaki Takada <takada@zebra.org>
3192
3193 * ospfd.c (clear_ip_ospf_neighbor): New DEFUN added.
3194 Currently this command is used for only debugging.
3195
3196 * ospf_nsm.c (nsm_change_status): Make sure thread cancellation
3197 for network-LSA when DR has no full neighbors.
3198
3199 * ospf_nsm.c (ospf_db_summary_clear): New function added.
3200
32012000-05-30 Toshiaki Takada <takada@zebra.org>
3202
3203 * ospf_lsdb.c (new_lsdb_insert): LSAs are always freed by
3204 maxage_lsa_remover when LSA is replaced.
3205
32062000-05-25 Gleb Natapov <gleb@nbase.co.il>
3207
3208 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all): Add argument
3209 `struct ospf_area' to remove LSA from Link State retransmission list
3210 of neighbor from only one Area.
3211
32122000-05-24 Michael Rozhavsky <mike@nbase.co.il>
3213
3214 * ospf_lsdb.c (ospf_lsdb_add): Preserve flags field when
3215 overriting old LSA with new LSA.
3216
32172000-05-24 Gleb Natapov <gleb@nbase.co.il>
3218
3219 * ospf_lsa.c (ospf_router_lsa_body_set): Fix bug of router-LSA
3220 size calculation.
3221
32222000-05-22 Michael Rozhavsky <mike@nbase.co.il>
3223
3224 * ospf_route.c (ospf_intra_add_stub):
3225 * ospf_spf.h (struct vertex): Use u_int32_t for distance (cost)
3226 value instead of u_int16_t.
3227
32282000-05-22 Axel Gerlach <agerlach@datus.datus.com>
3229
3230 * ospf_ia.c (ospf_ia_network_route): Fix bug of Inter-area route
3231 equal cost path calculation.
3232
32332000-05-21 Toshiaki Takada <takada@zebra.org>
3234
3235 * ospf_ase.c (ospf_ase_calculate_route_delete): New function added.
3236 Make sure, when rotuer route is deleted, related external routes
3237 are also deleted.
3238
32392000-05-20 Toshiaki Takada <takada@zebra.org>
3240
3241 * ospfd.c (ospf_interface_down): Make sure interface flag is disable
3242 and set fd to -1.
3243
32442000-05-16 Toshiaki Takada <takada@zebra.org>
3245
3246 * ospf_asbr.c (ospf_asbr_should_announce), (ospf_asbr_route_remove):
3247 Functions removed.
3248
3249 * ospfd.h (EXTERNAL_INFO): Macro added.
3250 Substitute `ospf_top->external_info[type]' with it.
3251
32522000-05-16 Toshiaki Takada <takada@zebra.org>
3253
3254 * ospf_lsa.c (ospf_rtrs_external_remove): New function added.
3255
32562000-05-14 Gleb Natapov <gleb@nbase.co.il>
3257
3258 * ospf_flood.c (ospf_ls_retransmit_delete_nbr_all)
3259 * ospf_lsdb.c (new_lsdb_insert)
3260 * ospf_packet.c (ospf_ls_ack): Fix database synchonization problem.
3261
32622000-05-14 Gleb Natapov <gleb@nbase.co.il>
3263
3264 * ospf_lsa.h (tv_adjust), (tv_ceil), (tv_floor), (int2tv),
3265 (tv_add), (tv_sub), (tv_cmp): Prototype definition added.
3266
3267 * ospf_nsm.h (ospf_db_summary_delete_all): Prototype definition added.
3268
32692000-05-13 Toshiaki Takada <takada@zebra.org>
3270
3271 * ospf_lsa.[ch] (ospf_lsa): struct timestamp type is changed from
3272 time_t to struct timeval.
3273 (tv_adjust), (tv_ceil), (tv_floor), (int2tv), (tv_add),
3274 (tv_sub), (tv_cmp): timeval utillity functions added.
3275
32762000-05-12 Toshiaki Takada <takada@zebra.org>
3277
3278 * ospf_lsa.[ch] (ospf_schedule_update_router_lsas): Delete function.
3279 Change to use macro OSPF_LSA_UPDATE_TIMER instead of using
3280 this function.
3281 router-LSA refresh timer related stuff is re-organized.
3282
32832000-05-10 Gleb Natapov <gleb@nbase.co.il>
3284
3285 * ospf_interface.c (ospf_vl_set_params):
3286 * ospf_packet.c (ospf_check_network_mask):
3287 * ospf_spf.[ch] (ospf_spf_next):
3288 Remove field address from `struct vertex', and search for peer
3289 address of virtual link in function `ospf_vl_set_params' instead.
3290
32912000-05-10 Gleb Natapov <gleb@nbase.co.il>
3292
3293 * ospf_packet.c (ospf_ls_upd): Fix some memory leak related LSA.
3294
32952000-05-08 Thomas Molkenbur <tmo@datus.com>
3296
3297 * ospf_packet.c (ospf_packet_dup): Replace ospf_steram_copy()
3298 with ospf_stream_dup() to fix memory leak.
3299
33002000-05-08 Michael Rozhavsky <mike@nbase.co.il>
3301
3302 * ospf_flood.c (ospf_flood_through_area): Fix the problem of
3303 LSA update without DROther.
3304
33052000-05-04 Gleb Natapov <gleb@nbase.co.il>
3306
3307 * ospf_spf.c (ospf_vertex_free): Fix memory leak of SPF calculation.
3308
33092000-05-03 Toshiaki Takada <takada@zebra.org>
3310
3311 * ospf_neighbor.c (ospf_db_summary_add): Use new_lsdb struct
3312 instead linked-list.
3313 (ospf_db_summary_count), (ospf_db_summary_isempty):
3314 New function added.
3315
3316 * ospf_lsa.c (ospf_rotuer_lsa): Re-arrange and divide functions.
3317
33182000-05-02 Gleb Natapov <gleb@nbase.co.il>
3319
3320 * ospf_lsdb.c (new_lsdb_cleanup): Fix memory leak. When LSDB are
3321 not needed any more, then free them.
3322
33232000-05-02 Toshiaki Takada <takada@zebra.org>
3324
3325 * ospfd.c (timers_spf), (no_timers_spf): New defun added.
3326 SPF calculation timers related stuff is rearranged.
3327
3328 * ospf_spf.c (ospf_spf_calculate_timer_add): Function removed.
3329 SPF timer is scheduled by SPF calculation delay and holdtime
3330 configuration variable.
3331
3332 * ospf_lsa.c (ospf_external_lsa_nexthop_get): Set AS-external-LSA's
3333 forwarding address when nexthop learned by other protocols is
3334 in the OSPF domain.
3335
3336 * ospf_zebra.c (ospf_redistribute_source_metric_type),
3337 (ospf_redistribute_source_type_metric): Re-arrange DEFUNs and
3338 ALIASes.
3339
33402000-05-01 Toshiaki Takada <takada@zebra.org>
3341
3342 * ospf_flood.c (ospf_ls_retransmit_count),
3343 (ospf_ls_retransmit_isempty): New function added.
3344
3345 (ospf_ls_retransmit_add), (ospf_ls_retransmit_delete),
3346 (ospf_ls_retransmit_clear), (ospf_ls_retransmit_lookup),
3347 (ospf_ls_retransmit_delete_all), (ospf_ls_retransmit_delete_nbr_all),
3348 (ospf_ls_retransmit_add_nbr_all): Replace these functions to use
3349 new_lsdb.
3350
33512000-04-29 Toshiaki Takada <takada@zebra.org>
3352
3353 * ospfd.c (no_network_area): Add check Area-ID whether specified
3354 Area-ID with prefix matches config.
3355
33562000-04-27 Toshiaki Takada <takada@zebra.org>
3357
3358 * ospf_lsa.c (ospf_maxage_lsa_remover): Fix problem of
3359 remaining withdrawn routes on zebra.
3360
33612000-04-25 Michael Rozhavsky <mike@nbase.co.il>
3362
3363 * ospf_nsm.c (nsm_kill_nbr), (nsm_ll_down), (nsm_change_status),
3364 (ospf_nsm_event): Fix network-LSA re-origination problem.
3365
33662000-04-24 Toshiaki Takada <takada@zebra.org>
3367
3368 * ospf_nsm.c (ospf_db_desc_timer): Fix bug of segmentation fault
3369 with DD retransmission.
3370
3371 * ospf_nsm.c (nsm_kill_nbr): Fix bug of re-origination when
3372 a neighbor disappears.
3373
33742000-04-23 Michael Rozhavsky <mike@nbase.co.il>
3375
3376 * ospf_abr.c (ospf_abr_announce_network_to_area): Fix bug of
3377 summary-LSAs reorigination. Correctly copy OSPF_LSA_APPROVED
3378 flag to new LSA. when summary-LSA is reoriginatd.
3379
3380 * ospf_flood.c (ospf_flood_through_area): Fix bug of flooding
3381 procedure. Change the condition of interface selection.
3382
33832000-04-21 Toshiaki Takada <takada@zebra.org>
3384
3385 * ospf_lsa.c (ospf_refresher_register_lsa): Fix bug of refresh never
3386 occurs.
3387
3388 * ospfd.c (show_ip_ospf_neighbor_id): New defun added.
3389 `show ip ospf neighbor' related commands are re-arranged.
3390
33912000-04-20 Toshiaki Takada <takada@zebra.org>
3392
3393 * ospf_dump.c (debug_ospf_zebra): New defun added.
3394 Suppress zebra related debug information.
3395
33962000-04-19 Toshiaki Takada <takada@zebra.org>
3397
3398 * ospf_zebra.c (ospf_distribute_list_update_timer),
3399 (ospf_distribute_list_update), (ospf_filter_update):
3400 New function added. Re-organize `distribute-list' router ospf
3401 command.
3402
34032000-04-13 Michael Rozhavsky <mike@nbase.co.il>
3404
3405 * ospf_packet.c (ospf_make_ls_upd): Add check for MAX_AGE.
3406
34072000-04-14 Michael Rozhavsky <mike@nbase.co.il>
3408
3409 * ospf_packet.c (ospf_make_ls_upd): Increment LS age by configured
3410 interface transmit_delay.
3411
34122000-04-14 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3413
3414 * ospf_interface.c (ip_ospf_cost), (no_ip_ospf_cost):
3415 Add to schedule router_lsa origination when the interface cost changes.
3416
34172000-04-12 Toshiaki Takada <takada@zebra.org>
3418
3419 * ospf_lsa.c (ospf_refresher_register_lsa),
3420 (ospf_refresher_unregister_lsa): Fix bug of core dumped.
3421
3422 * ospfd.c (no_router_ospf): Fix bug of core dumped.
3423
34242000-03-29 Toshiaki Takada <takada@zebra.org>
3425
3426 * ospf_nsm.c (nsm_oneway_received): Fix bug of MS flag unset.
3427
34282000-03-29 Michael Rozhavsky <mike@nbase.co.il>
3429
3430 * ospf_lsa.c (ospf_network_lsa):
3431 * ospf_nsm.c (ospf_nsm_event): Fix bug of Network-LSA originated
3432 in stub network.
3433
34342000-03-28 Toshiaki Takada <takada@zebra.org>
3435
3436 * ospf_nsm.c (nsm_bad_ls_req), (nsm_seq_number_mismatch),
3437 (nsm_oneway_received): Fix bug of NSM state flapping between
3438 ExStart and Exchange.
3439
34402000-03-28 Toshiaki Takada <takada@zebra.org>
3441
3442 * ospf_packet.h (strcut ospf_header): Fix the size of ospf_header,
3443 change u_int8_t to u_char.
3444
34452000-03-27 Toshiaki Takada <takada@zebra.org>
3446
3447 * ospf_lsa.c (ospf_lsa_checksum): Take care of BIGENDIAN architecture.
3448
34492000-03-27 Toshiaki Takada <takada@zebra.org>
3450
3451 * ospfd.c (ospf_interface_run): Make sure Address family matches.
3452
34532000-03-26 Love <lha@s3.kth.se>
3454
3455 * ospf_packet.c (ospf_write): Chack result of sendto().
3456
34572000-03-26 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3458
3459 * ospf_nsm.c (nsm_oneway_received): Fix bug of 1-WayReceived in NSM.
3460
34612000-03-23 Libor Pechacek <farco@clnet.cz>
3462
3463 * ospf_lsa.c (ospf_network_lsa)
3464 * ospf_lsdb.c (new_lsdb_insert): Fix bug of accessing to
3465 unallocated memory.
3466
34672000-03-23 Toshiaki Takada <takada@zebra.org>
3468
3469 * ospfd.c (ospf_config_write): Fix bug of duplicate line for
3470 `area A.B.C.D authentication'.
3471
34722000-03-22 Toshiaki Takada <takada@zebra.org>
3473
3474 * ospf_debug.c (debug_ospf_lsa), (no_debug_ospf_lsa): Defun added.
3475 Suppress all zlog related to LSAs with this config option.
3476
34772000-03-21 Kunihiro Ishiguro <kunihiro@zebra.org>
3478
3479 * ospf_nsm.c (ospf_nsm_event): Add check for NSM_InactivityTimer.
3480
34812000-03-21 Toshiaki Takada <takada@zebra.org>
3482
3483 * ospf_packet.c (ospf_ls_upd_timer), (ospf_ls_req):
3484 Fix bug of memory leak about linklist.
3485
3486 * ospf_flood.c (ospf_flood_through_area): Likewise.
3487
34882000-03-18 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3489
3490 * ospf_flood.c (ospf_ls_retransmit_lookup): Add checksum comparison
3491 to identify LSA uniquely. This fix routes lost.
3492
34932000-03-18 Toshiaki Takada <takada@zebra.org>
3494
3495 * ospf_ase.c (ospf_find_asbr_route): Add sanity check with router
3496 routing table.
3497
34982000-03-17 Alex Zinin <zinin@amt.ru>
3499
3500 * ospf_spf.[ch]: Bug fix.
3501 The 2nd stage of Dijkstra could consider one vertex
3502 more than once if there is more than one link
3503 between the routers, thus adding extra CPU overhead
3504 and extra next-hops.
3505 Fixed.
3506
35072000-03-15 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3508
3509 * ospf_nsm.c (nsm_inactivity_timer): Changed to call nsm_kill_nbr().
3510
35112000-03-14 Toshiaki Takada <takada@zebra.org>
3512
3513 * ospf_route.c (ospf_route_copy_nexthops): Fix bug of memory leak of
3514 ospf_path. Actually ignore merging ospf_route with completely same
3515 paths.
3516
35172000-03-12 Toshiaki Takada <takada@zebra.org>
3518
3519 * ospf_lsa.c (show_as_external_lsa_detail): fix bug of
3520 external route tag byte order.
3521
35222000-03-11 Toshiaki Takada <takada@zebra.org>
3523
3524 * ospf_lsdb.c (ospf_lsdb_insert): New function added.
3525
35262000-03-09 Toshiaki Takada <takada@zebra.org>
3527
3528 * ospf_lsa.c (ospf_external_lsa_install),
3529 (ospf_lsa_lookup), (show_ip_ospf_database_all),
3530 (show_ip_ospf_database_self_originate): Use struct new_lsdb for
3531 LSDB of AS-external-LSAs instead of ospf_lsdb.
3532
3533 * ospf_lsa.c (ospf_lsa_unique_id): New function added.
3534 Use for assigning Unique Link State ID instead of
3535 ospf_get_free_id_for_prefix().
3536
35372000-03-09 Toshiaki Takada <takada@zebra.org>
3538
3539 * ospf_ase.c (ospf_ase_calculate_timer): Fix bug of segmentation
3540 fault reported by George Bonser <george@siteROCK.com>.
3541
35422000-03-07 Libor Pechacek <farco@clnet.cz>
3543
3544 * ospfd.c (ospf_interface_down): Fix bug of segmentation fault.
3545
35462000-03-06 Toshiaki Takada <takada@zebra.org>
3547
3548 * ospf_route.c (ospf_route_cmp): Change meaning of return values.
3549
35502000-03-02 Alex Zinin <zinin@amt.ru>
3551 * ospfd.h, ospf_ia.h
3552 New Shortcut ABR code. Now area's flag can be configured
3553 with Default, Enable, and Disable values.
3554 More info will be in the new ver of I-D soon (see IETF web).
3555
35562000-02-25 Toshiaki Takada <takada@zebra.org>
3557
3558 * ospf_lsa.c (ospf_lsa_header_set), (ospf_external_lsa_body_set),
3559 (osfp_external_lsa_originate), (ospf_external_lsa_queue),
3560 (ospf_external_lsa_originate_from_queue): New function added.
3561 (ospf_external_lsa): Function removed.
3562
3563 * ospf_zebra.c (ospf_zebra_read_ipv4): Originate AS-external-LSA
3564 when listen a route from Zebra, instead creating external route.
3565
3566 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3567 (ospf_asbr_route_add_queue_lsa),
3568 (ospf_asbr_route_install_lsa), (ospf_asbr_route_add):
3569 Functions removed.
3570
3571 * ospf_ase.c (process_ase_lsa): Function will not be used.
3572 (ospf_ase_calculate), (ospf_ase_calculate_route_add),
3573 (ospf_ase_calculate_new_route), (ospf_ase_caluculate_asbr_route):
3574 process_ase_lsa () is separated to these functions.
3575
3576 OSPF AS-external-LSA origination is whole re-organized.
3577
35782000-02-18 Toshiaki Takada <takada@zebra.org>
3579
3580 * ospf_packet.c (ospf_ls_upd): Fix bug of OSPF LSA memory leak.
3581
3582 * ospf_asbr.c (ospf_asbr_route_add_flood_lsa),
3583 (ospf_asbr_route_add_queue_lsa): Fix bug of OSPF external route
3584 memory leak.
3585
35862000-02-12 Kunihiro Ishiguro <kunihiro@zebra.org>
3587
3588 * ospf_asbr.c (ospf_asbr_route_install_lsa): Re-calculate LSA
3589 checksum after change Advertised Router field.
3590
35912000-02-09 Toshiaki Takada <takada@zebra.org>
3592
3593 * ospf_asbr.c (ospf_external_route_lookup): Add new function.
3594
35952000-02-08 Toshiaki Takada <takada@zebra.org>
3596
3597 * ospfd.c (ospf_router_id_get), (ospf_router_id_update),
3598 (ospf_router_id_update_timer): Router ID decision algorithm is changed.
3599 Router ID is chosen from all of eligible interface addresses even if
3600 it is not enable to OSPF.
3601
36022000-02-08 Toshiaki Takada <takada@zebra.org>
3603
3604 * ospf_asbr.c (ospf_asbr_route_add): Function divided to
3605 ospf_asbr_route_add_flood_lsa, ospf_asbr_route_add_queue_lsa and
3606 ospf_asbr_route_install_lsa. If Router-ID is not set, then LSA is
3607 waited to install to LSDB.
3608 `0.0.0.0 adv_router' AS-external-LSA origination bug was fixed.
3609
36102000-02-01 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3611
3612 * ospf_flood.c (ospf_ls_retransmit_lookup): Compare LS seqnum
3613 in the ACK before deleting.
3614
3615 * ospf_packet.c (ospf_hello): Reset the flags after a shutdown
3616 and no shutdown of the interface.
3617
36182000-01-31 Toshiaki Takada <takada@zebra.org>
3619
3620 * ospf_packet.c (ospf_ls_req): Send multiple Link State Update
3621 packets respond to a Link State Request packet.
3622
3623 * ospfd.c (show_ip_ospf_neighbor_detail_sub): Show thread state.
3624
3625 * ospf_interface.c (ospf_vl_new): Crash when backbone area
3626 is not configured and set virtual-link to no-backbone area,
3627 bug fixed.
3628
36292000-01-30 Kunihiro Ishiguro <kunihiro@zebra.org>
3630
3631 * ospf_neighbor.h (struct ospf_neighbor): Add pointer to last send
3632 LS Request LSA.
3633
3634 * ospf_packet.c (ospf_ls_upd): Comment out LS request list
3635 treatment. That should be done in OSPF flooding procedure.
3636
3637 * ospf_flood.c (ospf_flood_through_area): Enclose
3638 ospf_check_nbr_loding inside if-else close.
3639
36402000-01-31 Toshiaki Takada <takada@zebra.org>
3641
3642 * ospf_packet.c (ospf_make_ls_upd): Fix bug of #LSAs counting.
3643
36442000-01-29 Toshiaki Takada <takada@zebra.org>
3645
3646 * ospf_packet.c (ospf_make_md5_digest): Fix bug of md5 authentication.
3647
36482000-01-28 Toshiaki Takada <takada@zebra.org>
3649
3650 * ospfd.c (show_ip_ospf): Show Number of ASE-LSAs.
3651
36522000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3653
3654 * ospf_packet.c (ospf_make_db_desc): Don't use rm_list for
3655 removing LSA from nbr->db_summary.
3656
36572000-01-27 Sira Panduranga Rao <pandu@euler.ece.iisc.ernet.in>
3658
3659 * ospf_packet.c (ospf_ls_upd_send): Set AllSPFRouters to
3660 destination when the link is point-to-point.
3661 (ospf_ls_ack_send_delayed): Likewise.
3662
36632000-01-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3664
3665 * ospf_flood.c (ospf_ls_request_delete_all): Fix bug of next
3666 pointer lookup after the node is freed.
3667
36682000-01-26 Kunihiro Ishiguro <kunihiro@zebra.org>
3669
3670 * ospf_asbr.c (ospf_asbr_route_add): Instead of scanning all AS
3671 external route, use ospf_top->external_self.
3672
36732000-01-27 Toshiaki Takada <takada@zebra.org>
3674
3675 * ospf_lsa.c (ospf_forward_address_get): New function added.
3676
3677 * ospf_asbr.c (ospf_asbr_check_lsas): Originate AS-external-LSA
3678 only when it should be replaced.
3679
36802000-01-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3681
3682 * ospf_flood.c (ospf_ls_retransmit_clear): Delete list node.
3683
3684 * ospf_lsa.c (ospf_lsa_free): Reduce logging message using
3685 ospf_zlog value.
3686
3687 * ospf_ism.c (ism_change_status): Fix bug of DR -> non DR status
3688 change. Self originated LSA is freed but not deleted from lsdb.
3689
36902000-01-24 Kunihiro Ishiguro <kunihiro@zebra.org>
3691
3692 * ospf_ism.c (ism_interface_down): Don't use router_id for
3693 detecting self neighbor structure. Instead of that compare
3694 pointer itself.
3695
3696 * ospf_neighbor.c (ospf_nbr_free): Cancel all timer when neighbor
3697 is deleted.
3698 (ospf_nbr_free): Free last send packet.
3699
3700 * ospf_neighbor.h (struct ospf_neighbor): Remove host strucutre.
3701 Instead of that src is introduced.
3702
3703 * ospf_nsm.h: Enclose macro defenition with do {} while (0).
3704
37052000-01-17 Kunihiro Ishiguro <kunihiro@zebra.org>
3706
3707 * ospfd.c: Change part of passive interface implementation. For
3708 passive interface just disabling sending/receiving Hello on the
3709 interface.
3710
37112000-01-16 Kai Bankett <kai.bankett@vew-telnet.net>
3712
3713 * ospf_interface.h (OSPF_IF_PASSIVE): Add passive flag.
3714 * ospf_interface.c (ospf_if_lookup_by_name): Add new function.
3715 * ospf_lsa.c (ospf_router_lsa): Skip passive interface.
3716 * ospfd.c (passive_interface): New command passive-interface is
3717 added.
3718 (ospf_config_write): Print passive interface.
3719
37202000-01-15 Toshiaki Takada <takada@zebra.org>
3721
3722 * ospf_interface.h (crypt_key): New struct added to store
3723 multiple cryptographic autheitication keys.
3724 (ospf_interface): struct changed.
3725
3726 * ospf_interface.c: ospf_crypt_key_new, ospf_crypt_key_add,
3727 ospf_crypt_key_lookup, ospf_crypt_key_delete: new functions added.
3728
3729 * ospf_packet.c (ip_ospf_message_digest_key): Changed to store
3730 multiple cryptographic authentication keys.
3731
37322000-01-14 Toshiaki Takada <takada@zebra.org>
3733
3734 * ospf_interface.c: DEFUN (if_ospf_*) commands changed name to
3735 ip_ospf_* ().
3736 Old notation `ospf *' still remains backward compatibility.
3737
37381999-12-29 Alex Zinin <zinin@amt.ru>
3739 * ospf_lsa.c: ospf_lsa_more_recent() bug fix
3740 * ospf_nsm.c, ospf_packet.c: remove nbr data struct when
3741 int goes down, also check DD flags correctly (bug fix)
3742
37431999-12-28 Alex Zinin <zinin@amt.ru>
3744 * "redistribute <source> metric-type (1|2) metric <XXX>" added
3745
37461999-12-23 Alex Zinin <zinin@amt.ru>
3747 * added RFC1583Compatibility flag
3748 * added dynamic interface up/down functionality
3749
37501999-11-19 Toshiaki Takada <takada@zebra.org>
3751
3752 * ospf_neighbor.h (struct ospf_neighbor): Add member state_change
3753 for NSM state change statistics.
3754
37551999-11-19 Toshiaki Takada <takada@zebra.org>
3756
3757 * ospfd.c (show_ip_ospf_neighbor_detail),
3758 (show_ip_ospf_neighbor_int_detail): DEFUN Added.
3759
37601999-11-14 Kunihiro Ishiguro <kunihiro@zebra.org>
3761
3762 * ospf_asbr.c (ospf_asbr_check_lsas): Add check of
3763 lsa->refresh_list.
3764
37651999-11-11 Toshiaki Takada <takada@zebra.org>
3766
3767 * ospf_ia.[ch] (OSPF_EXAMINE_SUMMARIES_ALL): Macro added.
3768 This macro is expanded to ospf_examine_summaries ()
3769 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3770 (OSPF_EXAMINE_TRANSIT_SUMMARIES_ALL): Macro added.
3771 This macro is expanded to ospf_examine_transit_summaries ()
3772 for SUMMARY_LSA and SUMMARY_LSA_ASBR.
3773
37741999-11-11 Toshiaki Takada <takada@zebra.org>
3775
3776 * ospf_lsa.[ch] (ospf_find_self_summary_lsa_by_prefix): Changed to
3777 macro OSPF_SUMMARY_LSA_SELF_FIND_BY_PREFIX.
3778 (ospf_find_self_summary_asbr_lsa_by_prefix): Changed to
3779 macro OSPF_SUMMARY_ASBR_LSA_SELF_FIND_BY_PREFIX.
3780 (ospf_find_self_external_lsa_by_prefix): Changed to
3781 macro OSPF_EXTERNAL_LSA_SELF_FIND_BY_PREFIX.
3782
37831999-11-11 Toshiaki Takada <takada@zebra.org>
3784
3785 * ospfd.c (ospf_abr_type): ospf_abr_type_cisco, ospf_abr_type_ibm,
3786 ospf_abr_type_shortcut and ospf_abr_type_standard DEFUNs are
3787 combined.
3788 * ospfd.c (no_ospf_abr_type): no_ospf_abr_type_cisco,
3789 no_ospf_abr_type_ibm and no_ospf_abr_type_shortcut DEFUNS are
3790 combined.
3791
37921999-11-10 Toshiaki Takada <takada@zebra.org>
3793
3794 * ospf_route.c (ospf_lookup_int_by_prefix): Move function to
3795 ospf_interface.c and change name to ospf_if_lookup_by_prefix ().
3796
37971999-11-01 Alex Zinin <zinin@amt.ru>
3798 * ospf_packet.c
3799 some correction to LSU processing
3800
3801 * ospf_lsa.c ospfd.h
3802 randomize initial LSA refreshment interval
3803 and limit the size of LSA-group to 10
3804 to let randomization work more effectively.
3805
38061999-10-31 Alex Zinin <zinin@amt.ru>
3807 * ospf_interface.c
3808 cancel t_network_lsa_self
3809 when freeing int structure
3810
3811 * ospf_abr.c ospf_asbr.c ospf_flood.c ospf_lsa.c
3812 ospf_lsa.h ospf_lsdb.h ospfd.c ospfd.h
3813
3814 Summary and ASE LSA refreshment functions
3815 added---LSA refreshment is paced to 70 LSAs
3816 per sec to avoid link overflow. Refreshment events
3817 are further randomized within a 10 sec interval
3818 to avoid syncing.
3819
3820 Also the sigfault of memcmp() in ospf_lsa_is_different()
3821 is fixed.
3822
38231999-10-30 Alex Zinin <zinin@amt.ru>
3824 * ospf_nsm.c
3825 Fix the bug where MAX_AGE LSAs
3826 are included into the DB summary.
3827
3828 * ospf_interface.c
3829 allocate 2*MTU input buffer instead of just MTU
3830 for the cases when the other router mistakenly
3831 sends larger packets thus causing fragmentation, etc.
3832
3833 * ospf_nsm.c
3834 in nsm_reset_nbr() lists should be freed
3835 not when they are empty.
3836
38371999-10-29 Kunihiro Ishiguro <kunihiro@zebra.org>
3838
3839 * ospf_zebra.c (ospf_acl_hook): Move OSPF_IS_ASBR and OSPF_IS_ABR
3840 check inside of if (ospf_top).
3841
38421999-10-29 Alex Zinin <zinin@amt.ru>
3843 * ospf_lsa.c ospf_lsdb.c :
3844 add assertion in lsa and lsa->data alloc functions,
3845 as well as in lsdb_add for new->data
3846
3847 * ospf_lsdb.c: free hash table correctly
3848
38491999-10-28 John Capo <jc@irbs.com>
3850
3851 * ospf_packet.h (OSPF_PACKET_MAX): Correct MAX packet length
3852 calculation
3853
38541999-10-27 Kunihiro Ishiguro <kunihiro@zebra.org>
3855
3856 * OSPF-TRAP-MIB.txt: New file added. Edited version of RFC1850.
3857
3858 * OSPF-MIB.txt: New file added. Edited version of RFC1850.
3859
38601999-10-27 Alex Zinin <zinin@amt.ru>
3861 * ospfd, ospf_zebra, ospf_abr
3862 "area import-list" command is added.
3863 This command allows to filter the inter-area routes
3864 injected into an area. Access list hook function
3865 extended to invalidate area exp/imp lists.
3866
38671999-10-25 Yoshinobu Inoue <shin@nd.net.fujitsu.co.jp>
3868
3869 * ospfd.c (ospf_interface_run): Enable to detect P2P network
3870 on an OSPF interface.
3871
38721999-10-19 Jordan Mendelson <jordy@wserv.com>
3873
3874 * ospf_lsdb.c (ospf_lsdb_add): Fix bug of crash
3875 in ospf_ls_retransmit_lookup ().
3876
38771999-10-19 Vladimir B. Grebenschikov <vova@express.ru>
3878
3879 * ospf_route.c: Workaround about installation of OSPF routes into
3880 the zebra daemon. Add checking of existance routes. Free
3881 ospf_top->old_table if it exists.
3882
38831999-10-15 Jordan Mendelson <jordy@wserv.com>
3884
3885 * Add support for MD5 authentication.
3886
38871999-10-12 Alex Zinin <zinin@amt.ru>
3888 * ospfd.c, ospfd.h, ospf_abr.c:
3889 a new command "area export-list" was added, it allows
3890 the admin. to control which intra-area routes are
3891 announced to other areas by the ABR
3892
38931999-10-12 Alex Zinin <zinin@amt.ru>
3894 * ospf_asbr.c (ospf_asbr_check_lsas): Fix bug of coredump
3895 when "no redistribute" is used after a distribute list
3896 denying some networks was used
3897
38981999-10-05 Toshiaki Takada <takada@zebra.org>
3899
3900 * ospf_route.c (ospf_path_dup): New function added.
3901
39021999-10-05 Toshiaki Takada <takada@zebra.org>
3903
3904 * ospf_interface.[ch]: Some of VL related funciton name changed.
3905
39061999-09-27 Alex Zinin <zinin@amt.ru>
3907
3908 * ospf_zebra.c: Distribute-list functionality added
3909
39101999-09-27 Toshiaki Takada <takada@zebra.org>
3911
3912 * ospfd.c (show_ip_ospf): Fix bug of segmentation fault when no ospf
3913 instance exists.
3914
39151999-09-25 Kunihiro Ishiguro <kunihiro@zebra.org>
3916
3917 * ospfd.c (ospf_interface_down): Fix bug of misusing nextnode()
3918 instead of node->next. Reported by Hiroki Ishibashi
3919 <ishibasi@dcd.abk.nec.co.jp>.
3920
3921 * ospf_route.c (show_ip_ospf_route): Add check for ospf is enabled
3922 or not.
3923
39241999-09-23 Alex Zinin <zinin@amt.ru>
3925
3926 * stub area support added
3927
39281999-09-23 Alex Zinin <zinin@amt.ru>
3929
3930 * fwd_addr in ASE-LSAs is now set correctly
3931 * ASE routing changed to check the fwd_addr
3932 and skip the route if the addr points to one
3933 of our interfaces to avoid loops.
3934
39351999-09-22 Alex Zinin <zinin@amt.ru>
3936
3937 * ospf_interface:
3938 ospf_vls_in_area() added, it returns
3939 the number of VLs configured through the area
3940
3941 * ospf_interface.c ospf_lsa.c ospf_lsdb.c ospfd.c
3942 honor correct mem alloc
3943
39441999-09-22 Alex Zinin <zinin@amt.ru>
3945
3946 * memory.[ch]:
3947 Some OSPF mem types added,
3948 plus more info in "show mem"
3949
39501999-09-21 Alex Zinin <zinin@amt.ru>
3951
3952 * ospfd.c:
3953 "area range substitute" added.
3954 It can be used on NAT-enabled (IP-masquarade)
3955 routers to announce private networks
3956 from an area as public ones into the outside
3957 world (not in the RFC, btw :)
3958
39591999-09-21 Alex Zinin <zinin@amt.ru>
3960
3961 * ospfd.c:
3962 "area range suppress" added.
3963 This command allows to instruct the router
3964 to be silent about specific ranges, i.e.,
3965 it is a method of route filtering on area
3966 borders
3967
39681999-09-21 Alex Zinin <zinin@amt.ru>
3969
3970 * ospfd.c VLs removed when "no network area" executed
3971
39721999-09-20 Alex Zinin <zinin@amt.ru>
3973
3974 * ospf_ase.c bug fix for not-zero fwd_addr
3975 and directly connected routes.
3976
39771999-09-20 Yon Uriarte <yon@plannet.de>
3978
3979 * ospf_packet.c (ospf_make_ls_req): Introduce delta value for
3980 checking the length of OSPF packet exceeds MTU or not.
3981
3982 * ospf_lsa.c (ospf_lsa_different): Apply ntohs for checking
3983 l1->data->length.
3984
39851999-09-18 Alex Zinin <zinin@amt.ru>
3986
3987 * ospf_lsa.c bug fix for ospf_network_lsa() to
3988 include itself into the RID list
3989
39901999-09-10 Alex Zinin <zinin@amt.ru>
3991
3992 * Alternative ABR behaviors IBM/Cisco/Shortcut
3993 implemented
3994
39951999-09-10 Alex Zinin <zinin@amt.ru>
3996
3997 * router and network-LSA origination
3998 changed to honor MinLSInterval
3999
40001999-09-08 Alex Zinin <zinin@amt.ru>
4001
4002 * modified ABR behavior to honor VLs and transit
4003 areas
4004
40051999-09-07 Alex Zinin <zinin@amt.ru>
4006
4007 * completed VL functionality
4008
40091999-09-06 Kunihiro Ishiguro <kunihiro@zebra.org>
4010
4011 * ospf_asbr.c: New file.
4012 ospf_asbr.h: New file.
4013
4014 * ospf_zebra.c (ospf_redistribute_connected): Add redistribute
4015 related stuff.
4016
40171999-09-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4018
4019 * ospfd.h (OSPF_FLAG_VIRTUAL_LINK): Change OSPF_FLAG_VEND to
4020 OSPF_FLAG_VIRTUAL_LINK for comprehensiveness.
4021
40221999-09-03 Kunihiro Ishiguro <kunihiro@zebra.org>
4023
4024 * ospf_spf.c (ospf_spf_register): Change name from
4025 ospf_spf_route_add() to ospf_spf_register().
4026 Include "ospfd/ospf_abr.h" for ospf_abr_task() prototype.
4027
40281999-09-02 Kunihiro Ishiguro <kunihiro@zebra.org>
4029
4030 * ospf_lsa.c (ospf_external_lsa_install): Change to update
4031 lsa->data rather than install new one, when same id lsa is already
4032 installed.
4033
40341999-09-01 Kunihiro Ishiguro <kunihiro@zebra.org>
4035
4036 * ospf_lsa.c (ospf_router_lsa_install): Return lsa value.
4037 (ospf_network_lsa_install): Likewise.
4038 (ospf_summary_lsa_install): Likewise.
4039 (ospf_summary_asbr_lsa_install): Likewise.
4040 (ospf_external_lsa_install): Likewise.
4041
4042 * ospf_spf.c (ospf_spf_calculate): Comment out debug function
4043 ospf_rtrs_print().
4044
40451999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4046
4047 * ospf_spf.c (ospf_rtrs_free): Add ospf_spf_calculate() for
4048 freeing rtrs.
4049
40501999-08-31 Toshiaki Takada <takada@zebra.org>
4051
4052 * ospf_lsa.c (show_ip_ospf_database_summary),
4053 (show_ip_ospf_database_summary_asbr),
4054 (show_ip_ospf_database_external): New function added.
4055 `show ip ospf database summary',
4056 `show ip ospf database asbr-summary'
4057 `show ip ospf database external' command can be used.
4058
4059 * ospf_lsa.c (ospf_lsa_count_table): New function added.
4060 (show_ip_ospf_database_all): show nothing if a type of LSA
4061 does not exist.
4062
40631999-08-31 Kunihiro Ishiguro <kunihiro@zebra.org>
4064
4065 * ospf_lsa.c (ospf_maxage_lsa_remover): Preserve next pointer when
4066 the node is deleted.
4067
40681999-08-31 Toshiaki Takada <takada@zebra.org>
4069
4070 * ospf_flood.c (ospf_ls_retransmit_lookup): change to return
4071 struct ospf_lsa *.
4072 (ospf_ls_request_new), (ospf_ls_request_free),
4073 (ospf_ls_request_add), (ospf_ls_request_delete),
4074 (ospf_ls_request_delete_all), (ospf_ls_request_lookup):
4075 New function added.
4076
4077 * ospf_packet.c (ospf_ls_upd_send_lsa): New function added.
4078
4079 * ospf_lsa.h (LS_AGE): Slightly change macro definition.
4080
4081 * ospf_lsa.c (ospf_lsa_more_recent), (ospf_lsa_diffrent):
4082 Use LS_AGE macro.
4083
40841999-08-30 Alex Zinin <zinin@amt.ru>
4085
4086 * ospfd.c
4087 fix a bug with area range config write
4088 added "show ip ospf" command, it will be enhanced later on
4089
40901999-08-30 Alex Zinin <zinin@amt.ru>
4091
4092 * ospf_lsa.c
4093 updated ospf_router_lsa() to honor flags (B-bit)
4094
40951999-08-30 Alex Zinin <zinin@amt.ru>
4096
4097 * ospf_abr.c
4098 wrote major functions implementing ABR activity
4099
41001999-08-30 Alex Zinin <zinin@amt.ru>
4101
4102 * ospf_ia.c ospf_route.c ospf_route.h
4103 fixed the bug with ospf_route.origin field.
4104 Now it holds pointer to lsa_header
4105
41061999-08-30 Alex Zinin <zinin@amt.ru>
4107
4108 * ospf_flood.c ospf_flood.h:
4109 transformed ospf_flood_if_select into ospf_flood_through_area()
4110 added new ospf_flood_if_select() and ospf_flood_through_as()
4111
41121999-08-30 Toshiaki Takada <takada@zebra.org>
4113
4114 * ospf_flood.[ch]: New file added.
4115
4116 * ospf_packet.c (ospf_lsa_flooding),
4117 (ospf_lsa_flooding_select_if): functions move to ospf_flood.c
4118
4119 * ospf_neighbor.c (ospf_put_lsa_on_retransm_list),
4120 (ospf_remove_lsa_from_retransm_list),
4121 (ospf_nbr_remove_all_lsas_from_retransm_list),
4122 (ospf_lsa_remove_from_ls_retransmit):
4123 (ospf_lsa_retransmit): functions move to
4124 ospf_flood.c, and change function's name:
4125
4126 ospf_put_lsa_on_retransm_list ()
4127 -> ospf_ls_retransmit_add ()
4128 ospf_remove_lsa_from_retransm_list ()
4129 -> ospf_ls_retransmit_delete ()
4130 ospf_nbr_remove_all_lsas_from_retransm_list ()
4131 -> ospf_ls_retransmit_clear ()
4132 ospf_lsa_remove_from_ls_retransmit ()
4133 -> ospf_ls_retransmit_delete_nbr_all ()
4134 ospf_lsa_retransmit ()
4135 -> ospf_ls_retransmit_add_nbr_all ()
4136
4137 * ospf_lsa.c (ospf_lsa_lookup_from_list): function move to
4138 ospf_flood.c, and change name to ospf_ls_retransmit_lookup ().
4139
41401999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4141
4142 * ospf_neighbor.c (ospf_nbr_lookup_by_addr): Use
4143 route_node_lookup() instead of route_node_get().
4144
4145 * ospf_packet.c (ospf_ls_upd): Temporary comment out (6) check.
4146
41471999-08-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4148
4149 * ospf_route.c (ospf_lookup_int_by_prefix): Add check of
4150 oi->address.
4151
41521999-08-29 Alex Zinin <zinin@amt.ru>
4153 * ospf_lsa.c
4154 MaxAge LSA deletion functions added.
4155
41561999-08-29 Alex Zinin <zinin@amt.ru>
4157 * ospf_neighbor.c
4158 ospf_nbr_lookup_by_addr(): added route_unlock_node()
4159 when function returns NULL if (rn->info == NULL)
4160
41611999-08-29 Alex Zinin <zinin@amt.ru>
4162 * ospfd.c
4163 added a hack for area range deletion
4164
41651999-08-29 Alex Zinin <zinin@amt.ru>
4166 * ospf_lsa.h
4167 included lsdb field into struct ospf_lsa, to find
4168 LSDB easier when removing MaxAge LSAs.
4169
41701999-08-29 Alex Zinin <zinin@amt.ru>
4171 * ospf_lsa.c ospf_neighbor.c ospf_nsm.c
4172 ospf_packet.c changed to honor new retransmit list
4173 management functions
4174
41751999-08-29 Alex Zinin <zinin@amt.ru>
4176 * ospf_neighbor.c , .h added new retransmit list functions.
4177
41781999-08-29 Alex Zinin <zinin@amt.ru>
4179 * Makefile.in
4180 added ospf_ase, ospf_abr, ospf_ia
4181
41821999-08-29 Alex Zinin <zinin@amt.ru>
4183 * ospf_spf.c:
4184 - changed ospf_next_hop_calculation() to include interface
4185 and nexthop addr for directly connected routers---more informative
4186 and solves problem with route installation into the kernel
4187 - changed ospf_nexthop_out_if_addr() to support routers, not only
4188 transit networks
4189 - added ospf_process_stubs();
4190
41911999-08-29 Alex Zinin <zinin@amt.ru>
4192 * ospf_lsa.c:
4193 - changed ospf_router_lsa() to provide correct links
4194 for p-t-p interfaces;
4195 - changed ospf_summary_lsa_install() to support table
4196 of self-originated summary-LSAs;
4197 - added ospf_summary_asbr_lsa_install() and ospf_external_lsa_install()
4198 - changed ospf_lsa_install() accordingly
4199 - changed show_ip_ospf_database_router_links() to support p-t-p
4200
42011999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4202
4203 * ospf_packet.c (ospf_make_db_desc): Only master can clear more
4204 flag.
4205
42061999-08-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4207
4208 * ospf_packet.c (ospf_read): Add check of IP src address.
4209
42101999-08-28 Alex Zinin <zinin@amt.ru>
4211 * ospf_neighbor.h
4212 added ospf_nbr_lookup_by_routerid()
4213
42141999-08-28 Alex Zinin <zinin@amt.ru>
4215 * ospfd.h
4216 added ABR/ASBR flag definitions and fields;
4217 added iflist field to area structure;
4218 summary_lsa_self and summary_lsa_asbr_self are changed
4219 to be route tables;
4220 added ranges field---configured area ranges;
4221 A separate Routers RT added;
4222 area range config commands and config write added
4223
4224
42251999-08-28 Alex Zinin <zinin@amt.ru>
4226 * ospf_route.c :
4227 ospf_route_free()--added code to free the list of paths;
4228 The following functions added:
4229 ospf_intra_add_router();
4230 ospf_intra_add_transit();
4231 ospf_intra_add_stub();
4232 the last function uses new ospf_int_lookup_by_prefix();
4233 show_ip_ospf_route_cmd()--changed to support new RT structure;
4234 added ospf_cmp_routes()--general route comparision function;
4235 added ospf_route_copy_nexthops() and ospf_route_copy_nexthops_from_vertex()
4236 they are used in ASE and IA routing;
4237 added ospf_subst_route() and ospf_add_route();
4238
42391999-08-28 Alex Zinin <zinin@amt.ru>
4240 * ospf_route.h :
4241 changed struct ospf_path to include output interface,
4242 changed struct ospf_route to support IA and ASE routing.
4243 added prototypes of the function used in IA and ASE modules.
4244
42451999-08-28 Alex Zinin <zinin@amt.ru>
4246 * ospf_lsa.h ospf_lsa.c :
4247 added ospf_my_lsa(), an interface independent version of
4248 ospf_lsa_is_self_originated(), it will be used in ASE and IA-routing.
4249
42501999-08-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4251
4252 * ospf_interface.c (interface_config_write): Add check for
4253 oi->nbr_self.
4254
42551999-08-25 Toshiaki Takada <takada@zebra.org>
4256
4257 * ospf_lsa.c (ospf_lsa_dup): New function added.
4258
4259 * ospf_packet.c (ospf_write), (ospf_read): Print send/recv
4260 interface in debug message.
4261
42621999-08-25 Toshiaki Takada <takada@zebra.org>
4263
4264 * ospf_packet.c (ospf_ls_ack_send): The name is changed from
4265 `ospf_ls_ack_send'.
4266 (ospf_ls_ack_send_delayed) (ospf_ls_ack_timer): New function added.
4267 Delayed Link State Acknowledgment is scheduled by timer.
4268
42691999-08-25 Alex Zinin <zinin@amt.ru>
4270
4271 * ospf_lsa.c (ospf_router_lsa): Incorrectly included link to
4272 a stub network instead of link to a transit network into
4273 originated router-LSA, bug fixed.
4274
42751999-08-24 Toshiaki Takada <takada@zebra.org>
4276
4277 * ospfd.c (ospf_update_router_id): New function added.
4278
4279 * ospf_network.c (ospf_write): Create new socket per transmission.
4280 And select outgoing interface whether dst is unicast or multicast.
4281
4282 * ospf_packet.c: LSA flooding will work.
4283
42841999-08-24 VOP <vop@unity.net>
4285
4286 * ospf_route.c: Include "sockunion.h"
4287
42881999-08-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4289
4290 * ospf_network.c (ospf_serv_sock_init): Enclose
4291 IPTOS_PREC_INTERNETCONTROL setting with #ifdef for OS which does
4292 not have the definition.
4293
42941999-08-23 Toshiaki Takada <takada@zebra.org>
4295
4296 * ospf_packet.c: Fix bug of DD processing.
4297
42981999-08-18 Toshiaki Takada <takada@zebra.org>
4299
4300 * ospf_lsa.c (show_ip_ospf_database): Show actual `LS age'.
4301
43021999-08-17 Toshiaki Takada <takada@zebra.org>
4303
4304 * ospf_lsa.h (OSPF_MAX_LSA): The value of OSPF_MAX_LSA is
4305 corrected. The bug of `mes_lookup' is fixed.
4306 This had been reported by Poul-Henning Kamp <phk@freebsd.org>.
4307
4308 * ospf_lsa.c (ospf_router_lsa_install): The name is changed from
4309 `ospf_add_router_lsa'.
4310 (ospf_network_lsa_install): The name is changed from
4311 `ospf_add_network_lsa'.
4312
4313 * ospf_interface.h (ospf_interface): Add member `nbr_self'.
4314
4315 * ospf_interface.c (ospf_if_is_enable): New function added.
4316
43171999-08-16 Toshiaki Takada <takada@zebra.org>
4318
4319 * ospf_lsa.h (struct lsa_header): The name is changed from
4320 `struct ospf_lsa'.
4321 (struct ospf_lsa): New struct added to control each LSA's aging
4322 and timers.
4323
4324 * ospf_lsa.c (ospf_lsa_data_free): The name is change from
4325 `ospf_lsa_free'.
4326 (ospf_lsa_data_new), (ospf_lsa_new), (ospf_lsa_free),
4327 (ospf_lsa_different), (ospf_lsa_install): New function added.
4328
4329 * ospf_packet.c (ospf_ls_upd_list_lsa): New function added.
4330
43311999-08-12 Toshiaki Takada <takada@zebra.org>
4332
4333 * ospf_nsm.c (nsm_reset_nbr): New function added.
4334 KillNbr and LLDown neighbor event call this function.
4335
43361999-08-10 Toshiaki Takada <takada@zebra.org>
4337
4338 * ospf_packet.c (ospf_ls_retransmit)
4339 (ospf_ls_upd_timer): New function added.
4340 Set retransmission timer for Link State Update.
4341
43421999-07-29 Toshiaki Takada <takada@zebra.org>
4343
4344 * ospf_ism.c (ospf_dr_election): Fix bug of DR election.
4345
43461999-07-28 Toshiaki Takada <takada@zebra.org>
4347
4348 * ospf_network.c (ospf_serv_sock_init): Set IP precedence field
4349 with IPTOS_PREC_INTERNET_CONTROL.
4350
4351 * ospf_nsm.c (nsm_change_status): Schedule NeighborChange event
4352 if NSM status change.
4353
4354 * ospf_packet.c (ospf_make_hello): Never include a neighbor in
4355 Hello packet, when the neighbor goes down.
4356
43571999-07-26 Kunihiro Ishiguro <kunihiro@zebra.org>
4358
4359 * Makefile.am (noinst_HEADERS): Add ospf_route.h.
4360
4361 * ospf_route.c (show_ip_ospf_route): Add `show ip ospf route'
4362 command.
4363
43641999-07-25 Toshiaki Takada <takada@zebra.org>
4365
4366 * ospf_lsa.c (ospf_router_lsa): Fix bug of LS sequence number
4367 assignement.
4368
43691999-07-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4370
4371 * ospf_route.c (ospf_route_table_free): New function added.
4372
4373 * ospf_spf.c (ospf_spf_next): Free vertex w when cw's and w's
4374 distance is same.
4375
4376 * ospfd.h (struct ospf): Add old_table.
4377
4378 * ospf_main.c (sighup): Call of log_rotate () removed.
4379
4380 * ospf_lsa.c (ospf_lsa_is_self_originated): Fix bug of checking
4381 area->lsa as self LSA. This should be area->lsa_self.
4382
43831999-07-24 Kunihiro Ishiguro <kunihiro@zebra.org>
4384
4385 * ospf_zebra.c (ospf_zebra_add): ospf_zebra_add
4386 (),ospf_zebra_delete () added.
4387
4388 * ospf_spf.c (ospf_spf_calculate): Call ospf_intra_route_add ().
4389
43901999-07-24 Toshiaki Takada <takada@zebra.org>
4391
4392 * ospf_lsa.c: Change LS sequence number treatment.
4393 (ospf_lsa_is_self_originated): New function added.
4394 (show_ip_ospf_database_self_originated): New DEFUN added.
4395
43961999-07-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4397
4398 * ospf_interface.c (ospf_if_lookup_by_addr): Add loopback check.
4399
44001999-07-22 Toshiaki Takada <takada@zebra.org>
4401
4402 * ospf_spf.c (ospf_nexthop_new), (ospf_nexthop_free),
4403 (ospf_nexthop_dup): function added.
4404 (ospf_nexthop_calculation): function changed.
4405
4406 * ospf_interface.c (ospf_if_lookup_by_addr): function added.
4407
44081999-07-21 Toshiaki Takada <takada@zebra.org>
4409
4410 * ospf_spf.c (ospf_spf_closest_vertex): function removed.
4411
44121999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4413
4414 * ospf_spf.c (ospf_spf_next): Apply ntohs for fetching metric.
4415
44161999-07-21 Toshiaki Takada <takada@zebra.org>
4417
4418 * ospf_neighbor.c (ospf_nbr_lookup_by_router_id): fundtion removed.
4419
4420 * ospf_lsa.c (show_ip_ospf_database_router): describe each
4421 connected link.
4422
44231999-07-21 Kunihiro Ishiguro <kunihiro@zebra.org>
4424
4425 * ospf_spf.c (ospf_spf_next): V is router LSA or network LSA so
4426 change behavior according to LSA type.
4427 (ospf_lsa_has_link): Link check function is added.
4428
44291999-07-20 Kunihiro Ishiguro <kunihiro@zebra.org>
4430
4431 * ospf_spf.c (ospf_spf_calculate_schedule): Add new function for
4432 SPF calcultion schedule addtition.
4433 (ospf_spf_calculate_timer_add): Rough 30 sec interval SPF calc
4434 timer is added.
4435 (ospf_spf_next_router): Delete ospf_spf_next_network ().
4436
4437 * ospf_lsa.c (show_ip_ospf_database_all): Network-LSA display
4438 header typo correction. Display of router LSA's #link added.
4439
44401999-07-19 Toshiaki Takada <takada@zebra.org>
4441
4442 * ospf_packet.c (ospf_check_network_mask): Added new function for
4443 receiving Raw IP packet on an appropriate interface.
4444
44451999-07-16 Toshiaki Takada <takada@zebra.org>
4446
4447 * ospfd.c (ospf_router_id): new DEFUN added.
4448
44491999-07-15 Toshiaki Takada <takada@zebra.org>
4450
4451 * ospf_spf.c (ospf_spf_init), (ospf_spf_free),
4452 (ospf_spf_has_vertex), (ospf_vertex_lookup),
4453 (ospf_spf_next_router), (ospf_spf_next_network),
4454 (ospf_spf_closest_vertex), (ospf_spf_calculate):
4455 function added.
4456
44571999-07-13 Toshiaki Takada <takada@zebra.org>
4458
4459 * ospf_ism.c: fix bug of DR Election.
4460
4461 * ospf_nsm.c: fix bug of adjacency forming.
4462
44631999-07-05 Kunihiro Ishiguro <kunihiro@zebra.org>
4464
4465 * ospfd.c (ospf_init): Change to use install_default.
4466
44671999-07-01 Rick Payne <rickp@rossfell.co.uk>
4468
4469 * ospf_zebra.c (zebra_init): Install standard commands to
4470 ZEBRA_NODE.
4471
44721999-06-30 Toshiaki Takada <takada@zebra.org>
4473
4474 * ospf_dump.c: Whole debug command is improved.
4475 (ISM|NSM) (events|status|timers) debug option added.
4476 (show_debugging_ospf): new DEFUN added.
4477
44781999-06-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4479
4480 * ospf_lsa.c (ospf_lsa_lookup_from_list): Change !IPV4_ADDR_CMP to
4481 IPV4_ADDR_SAME.
4482
44831999-06-29 Toshiaki Takada <takada@zebra.org>
4484
4485 * ospf_dump.c (ospf_summary_lsa_dump): Add summary-LSA dump routine.
4486 (ospf_as_external_lsa_dump): Add AS-external-LSA dump routine.
4487
4488 * ospf_nsm.c (nsm_twoway_received): fix condtion of adjacnet.
4489
4490 * ospf_ism.c (ospf_dr_election): fix DR Election.
4491
4492 * ospf_dump.c (ospf_nbr_state_message): fix `show ip ospf neighbor'
4493 command's state.
4494
44951999-06-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4496
4497 * ospf_dump.c (ospf_router_lsa_dump): Add router-LSA dump routine.
4498
44991999-06-28 Toshiaki Takada <takada@zebra.org>
4500
4501 * ospf_lsa.c (show_ip_ospf_database_network): fix bug of
4502 `show ip ospf database network' command output.
4503
4504 * ospf_nsm.c (nsm_inactivity_timer): Clear list of Link State
4505 Retransmission, Database Summary and Link State Request.
4506
4507 * ospf_packet.c (ospf_ls_req_timer): New function added.
4508 Set Link State Request retransmission timer.
4509
45101999-06-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4511
4512 * ospf_main.c (main): Change default output from ZLOG_SYSLOG to
4513 ZLOG_STDOUT.
4514
4515 * ospfd.c (ospf_init): Register show_ip_ospf_interface_cmd and
4516 show_ip_ospf_neighbor_cmd to VIEW_NODE.
4517
4518 * ospf_lsa.c (ospf_lsa_init): Register show_ip_ospf_database_cmd
4519 and show_ip_ospf_database_type_cmd to VIEW_NODE.
4520
45211999-06-25 Toshiaki Takada <takada@zebra.org>
4522
4523 * ospf_packet.c: fix bug of DD making.
4524 fix bug of LS-Update reading.
4525
45261999-06-23 Toshiaki Takada <takada@zebra.org>
4527
4528 * ospf_packet.c: All type of packets are changed to use
4529 fifo queue structure.
4530 (ospf_fill_header) function added.
4531
45321999-06-22 Toshiaki Takada <takada@zebra.org>
4533
4534 * ospf_packet.c (ospf_packet_new): New function added to handle
4535 sending ospf packet by fifo queue structure.
4536 (ospf_packet_free), (ospf_fifo_new), (ospf_fifo_push),
4537 (ospf_fifo_pop), (ospf_fifo_head), (ospf_fifo_flush),
4538 (ospf_fifo_free): Likewise.
4539
45401999-06-21 Toshiaki Takada <takada@zebra.org>
4541
4542 * ospf_nsm.c (ospf_db_desc_timer): function added.
4543 (nsm_timer_set) function added.
4544 * ospf_dump.c (ospf_option_dump): function added.
4545 * ospf_packet.c (ospf_ls_req) (ospf_make_ls_req): function added.
4546
45471999-06-20 Toshiaki Takada <takada@zebra.org>
4548
4549 * ospf_lsa.c (ospf_lsa_more_recent): function added.
4550 * ospf_neighbor.h (struct ospf_neighbor): Change member ms_flag
4551 to dd_flags.
4552
45531999-06-19 Toshiaki Takada <takada@zebra.org>
4554
4555 * ospf_lsa.c: DEFUN (show_ip_ospf_database) Added.
4556 * ospf_interface.c (if_ospf_cost), (if_ospf_dead_interval),
4557 (if_ospf_hello_interval), (if_ospf_priority),
4558 (if_ospf_retransmit_interval), (if_ospf_transmit_delay)
4559 argument changed from NUMBER to <range>.
4560 DEFUN (if_ospf_network_broadcast),
4561 DEFUN (if_ospf_network_non_broadcast),
4562 DEFUN (if_ospf_network_point_to_multipoint),
4563 DEFUN (if_ospf_network_point_to_point) functions are combined to
4564 DEFUN (if_ospf_network).
4565
45661999-06-18 Toshiaki Takada <takada@zebra.org>
4567
4568 * ospf_lsa.c: ospf_add_router_lsa (), ospf_add_network_lsa (),
4569 ospf_lsa_lookup (), ospf_lsa_count () Added.
4570
45711999-06-15 Toshiaki Takada <takada@zebra.org>
4572
4573 * DEFUN (ospf_debug_ism), DEFUN (ospf_debug_nsm),
4574 DEFUN (no_ospf_debug_ism), DEFUN (no_ospf_debug_nsm) Added.
4575 `debug ospf ism' command shows debug message.
4576 `debuf ospf nsm' command shows debug message.
4577
45781999-06-14 Toshiaki Takada <takada@zebra.org>
4579
4580 * ospf_lsa.c: ospf_network_lsa () Added.
4581 ospf_lsa_checksum () Added.
4582 * DEFUN (ospf_debug_packet), DEFUN (no_ospf_debug_packet) Added.
4583 `debug ospf packet' command shows debug message.
4584
45851999-06-13 Toshiaki Takada <takada@zebra.org>
4586
4587 * ospf_packet.h: Remove struct ospf_ls_req {}, ospf_ls_upd {},
4588 ospf_ls_ack {}.
4589
45901999-06-11 Toshiaki Takada <takada@zebra.org>
4591
4592 * ospf_dump.c: fix IP packet length treatment.
4593
45941999-06-10 Toshiaki Takada <takada@zebra.org>
4595
4596 * ospf_ism.h: Add OSPF_ISM_EVENT_EXECUTE() Macro Added.
4597 * ospf_nsm.h: Add OSPF_NSM_EVENT_EXECUTE() Macro Added.
4598
4599 * ospf_packet.c: ospf_db_desc (), ospf_db_desc_send () Added.
4600 ospf_make_hello (), ospf_make_db_desc () Added.
4601 ospf_db_desc_proc () Added.n
4602
4603 * Database Description packet can be processed.
4604
46051999-06-08 Toshiaki Takada <takada@zebra.org>
4606
4607 * ospf_lsa.c: New file.
4608
46091999-06-07 Toshiaki Takada <takada@zebra.org>
4610
4611 * ospf_neighbor.c: ospf_fully_adjacent_count () Added.
4612
46131999-06-07 Kunihiro Ishiguro <kunihiro@zebra.org>
4614
4615 * ospf_spf.[ch]: New file.
4616
46171999-05-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4618
4619 * ospf_zebra.c: Changed to use lib/zclient.c routines.
4620
4621 * ospf_zebra.h (zebra_start): Remove struct zebra.
4622
46231999-05-29 Kunihiro Ishiguro <kunihiro@zebra.org>
4624
4625 * ospfd.c (ospf_config_write): Add cast (unsigned long int) to
4626 ntohl for sprintf warning.
4627
46281999-05-19 Toshiaki Takada <takada@zebra.org>
4629
4630 * ospf_ism.c (ospf_dr_election): Join AllDRouters Multicast group
4631 if interface state changes to DR or BDR.
4632
46331999-05-14 Stephen R. van den Berg <srb@cuci.nl>
4634
4635 * ospf_main.c (signal_init): SIGTERM call sigint.
4636 (sigint): Logging more better message.
4637
46381999-05-12 Toshiaki Takada <takada@zebra.org>
4639
4640 * ospfd.c: Fix bug of `no router ospf' statement, it will work.
4641
46421999-05-11 Toshiaki Takada <takada@zebra.org>
4643
4644 * ospf_neighbor.c: ospf_nbr_free () Added.
4645
46461999-05-10 Toshiaki Takada <takada@zebra.org>
4647
4648 * ospfd.h: struct ospf_area { }, struct ospf_network { } Changed.
4649 * Fix bug of `no network' statement, it will work.
4650
46511999-05-07 Toshiaki Takada <takada@zebra.org>
4652
4653 * ospf_interface.c, ospf_zebra.c: Fix bug of last interface is not
4654 updated by ospf_if_update ().
4655
46561999-04-30 Kunihiro Ishiguro <kunihiro@zebra.org>
4657
4658 * Makefile.am (noinst_HEADERS): Add ospf_lsa.h for distribution.
4659
46601999-04-25 Toshiaki Takada <takada@zebra.org>
4661
4662 * ospf_interface.c: DEFUN (no_if_ospf_cost),
4663 DEFUN (no_if_ospf_dead_interval),
4664 DEFUN (no_if_ospf_hello_interval),
4665 DEFUN (no_if_ospf_priority),
4666 DEFUN (no_if_ospf_retransmit_interval),
4667 DEFUN (no_if_ospf_transmit_delay) Added.
4668
4669 interface_config_write () suppress showing interface
4670 default values.
4671
46721999-04-25 Kunihiro Ishiguro <kunihiro@zebra.org>
4673
4674 * ospf_dump.c (ospf_timer_dump): If thread is NULL return "inactive".
4675
4676 * ospfd.c (ospf_if_update): Fix bug of using ospf_area { } instead
4677 of ospf_network { }. So `router ospf' statement in ospfd.conf
4678 works again.
4679 (ospf_if_update): Call ospf_get_router_id for updating router ID.
4680
46811999-04-25 Toshiaki Takada <takada@zebra.org>
4682
4683 * ospf_interface.c: DEFUN (if_ospf_network) deleted.
4684 DEFUN (if_ospf_network_broadcast),
4685 DEFUN (if_ospf_network_non_broadcast),
4686 DEFUN (if_ospf_network_point_to_multipoint),
4687 DEFUN (if_ospf_network_point_to_point),
4688 DEFUN (no_if_ospf_network) Added.
4689
46901999-04-23 Toshiaki Takada <takada@zebra.org>
4691
4692 * ospfd.h: struct area { } changed to struct ospf_network { }.
4693 Add struct ospf_area { }.
4694 * ospfd.c: Add ospf_area_lookup_by_area_id (), ospf_network_new (),
4695 and ospf_network_free ().
4696 DEFUN (area_authentication), DEFUN (no_area_authentication) Added.
4697
46981999-04-22 Toshiaki Takada <takada@zebra.org>
4699
4700 * ospf_lsa.h: New file.
4701 * ospf_packet.h: LSA related struct definition are moved to
4702 ospf_lsa.h.
4703 * ospf_packet.c: ospf_verify_header () Added.
4704
47051999-04-21 Toshiaki Takada <takada@zebra.org>
4706
4707 * ospf_ism.c: ospf_elect_dr () and related function is changed.
4708 DR Election bug fixed.
4709 * ospf_dump.c: ospf_nbr_state_message (), ospf_timer_dump () Added.
4710 * ospfd.c: DEFUN (show_ip_ospf_neighbor) Added.
4711
47121999-04-19 Kunihiro Ishiguro <kunihiro@zebra.org>
4713
4714 * ospf_main.c (main): access_list_init () is added for vty
4715 connection filtering.
4716
47171999-04-16 Toshiaki Takada <takada@zebra.org>
4718
4719 * ospfd.c: DEFUN (show_ip_ospf_interface) Added.
4720 * ospf_neighbor.c: ospf_nbr_count () Added.
4721
47221999-04-15 Toshiaki Takada <takada@zebra.org>
4723
4724 * ospfd.h: struct ospf { } Changed.
4725 * ospfd.c: ospf_lookup_by_process_id () Deleted.
4726 * ospf_ism.c: ospf_wait_timer () Added. WaitTimer will work.
4727
47281999-04-14 Toshiaki Takada <takada@zebra.org>
4729
4730 * ospf_ism.c: ospf_elect_dr () Added.
4731 * ospf_network.c: ospf_if_ipmulticast () Added.
4732
47331999-04-11 Toshiaki Takada <takada@zebra.org>
4734
4735 * ospf_interface.c: interface_config_write (),
4736 DEFUN (if_ip_ospf_cost),
4737 DEFUN (if_ip_ospf_dead_interval),
4738 DEFUN (if_ip_ospf_hello_interval),
4739 DEFUN (if_ip_ospf_priority),
4740 DEFUN (if_ip_ospf_retransmit_interval) and
4741 DEFUN (if_ip_ospf_transmit_delay) Added.
4742
47431999-04-08 Toshiaki Takada <takada@zebra.org>
4744
4745 * ospf_dump.c: ospf_packet_db_desc_dump () Added.
4746 * ospf_neighbor.c: ospf_nbr_bidirectional () Added.
4747 * ospf_nsm.c: nsm_twoway_received () Added.
4748
47491999-04-02 Toshiaki Takada <takada@zebra.org>
4750
4751 * ospf_neighbor.c: New file.
4752 * ospf_neighbor.h: New file.
4753 * ospf_nsm.c: New file.
4754 * ospf_nsm.h: New file.
4755 * ospf_packet.c: Add ospf_make_header (), ospf_hello () and
4756 ospf_hello_send (). Now OSPFd can receive Hello and send Hello.
4757
47581999-03-27 Kunihiro Ishiguro <kunihiro@zebra.org>
4759
4760 * ospf_packet.c: Add ospf_recv_packet (). Now OSPF Hello can receive.
4761
47621999-03-19 Toshiaki Takada <takada@zebra.org>
4763
4764 * ospf_packet.c: New file.
4765 * ospf_packet.h: New file.
4766 * ospf_network.c: New file.
4767 * ospf_network.h: New file.
4768 * ospfd.h: move OSPF message structure has moved to ospf_packet.h.
4769
47701999-03-17 Kunihiro Ishiguro <kunihiro@zebra.org>
4771
4772 * ospf_zebra.c (ospf_zebra_get_interface): Fix for IPv6 interface
4773 address.
4774
4775 * Makefile.am (install-sysconfDATA): Overwrite install-sysconfDATA
4776 for install ospfd.conf.sample as owner read only file.
4777
4778 * ospf_main.c (usage): Change to use ZEBRA_BUG_ADDRESS.
4779
47801999-03-15 Toshiaki Takada <takada@zebra.org>
4781
4782 * ospf_ism.c: New file.
4783 * ospf_ism.h: New file.
4784 * ospf_dump.c: New file.
4785 * ospf_dump.h: New file.
4786
4787 * ospfd.h: Add (struct ospf), (struct config_network),
4788 (struct message) structure.
4789
4790 * ospf_interface.c: Add ospf_if_match_network ().
4791 * ospf_interface.h (struct ospf_interface): Change struct members.
4792
4793 * ospfd.c: ospf_lookup_by_process_id (), ospf_network_new (),
4794 DEFUN (network_area): Added.
4795
4796 * ospfd.conf.sample: Change sample configuration.
4797
47981999-03-05 Toshiaki Takada <takada@zebra.org>
4799
4800 * ospf_interface.c: New file.
4801 * ospf_interface.h: New file.
4802 * ospf_zebra.h: New file.
4803 * ospf_zebra.c: Add interface function for zebra daemon.
4804 * ospfd.c: New file.
4805
48061999-02-23 Kunihiro Ishiguro <kunihiro@zebra.org>
4807
4808 * Move IPv6 codes and files to ospf6d directory.
4809
48101999-02-18 Peter Galbavy <Peter.Galbavy@knowledge.com>
4811
4812 * syslog support added
4813
48141998-12-22 Toshiaki Takada <takada@zebra.org>
4815
4816 * ospfd.h: New file.
4817 * ospf_lsa.h: New file.
4818
48191998-12-15 Kunihiro Ishiguro <kunihiro@zebra.org>
4820
4821 * Makefile.am: New file.
4822 * ospf_main.c: New file.
4823