blob: b02b992a8923186a6131fcaf58dc007e59483a32 [file] [log] [blame]
Joey Armstrong34f18402023-07-21 18:58:10 -04001.. _pull-request-see-also:
2
Joey Armstrong36592e32022-11-28 09:00:28 -05003VOLTHA project repositories
4===========================
5
6Development and code reviews:
7-----------------------------
8
Joey Armstrong34f18402023-07-21 18:58:10 -04009:ref:`Commit message syntax <pull-request--commit-message>`
10+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Joey Armstrong36592e32022-11-28 09:00:28 -050011
Joey Armstrong3980d702023-08-23 10:57:18 -040012- `Working url (branch=master fallback) <https://docs.voltha.org/master/howto/code/commit-message.html#pull-request-commit-message>`_
13
Joey Armstrong34f18402023-07-21 18:58:10 -040014Job directives: recheck
15-----------------------
Joey Armstrong36592e32022-11-28 09:00:28 -050016
Joey Armstrong34f18402023-07-21 18:58:10 -040017If the CI check did not launch or failed and you believe the issue is
18unrelated to your patch/changeset you can re-trigger the job by commenting
19on the patch with *recheck*.
Joey Armstrong36592e32022-11-28 09:00:28 -050020
Joey Armstrong34f18402023-07-21 18:58:10 -040021- Visit gerrit: https://gerrit.opencord.org/c/bbsim/+/34384
22- Click the pencil icon in the top left by reviewers.
Joey Armstrong3980d702023-08-23 10:57:18 -040023- Comment/description text: ``recheck``
Joey Armstrong36592e32022-11-28 09:00:28 -050024
Joey Armstrong34f18402023-07-21 18:58:10 -040025It may take a little while to run dependent on queue size but this token will
26initiate re-running job phases for a patch.
Joey Armstrong3980d702023-08-23 10:57:18 -040027
28Code Review Request
29-------------------
30
31A code review can be requested in two ways, interactively when a patch is
32created or from the gerrit UI. Item of note, gerrit will also automatically
33assign reviewers based on volume of commits to an individual repository so
34you may have reviewers w/o explicitly requesting one.
35
36Interactively using git
37-----------------------
38
39- Create a patch, rebase/merge as needed.
40- git review to create a pull request.
41
42 - From the command line, include argument --reviewers
43 - git review --reviewers tux@onf.org foo@onf.org bar@onf.org
44 - People will be notified via email about the review request.
45
46Manually add reviewers at a later date
47--------------------------------------
48
49- `Naviagate to your patch in gerrit <https://gerrit.opencord.org/c/bbsim/+/34384>`_
50- Click the pencil icon in the top left by reviewers.
51- Add community members to request a review.
52
53