Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018-present Open Networking Foundation |
| 3 | |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | package device |
| 18 | |
| 19 | import ( |
| 20 | "context" |
| 21 | "errors" |
| 22 | "fmt" |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 23 | "github.com/gogo/protobuf/proto" |
| 24 | "github.com/opencord/voltha-go/rw_core/route" |
| 25 | coreutils "github.com/opencord/voltha-go/rw_core/utils" |
| 26 | fu "github.com/opencord/voltha-lib-go/v3/pkg/flows" |
| 27 | "github.com/opencord/voltha-lib-go/v3/pkg/log" |
| 28 | ofp "github.com/opencord/voltha-protos/v3/go/openflow_13" |
| 29 | "github.com/opencord/voltha-protos/v3/go/voltha" |
| 30 | "google.golang.org/grpc/codes" |
| 31 | "google.golang.org/grpc/status" |
khenaidoo | 0db4c81 | 2020-05-27 15:27:30 -0400 | [diff] [blame] | 32 | "strconv" |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 33 | ) |
| 34 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 35 | // listLogicalDeviceFlows returns logical device flows |
| 36 | func (agent *LogicalAgent) listLogicalDeviceFlows() map[uint64]*ofp.OfpFlowStats { |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 37 | flowIDs := agent.flowLoader.ListIDs() |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 38 | flows := make(map[uint64]*ofp.OfpFlowStats, len(flowIDs)) |
| 39 | for flowID := range flowIDs { |
| 40 | if flowHandle, have := agent.flowLoader.Lock(flowID); have { |
| 41 | flows[flowID] = flowHandle.GetReadOnly() |
| 42 | flowHandle.Unlock() |
| 43 | } |
| 44 | } |
| 45 | return flows |
| 46 | } |
| 47 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 48 | //updateFlowTable updates the flow table of that logical device |
| 49 | func (agent *LogicalAgent) updateFlowTable(ctx context.Context, flow *ofp.OfpFlowMod) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 50 | logger.Debug(ctx, "UpdateFlowTable") |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 51 | if flow == nil { |
| 52 | return nil |
| 53 | } |
| 54 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 55 | switch flow.GetCommand() { |
| 56 | case ofp.OfpFlowModCommand_OFPFC_ADD: |
| 57 | return agent.flowAdd(ctx, flow) |
| 58 | case ofp.OfpFlowModCommand_OFPFC_DELETE: |
| 59 | return agent.flowDelete(ctx, flow) |
| 60 | case ofp.OfpFlowModCommand_OFPFC_DELETE_STRICT: |
| 61 | return agent.flowDeleteStrict(ctx, flow) |
| 62 | case ofp.OfpFlowModCommand_OFPFC_MODIFY: |
| 63 | return agent.flowModify(flow) |
| 64 | case ofp.OfpFlowModCommand_OFPFC_MODIFY_STRICT: |
| 65 | return agent.flowModifyStrict(flow) |
| 66 | } |
| 67 | return status.Errorf(codes.Internal, |
| 68 | "unhandled-command: lDeviceId:%s, command:%s", agent.logicalDeviceID, flow.GetCommand()) |
| 69 | } |
| 70 | |
| 71 | //flowAdd adds a flow to the flow table of that logical device |
| 72 | func (agent *LogicalAgent) flowAdd(ctx context.Context, mod *ofp.OfpFlowMod) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 73 | logger.Debugw(ctx, "flowAdd", log.Fields{"flow": mod}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 74 | if mod == nil { |
| 75 | return nil |
| 76 | } |
| 77 | flow, err := fu.FlowStatsEntryFromFlowModMessage(mod) |
| 78 | if err != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 79 | logger.Errorw(ctx, "flowAdd-failed", log.Fields{"flowMod": mod, "err": err}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 80 | return err |
| 81 | } |
| 82 | var updated bool |
| 83 | var changed bool |
| 84 | if changed, updated, err = agent.decomposeAndAdd(ctx, flow, mod); err != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 85 | logger.Errorw(ctx, "flow-decompose-and-add-failed ", log.Fields{"flowMod": mod, "err": err}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 86 | return err |
| 87 | } |
| 88 | if changed && !updated { |
| 89 | if dbupdated := agent.updateFlowCountOfMeterStats(ctx, mod, flow, false); !dbupdated { |
| 90 | return fmt.Errorf("couldnt-updated-flow-stats-%s", strconv.FormatUint(flow.Id, 10)) |
| 91 | } |
| 92 | } |
| 93 | return nil |
| 94 | |
| 95 | } |
| 96 | |
| 97 | func (agent *LogicalAgent) decomposeAndAdd(ctx context.Context, flow *ofp.OfpFlowStats, mod *ofp.OfpFlowMod) (bool, bool, error) { |
| 98 | changed := false |
| 99 | updated := false |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 100 | var flowToReplace *ofp.OfpFlowStats |
| 101 | |
| 102 | //if flow is not found in the map, create a new entry, otherwise get the existing one. |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 103 | flowHandle, created, err := agent.flowLoader.LockOrCreate(ctx, flow) |
| 104 | if err != nil { |
| 105 | return changed, updated, err |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 106 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 107 | defer flowHandle.Unlock() |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 108 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 109 | flows := make([]*ofp.OfpFlowStats, 0) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 110 | checkOverlap := (mod.Flags & uint32(ofp.OfpFlowModFlags_OFPFF_CHECK_OVERLAP)) != 0 |
| 111 | if checkOverlap { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 112 | // TODO: this currently does nothing |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 113 | if overlapped := fu.FindOverlappingFlows(flows, mod); len(overlapped) != 0 { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 114 | // TODO: should this error be notified other than being logged? |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 115 | logger.Warnw(ctx, "overlapped-flows", log.Fields{"logicaldeviceId": agent.logicalDeviceID}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 116 | } else { |
| 117 | // Add flow |
| 118 | changed = true |
| 119 | } |
| 120 | } else { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 121 | if !created { |
| 122 | flowToReplace = flowHandle.GetReadOnly() |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 123 | if (mod.Flags & uint32(ofp.OfpFlowModFlags_OFPFF_RESET_COUNTS)) != 0 { |
| 124 | flow.ByteCount = flowToReplace.ByteCount |
| 125 | flow.PacketCount = flowToReplace.PacketCount |
| 126 | } |
| 127 | if !proto.Equal(flowToReplace, flow) { |
| 128 | changed = true |
| 129 | updated = true |
| 130 | } |
| 131 | } else { |
| 132 | changed = true |
| 133 | } |
| 134 | } |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 135 | logger.Debugw(ctx, "flowAdd-changed", log.Fields{"changed": changed, "updated": updated}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 136 | if changed { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 137 | updatedFlows := map[uint64]*ofp.OfpFlowStats{flow.Id: flow} |
| 138 | |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 139 | flowMeterConfig, err := agent.GetMeterConfig(ctx, updatedFlows) |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 140 | if err != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 141 | logger.Error(ctx, "Meter-referred-in-flow-not-present") |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 142 | return changed, updated, err |
| 143 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 144 | |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 145 | groupIDs := agent.groupLoader.ListIDs() |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 146 | groups := make(map[uint32]*ofp.OfpGroupEntry, len(groupIDs)) |
| 147 | for groupID := range groupIDs { |
| 148 | if groupHandle, have := agent.groupLoader.Lock(groupID); have { |
| 149 | groups[groupID] = groupHandle.GetReadOnly() |
| 150 | groupHandle.Unlock() |
| 151 | } |
| 152 | } |
| 153 | |
| 154 | deviceRules, err := agent.flowDecomposer.DecomposeRules(ctx, agent, updatedFlows, groups) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 155 | if err != nil { |
| 156 | return changed, updated, err |
| 157 | } |
| 158 | |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 159 | logger.Debugw(ctx, "rules", log.Fields{"rules": deviceRules.String()}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 160 | // Update store and cache |
| 161 | if updated { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 162 | if err := flowHandle.Update(ctx, flow); err != nil { |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 163 | return changed, updated, err |
| 164 | } |
| 165 | } |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 166 | respChannels := agent.addFlowsAndGroupsToDevices(ctx, deviceRules, toMetadata(flowMeterConfig)) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 167 | // Create the go routines to wait |
| 168 | go func() { |
| 169 | // Wait for completion |
| 170 | if res := coreutils.WaitForNilOrErrorResponses(agent.defaultTimeout, respChannels...); res != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 171 | logger.Infow(ctx, "failed-to-add-flows-will-attempt-deletion", log.Fields{"errors": res, "logical-device-id": agent.logicalDeviceID}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 172 | // Revert added flows |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 173 | if err := agent.revertAddedFlows(context.Background(), mod, flow, flowToReplace, deviceRules, toMetadata(flowMeterConfig)); err != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 174 | logger.Errorw(ctx, "failure-to-delete-flows-after-failed-addition", log.Fields{"logical-device-id": agent.logicalDeviceID, "error": err}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 175 | } |
| 176 | } |
| 177 | }() |
| 178 | } |
| 179 | return changed, updated, nil |
| 180 | } |
| 181 | |
| 182 | // revertAddedFlows reverts flows after the flowAdd request has failed. All flows corresponding to that flowAdd request |
| 183 | // will be reverted, both from the logical devices and the devices. |
| 184 | func (agent *LogicalAgent) revertAddedFlows(ctx context.Context, mod *ofp.OfpFlowMod, addedFlow *ofp.OfpFlowStats, replacedFlow *ofp.OfpFlowStats, deviceRules *fu.DeviceRules, metadata *voltha.FlowMetadata) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 185 | logger.Debugw(ctx, "revertFlowAdd", log.Fields{"added-flow": addedFlow, "replaced-flow": replacedFlow, "device-rules": deviceRules, "metadata": metadata}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 186 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 187 | flowHandle, have := agent.flowLoader.Lock(addedFlow.Id) |
| 188 | if !have { |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 189 | // Not found - do nothing |
| 190 | log.Debugw("flow-not-found", log.Fields{"added-flow": addedFlow}) |
| 191 | return nil |
| 192 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 193 | defer flowHandle.Unlock() |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 194 | |
| 195 | if replacedFlow != nil { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 196 | if err := flowHandle.Update(ctx, replacedFlow); err != nil { |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 197 | return err |
| 198 | } |
| 199 | } else { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 200 | if err := flowHandle.Delete(ctx); err != nil { |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 201 | return err |
| 202 | } |
| 203 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 204 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 205 | // Revert meters |
| 206 | if changedMeterStats := agent.updateFlowCountOfMeterStats(ctx, mod, addedFlow, true); !changedMeterStats { |
| 207 | return fmt.Errorf("Unable-to-revert-meterstats-for-flow-%s", strconv.FormatUint(addedFlow.Id, 10)) |
| 208 | } |
| 209 | |
| 210 | // Update the devices |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 211 | respChnls := agent.deleteFlowsAndGroupsFromDevices(ctx, deviceRules, metadata, mod) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 212 | |
| 213 | // Wait for the responses |
| 214 | go func() { |
| 215 | // Since this action is taken following an add failure, we may also receive a failure for the revert |
| 216 | if res := coreutils.WaitForNilOrErrorResponses(agent.defaultTimeout, respChnls...); res != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 217 | logger.Warnw(ctx, "failure-reverting-added-flows", log.Fields{ |
Matteo Scandolo | 367162b | 2020-06-22 15:07:33 -0700 | [diff] [blame] | 218 | "logical-device-id": agent.logicalDeviceID, |
| 219 | "flow-cookie": mod.Cookie, |
| 220 | "errors": res, |
| 221 | }) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 222 | } |
| 223 | }() |
| 224 | |
| 225 | return nil |
| 226 | } |
| 227 | |
| 228 | //flowDelete deletes a flow from the flow table of that logical device |
| 229 | func (agent *LogicalAgent) flowDelete(ctx context.Context, mod *ofp.OfpFlowMod) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 230 | logger.Debug(ctx, "flowDelete") |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 231 | if mod == nil { |
| 232 | return nil |
| 233 | } |
| 234 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 235 | //build a list of what to delete |
| 236 | toDelete := make(map[uint64]*ofp.OfpFlowStats) |
| 237 | |
| 238 | // add perfectly matching entry if exists |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 239 | fs, err := fu.FlowStatsEntryFromFlowModMessage(mod) |
| 240 | if err != nil { |
| 241 | return err |
| 242 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 243 | if handle, have := agent.flowLoader.Lock(fs.Id); have { |
| 244 | toDelete[fs.Id] = handle.GetReadOnly() |
| 245 | handle.Unlock() |
| 246 | } |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 247 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 248 | // search through all the flows |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 249 | for flowID := range agent.flowLoader.ListIDs() { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 250 | if flowHandle, have := agent.flowLoader.Lock(flowID); have { |
| 251 | if flow := flowHandle.GetReadOnly(); fu.FlowMatchesMod(flow, mod) { |
| 252 | toDelete[flow.Id] = flow |
| 253 | } |
| 254 | flowHandle.Unlock() |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 255 | } |
| 256 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 257 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 258 | //Delete the matched flows |
| 259 | if len(toDelete) > 0 { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 260 | logger.Debugw(ctx, "flowDelete", log.Fields{"logicalDeviceId": agent.logicalDeviceID, "toDelete": len(toDelete)}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 261 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 262 | for _, flow := range toDelete { |
| 263 | if flowHandle, have := agent.flowLoader.Lock(flow.Id); have { |
| 264 | // TODO: Flow should only be updated if meter is updated, and meter should only be updated if flow is updated |
| 265 | // currently an error while performing the second operation will leave an inconsistent state in kv. |
| 266 | // This should be a single atomic operation down to the kv. |
| 267 | if changedMeter := agent.updateFlowCountOfMeterStats(ctx, mod, flowHandle.GetReadOnly(), false); !changedMeter { |
| 268 | flowHandle.Unlock() |
| 269 | return fmt.Errorf("cannot-delete-flow-%d. Meter-update-failed", flow.Id) |
| 270 | } |
| 271 | // Update store and cache |
| 272 | if err := flowHandle.Delete(ctx); err != nil { |
| 273 | flowHandle.Unlock() |
| 274 | return fmt.Errorf("cannot-delete-flows-%d. Delete-from-store-failed", flow.Id) |
| 275 | } |
| 276 | flowHandle.Unlock() |
| 277 | // TODO: since this is executed in a loop without also updating meter stats, and error part way through this |
| 278 | // operation will leave inconsistent state in the meter stats & flows on the devices. |
| 279 | // This & related meter updates should be a single atomic operation down to the kv. |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 280 | } |
| 281 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 282 | |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 283 | metersConfig, err := agent.GetMeterConfig(ctx, toDelete) |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 284 | if err != nil { // This should never happen |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 285 | logger.Error(ctx, "Meter-referred-in-flows-not-present") |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 286 | return err |
| 287 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 288 | |
| 289 | groups := make(map[uint32]*ofp.OfpGroupEntry) |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 290 | for groupID := range agent.groupLoader.ListIDs() { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 291 | if groupHandle, have := agent.groupLoader.Lock(groupID); have { |
| 292 | groups[groupID] = groupHandle.GetReadOnly() |
| 293 | groupHandle.Unlock() |
| 294 | } |
| 295 | } |
| 296 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 297 | var respChnls []coreutils.Response |
| 298 | var partialRoute bool |
| 299 | var deviceRules *fu.DeviceRules |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 300 | deviceRules, err = agent.flowDecomposer.DecomposeRules(ctx, agent, toDelete, groups) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 301 | if err != nil { |
| 302 | // A no route error means no route exists between the ports specified in the flow. This can happen when the |
| 303 | // child device is deleted and a request to delete flows from the parent device is received |
| 304 | if !errors.Is(err, route.ErrNoRoute) { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 305 | logger.Errorw(ctx, "unexpected-error-received", log.Fields{"flows-to-delete": toDelete, "error": err}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 306 | return err |
| 307 | } |
| 308 | partialRoute = true |
| 309 | } |
| 310 | |
| 311 | // Update the devices |
| 312 | if partialRoute { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 313 | respChnls = agent.deleteFlowsFromParentDevice(ctx, toDelete, toMetadata(metersConfig), mod) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 314 | } else { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 315 | respChnls = agent.deleteFlowsAndGroupsFromDevices(ctx, deviceRules, toMetadata(metersConfig), mod) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 316 | } |
| 317 | |
| 318 | // Wait for the responses |
| 319 | go func() { |
| 320 | // Wait for completion |
| 321 | if res := coreutils.WaitForNilOrErrorResponses(agent.defaultTimeout, respChnls...); res != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 322 | logger.Errorw(ctx, "failure-updating-device-flows", log.Fields{"logicalDeviceId": agent.logicalDeviceID, "errors": res}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 323 | // TODO: Revert the flow deletion |
| 324 | } |
| 325 | }() |
| 326 | } |
| 327 | //TODO: send announcement on delete |
| 328 | return nil |
| 329 | } |
| 330 | |
| 331 | //flowDeleteStrict deletes a flow from the flow table of that logical device |
| 332 | func (agent *LogicalAgent) flowDeleteStrict(ctx context.Context, mod *ofp.OfpFlowMod) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 333 | logger.Debugw(ctx, "flowDeleteStrict", log.Fields{"mod": mod}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 334 | if mod == nil { |
| 335 | return nil |
| 336 | } |
| 337 | |
| 338 | flow, err := fu.FlowStatsEntryFromFlowModMessage(mod) |
| 339 | if err != nil { |
| 340 | return err |
| 341 | } |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 342 | logger.Debugw(ctx, "flow-id-in-flow-delete-strict", log.Fields{"flowID": flow.Id}) |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 343 | flowHandle, have := agent.flowLoader.Lock(flow.Id) |
| 344 | if !have { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 345 | logger.Debugw(ctx, "Skipping-flow-delete-strict-request. No-flow-found", log.Fields{"flowMod": mod}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 346 | return nil |
| 347 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 348 | defer flowHandle.Unlock() |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 349 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 350 | groups := make(map[uint32]*ofp.OfpGroupEntry) |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 351 | for groupID := range agent.groupLoader.ListIDs() { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 352 | if groupHandle, have := agent.groupLoader.Lock(groupID); have { |
| 353 | groups[groupID] = groupHandle.GetReadOnly() |
| 354 | groupHandle.Unlock() |
| 355 | } |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 356 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 357 | |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 358 | if changedMeter := agent.updateFlowCountOfMeterStats(ctx, mod, flow, false); !changedMeter { |
| 359 | return fmt.Errorf("Cannot delete flow - %s. Meter update failed", flow) |
| 360 | } |
| 361 | |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 362 | flowsToDelete := map[uint64]*ofp.OfpFlowStats{flow.Id: flowHandle.GetReadOnly()} |
| 363 | |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 364 | flowMetadata, err := agent.GetMeterConfig(ctx, flowsToDelete) |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 365 | if err != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 366 | logger.Error(ctx, "meter-referred-in-flows-not-present") |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 367 | return err |
| 368 | } |
| 369 | var respChnls []coreutils.Response |
| 370 | var partialRoute bool |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 371 | deviceRules, err := agent.flowDecomposer.DecomposeRules(ctx, agent, flowsToDelete, groups) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 372 | if err != nil { |
| 373 | // A no route error means no route exists between the ports specified in the flow. This can happen when the |
| 374 | // child device is deleted and a request to delete flows from the parent device is received |
| 375 | if !errors.Is(err, route.ErrNoRoute) { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 376 | logger.Errorw(ctx, "unexpected-error-received", log.Fields{"flows-to-delete": flowsToDelete, "error": err}) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 377 | return err |
| 378 | } |
| 379 | partialRoute = true |
| 380 | } |
| 381 | |
| 382 | // Update the model |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 383 | if err := flowHandle.Delete(ctx); err != nil { |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 384 | return err |
| 385 | } |
| 386 | // Update the devices |
| 387 | if partialRoute { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 388 | respChnls = agent.deleteFlowsFromParentDevice(ctx, flowsToDelete, toMetadata(flowMetadata), mod) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 389 | } else { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 390 | respChnls = agent.deleteFlowsAndGroupsFromDevices(ctx, deviceRules, toMetadata(flowMetadata), mod) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 391 | } |
| 392 | |
| 393 | // Wait for completion |
| 394 | go func() { |
| 395 | if res := coreutils.WaitForNilOrErrorResponses(agent.defaultTimeout, respChnls...); res != nil { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 396 | logger.Warnw(ctx, "failure-deleting-device-flows", log.Fields{ |
Matteo Scandolo | 367162b | 2020-06-22 15:07:33 -0700 | [diff] [blame] | 397 | "flow-cookie": mod.Cookie, |
| 398 | "logical-device-id": agent.logicalDeviceID, |
| 399 | "errors": res, |
| 400 | }) |
Kent Hagerman | 3136fbd | 2020-05-14 10:30:45 -0400 | [diff] [blame] | 401 | //TODO: Revert flow changes |
| 402 | } |
| 403 | }() |
| 404 | |
| 405 | return nil |
| 406 | } |
| 407 | |
| 408 | //flowModify modifies a flow from the flow table of that logical device |
| 409 | func (agent *LogicalAgent) flowModify(mod *ofp.OfpFlowMod) error { |
| 410 | return errors.New("flowModify not implemented") |
| 411 | } |
| 412 | |
| 413 | //flowModifyStrict deletes a flow from the flow table of that logical device |
| 414 | func (agent *LogicalAgent) flowModifyStrict(mod *ofp.OfpFlowMod) error { |
| 415 | return errors.New("flowModifyStrict not implemented") |
| 416 | } |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 417 | |
| 418 | // TODO: Remove this helper, just pass the map through to functions directly |
| 419 | func toMetadata(meters map[uint32]*ofp.OfpMeterConfig) *voltha.FlowMetadata { |
| 420 | ctr, ret := 0, make([]*ofp.OfpMeterConfig, len(meters)) |
| 421 | for _, meter := range meters { |
| 422 | ret[ctr] = meter |
| 423 | ctr++ |
| 424 | } |
| 425 | return &voltha.FlowMetadata{Meters: ret} |
| 426 | } |
| 427 | |
| 428 | func (agent *LogicalAgent) deleteFlowsHavingMeter(ctx context.Context, meterID uint32) error { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 429 | logger.Infow(ctx, "Delete-flows-matching-meter", log.Fields{"meter": meterID}) |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 430 | for flowID := range agent.flowLoader.ListIDs() { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 431 | if flowHandle, have := agent.flowLoader.Lock(flowID); have { |
| 432 | if flowMeterID := fu.GetMeterIdFromFlow(flowHandle.GetReadOnly()); flowMeterID != 0 && flowMeterID == meterID { |
| 433 | if err := flowHandle.Delete(ctx); err != nil { |
| 434 | //TODO: Think on carrying on and deleting the remaining flows, instead of returning. |
| 435 | //Anyways this returns an error to controller which possibly results with a re-deletion. |
| 436 | //Then how can we handle the new deletion request(Same for group deletion)? |
| 437 | return err |
| 438 | } |
| 439 | } |
| 440 | flowHandle.Unlock() |
| 441 | } |
| 442 | } |
| 443 | return nil |
| 444 | } |
| 445 | |
| 446 | func (agent *LogicalAgent) deleteFlowsHavingGroup(ctx context.Context, groupID uint32) (map[uint64]*ofp.OfpFlowStats, error) { |
Rohan Agrawal | 31f2180 | 2020-06-12 05:38:46 +0000 | [diff] [blame] | 447 | logger.Infow(ctx, "Delete-flows-matching-group", log.Fields{"groupID": groupID}) |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 448 | flowsRemoved := make(map[uint64]*ofp.OfpFlowStats) |
Kent Hagerman | fa9d6d4 | 2020-05-25 11:49:40 -0400 | [diff] [blame] | 449 | for flowID := range agent.flowLoader.ListIDs() { |
Kent Hagerman | 433a31a | 2020-05-20 19:04:48 -0400 | [diff] [blame] | 450 | if flowHandle, have := agent.flowLoader.Lock(flowID); have { |
| 451 | if flow := flowHandle.GetReadOnly(); fu.FlowHasOutGroup(flow, groupID) { |
| 452 | if err := flowHandle.Delete(ctx); err != nil { |
| 453 | return nil, err |
| 454 | } |
| 455 | flowsRemoved[flowID] = flow |
| 456 | } |
| 457 | flowHandle.Unlock() |
| 458 | } |
| 459 | } |
| 460 | return flowsRemoved, nil |
| 461 | } |