khenaidoo | bf6e7bb | 2018-08-14 22:27:29 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2018-present Open Networking Foundation |
| 3 | |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 16 | |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 17 | package model |
| 18 | |
| 19 | import ( |
| 20 | "bytes" |
| 21 | "compress/gzip" |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 22 | "github.com/golang/protobuf/proto" |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 23 | "github.com/opencord/voltha-go/common/log" |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 24 | "github.com/opencord/voltha-go/db/kvstore" |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 25 | "reflect" |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 26 | "runtime/debug" |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 27 | "strings" |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 28 | "sync" |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 29 | ) |
| 30 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 31 | // PersistedRevision holds information of revision meant to be saved in a persistent storage |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 32 | type PersistedRevision struct { |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 33 | Revision |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 34 | Compress bool |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 35 | |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 36 | events chan *kvstore.Event `json:"-"` |
| 37 | kvStore *Backend `json:"-"` |
| 38 | mutex sync.RWMutex `json:"-"` |
| 39 | isStored bool |
| 40 | isWatched bool |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 41 | } |
| 42 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 43 | // NewPersistedRevision creates a new instance of a PersistentRevision structure |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 44 | func NewPersistedRevision(branch *Branch, data interface{}, children map[string][]Revision) Revision { |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 45 | pr := &PersistedRevision{} |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 46 | pr.kvStore = branch.Node.GetRoot().KvStore |
| 47 | pr.Revision = NewNonPersistedRevision(nil, branch, data, children) |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 48 | return pr |
| 49 | } |
| 50 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 51 | // Finalize is responsible of saving the revision in the persistent storage |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 52 | func (pr *PersistedRevision) Finalize(skipOnExist bool) { |
| 53 | pr.store(skipOnExist) |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 54 | } |
| 55 | |
| 56 | type revData struct { |
| 57 | Children map[string][]string |
| 58 | Config string |
| 59 | } |
| 60 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 61 | func (pr *PersistedRevision) store(skipOnExist bool) { |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 62 | if pr.GetBranch().Txid != "" { |
| 63 | return |
| 64 | } |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 65 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 66 | if pair, _ := pr.kvStore.Get(pr.GetHash()); pair != nil && skipOnExist { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 67 | log.Debugw("revision-config-already-exists", log.Fields{"hash": pr.GetHash()}) |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 68 | return |
| 69 | } |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 70 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 71 | if blob, err := proto.Marshal(pr.GetConfig().Data.(proto.Message)); err != nil { |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 72 | // TODO report error |
| 73 | } else { |
| 74 | if pr.Compress { |
| 75 | var b bytes.Buffer |
| 76 | w := gzip.NewWriter(&b) |
| 77 | w.Write(blob) |
| 78 | w.Close() |
| 79 | blob = b.Bytes() |
| 80 | } |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 81 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 82 | if err := pr.kvStore.Put(pr.GetHash(), blob); err != nil { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 83 | log.Warnw("problem-storing-revision-config", |
| 84 | log.Fields{"error": err, "hash": pr.GetHash(), "data": pr.GetConfig().Data}) |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 85 | } else { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 86 | log.Debugw("storing-revision-config", |
| 87 | log.Fields{"hash": pr.GetHash(), "data": pr.GetConfig().Data}) |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 88 | pr.isStored = true |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 89 | } |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 90 | } |
| 91 | } |
| 92 | |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 93 | func (pr *PersistedRevision) SetupWatch(key string) { |
| 94 | if pr.events == nil { |
| 95 | pr.events = make(chan *kvstore.Event) |
| 96 | |
| 97 | log.Debugw("setting-watch", log.Fields{"key": key}) |
| 98 | |
| 99 | pr.events = pr.kvStore.CreateWatch(key) |
| 100 | |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 101 | pr.isWatched = true |
| 102 | |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 103 | // Start watching |
| 104 | go pr.startWatching() |
| 105 | } |
| 106 | } |
| 107 | |
| 108 | func (pr *PersistedRevision) startWatching() { |
| 109 | log.Debugw("starting-watch", log.Fields{"key": pr.GetHash()}) |
| 110 | |
| 111 | StopWatchLoop: |
| 112 | for { |
| 113 | select { |
| 114 | case event, ok := <-pr.events: |
| 115 | if !ok { |
| 116 | log.Errorw("event-channel-failure: stopping watch loop", log.Fields{"key": pr.GetHash()}) |
| 117 | break StopWatchLoop |
| 118 | } |
| 119 | |
| 120 | log.Debugw("received-event", log.Fields{"type": event.EventType}) |
| 121 | |
| 122 | switch event.EventType { |
| 123 | case kvstore.DELETE: |
| 124 | log.Debugw("delete-from-memory", log.Fields{"key": pr.GetHash()}) |
| 125 | pr.Revision.Drop("", true) |
| 126 | break StopWatchLoop |
| 127 | |
| 128 | case kvstore.PUT: |
| 129 | log.Debugw("update-in-memory", log.Fields{"key": pr.GetHash()}) |
| 130 | |
| 131 | if dataPair, err := pr.kvStore.Get(pr.GetHash()); err != nil || dataPair == nil { |
| 132 | log.Errorw("update-in-memory--key-retrieval-failed", log.Fields{"key": pr.GetHash(), "error": err}) |
| 133 | } else { |
| 134 | pr.UpdateData(dataPair.Value, pr.GetBranch()) |
| 135 | } |
| 136 | |
| 137 | default: |
| 138 | log.Debugw("unhandled-event", log.Fields{"key": pr.GetHash(), "type": event.EventType}) |
| 139 | } |
| 140 | } |
| 141 | } |
| 142 | |
| 143 | log.Debugw("exiting-watch", log.Fields{"key": pr.GetHash()}) |
| 144 | } |
| 145 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 146 | func (pr *PersistedRevision) LoadFromPersistence(path string, txid string) []Revision { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 147 | log.Debugw("loading-from-persistence", log.Fields{"path": path, "txid": txid}) |
| 148 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 149 | var response []Revision |
| 150 | var rev Revision |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 151 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 152 | rev = pr |
| 153 | |
| 154 | if pr.kvStore != nil { |
| 155 | blobMap, _ := pr.kvStore.List(path) |
| 156 | |
| 157 | partition := strings.SplitN(path, "/", 2) |
| 158 | name := partition[0] |
| 159 | |
| 160 | if len(partition) < 2 { |
| 161 | path = "" |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 162 | } else { |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 163 | path = partition[1] |
| 164 | } |
| 165 | |
| 166 | field := ChildrenFields(rev.GetBranch().Node.Type)[name] |
| 167 | |
| 168 | if field.IsContainer { |
| 169 | for _, blob := range blobMap { |
| 170 | output := blob.Value.([]byte) |
| 171 | |
| 172 | data := reflect.New(field.ClassType.Elem()) |
| 173 | |
| 174 | if err := proto.Unmarshal(output, data.Interface().(proto.Message)); err != nil { |
| 175 | // TODO report error |
| 176 | } else { |
| 177 | |
| 178 | var children []Revision |
| 179 | |
| 180 | if path == "" { |
| 181 | if field.Key != "" { |
| 182 | // e.g. /logical_devices/abcde --> path="" name=logical_devices key=abcde |
| 183 | if field.Key != "" { |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 184 | children = make([]Revision, len(rev.GetChildren(name))) |
| 185 | copy(children, rev.GetChildren(name)) |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 186 | |
| 187 | _, key := GetAttributeValue(data.Interface(), field.Key, 0) |
| 188 | |
| 189 | childRev := rev.GetBranch().Node.MakeNode(data.Interface(), txid).Latest(txid) |
| 190 | childRev.SetHash(name + "/" + key.String()) |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 191 | |
| 192 | // Create watch for <component>/<key> |
| 193 | pr.SetupWatch(childRev.GetHash()) |
| 194 | |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 195 | children = append(children, childRev) |
| 196 | rev = rev.UpdateChildren(name, children, rev.GetBranch()) |
| 197 | |
| 198 | rev.GetBranch().Node.makeLatest(rev.GetBranch(), rev, nil) |
| 199 | |
| 200 | response = append(response, childRev) |
| 201 | continue |
| 202 | } |
| 203 | } |
| 204 | } else if field.Key != "" { |
| 205 | // e.g. /logical_devices/abcde/flows/vwxyz --> path=abcde/flows/vwxyz |
| 206 | |
| 207 | partition := strings.SplitN(path, "/", 2) |
| 208 | key := partition[0] |
| 209 | if len(partition) < 2 { |
| 210 | path = "" |
| 211 | } else { |
| 212 | path = partition[1] |
| 213 | } |
| 214 | keyValue := field.KeyFromStr(key) |
| 215 | |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 216 | children = make([]Revision, len(rev.GetChildren(name))) |
| 217 | copy(children, rev.GetChildren(name)) |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 218 | |
| 219 | idx, childRev := rev.GetBranch().Node.findRevByKey(children, field.Key, keyValue) |
| 220 | |
| 221 | newChildRev := childRev.LoadFromPersistence(path, txid) |
| 222 | |
| 223 | children[idx] = newChildRev[0] |
| 224 | |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 225 | rev := rev.UpdateChildren(name, rev.GetChildren(name), rev.GetBranch()) |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 226 | rev.GetBranch().Node.makeLatest(rev.GetBranch(), rev, nil) |
| 227 | |
| 228 | response = append(response, newChildRev[0]) |
| 229 | continue |
| 230 | } |
| 231 | } |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 232 | } |
| 233 | } |
| 234 | } |
Stephane Barbarie | 1ab4327 | 2018-12-08 21:42:13 -0500 | [diff] [blame] | 235 | return response |
Stephane Barbarie | 4a2564d | 2018-07-26 11:02:58 -0400 | [diff] [blame] | 236 | } |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 237 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 238 | // UpdateData modifies the information in the data model and saves it in the persistent storage |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 239 | func (pr *PersistedRevision) UpdateData(data interface{}, branch *Branch) Revision { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 240 | log.Debugw("updating-persisted-data", log.Fields{"hash": pr.GetHash()}) |
| 241 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 242 | newNPR := pr.Revision.UpdateData(data, branch) |
| 243 | |
| 244 | newPR := &PersistedRevision{ |
| 245 | Revision: newNPR, |
| 246 | Compress: pr.Compress, |
khenaidoo | b920354 | 2018-09-17 22:56:37 -0400 | [diff] [blame] | 247 | kvStore: pr.kvStore, |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 248 | } |
| 249 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 250 | return newPR |
| 251 | } |
| 252 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 253 | // UpdateChildren modifies the children of a revision and of a specific component and saves it in the persistent storage |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 254 | func (pr *PersistedRevision) UpdateChildren(name string, children []Revision, branch *Branch) Revision { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 255 | log.Debugw("updating-persisted-children", log.Fields{"hash": pr.GetHash()}) |
| 256 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 257 | newNPR := pr.Revision.UpdateChildren(name, children, branch) |
| 258 | |
| 259 | newPR := &PersistedRevision{ |
| 260 | Revision: newNPR, |
| 261 | Compress: pr.Compress, |
khenaidoo | b920354 | 2018-09-17 22:56:37 -0400 | [diff] [blame] | 262 | kvStore: pr.kvStore, |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 263 | } |
| 264 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 265 | return newPR |
| 266 | } |
| 267 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 268 | // UpdateAllChildren modifies the children for all components of a revision and saves it in the peristent storage |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 269 | func (pr *PersistedRevision) UpdateAllChildren(children map[string][]Revision, branch *Branch) Revision { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 270 | log.Debugw("updating-all-persisted-children", log.Fields{"hash": pr.GetHash()}) |
| 271 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 272 | newNPR := pr.Revision.UpdateAllChildren(children, branch) |
| 273 | |
| 274 | newPR := &PersistedRevision{ |
| 275 | Revision: newNPR, |
| 276 | Compress: pr.Compress, |
khenaidoo | b920354 | 2018-09-17 22:56:37 -0400 | [diff] [blame] | 277 | kvStore: pr.kvStore, |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 278 | } |
| 279 | |
Stephane Barbarie | ec0919b | 2018-09-05 14:14:29 -0400 | [diff] [blame] | 280 | return newPR |
| 281 | } |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 282 | |
| 283 | // Drop takes care of eliminating a revision hash that is no longer needed |
| 284 | // and its associated config when required |
| 285 | func (pr *PersistedRevision) Drop(txid string, includeConfig bool) { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 286 | log.Debugw("dropping-revision", |
| 287 | log.Fields{"txid": txid, "hash": pr.GetHash(), "config-hash": pr.GetConfig().Hash, "stack": string(debug.Stack())}) |
| 288 | |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 289 | pr.mutex.Lock() |
| 290 | defer pr.mutex.Unlock() |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 291 | if pr.kvStore != nil && txid == "" { |
Stephane Barbarie | 3cb0122 | 2019-01-16 17:15:56 -0500 | [diff] [blame] | 292 | if pr.isStored { |
| 293 | if includeConfig { |
| 294 | if err := pr.kvStore.Delete(pr.GetConfig().Hash); err != nil { |
| 295 | log.Errorw("failed-to-remove-revision-config", log.Fields{"hash": pr.GetConfig().Hash, "error": err.Error()}) |
| 296 | } |
| 297 | } |
| 298 | |
| 299 | if err := pr.kvStore.Delete(pr.GetHash()); err != nil { |
| 300 | log.Errorw("failed-to-remove-revision", log.Fields{"hash": pr.GetHash(), "error": err.Error()}) |
| 301 | } else { |
| 302 | pr.isStored = false |
| 303 | } |
| 304 | |
| 305 | if pr.isWatched { |
| 306 | pr.kvStore.DeleteWatch(pr.GetHash(), pr.events) |
| 307 | pr.isWatched = false |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 308 | } |
| 309 | } |
| 310 | |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 311 | } else { |
| 312 | if includeConfig { |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 313 | log.Debugw("attempted-to-remove-transacted-revision-config", log.Fields{"hash": pr.GetConfig().Hash, "txid": txid}) |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 314 | } |
Stephane Barbarie | e0a4c79 | 2019-01-16 11:26:29 -0500 | [diff] [blame] | 315 | log.Debugw("attempted-to-remove-transacted-revision", log.Fields{"hash": pr.GetHash(), "txid": txid}) |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 316 | } |
Stephane Barbarie | dc5022d | 2018-11-19 15:21:44 -0500 | [diff] [blame] | 317 | |
| 318 | pr.Revision.Drop(txid, includeConfig) |
Stephane Barbarie | 88fbe7f | 2018-09-25 12:25:23 -0400 | [diff] [blame] | 319 | } |