Phaneendra Manda | 4c62c80 | 2019-03-06 21:37:49 +0530 | [diff] [blame] | 1 | # |
| 2 | # Copyright 2016 the original author or authors. |
| 3 | # |
| 4 | # Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | # you may not use this file except in compliance with the License. |
| 6 | # You may obtain a copy of the License at |
| 7 | # |
| 8 | # http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | # |
| 10 | # Unless required by applicable law or agreed to in writing, software |
| 11 | # distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | # See the License for the specific language governing permissions and |
| 14 | # limitations under the License. |
| 15 | # |
| 16 | |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 17 | # set default shell |
| 18 | SHELL = bash -e -o pipefail |
| 19 | |
| 20 | # Variables |
| 21 | VERSION ?= $(shell cat ./VERSION) |
| 22 | |
Matt Jeanneret | f880eb6 | 2019-07-16 20:08:03 -0400 | [diff] [blame] | 23 | DOCKER_LABEL_VCS_DIRTY = false |
| 24 | ifneq ($(shell git ls-files --others --modified --exclude-standard 2>/dev/null | wc -l | sed -e 's/ //g'),0) |
| 25 | DOCKER_LABEL_VCS_DIRTY = true |
| 26 | endif |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 27 | ## Docker related |
Matt Jeanneret | f880eb6 | 2019-07-16 20:08:03 -0400 | [diff] [blame] | 28 | DOCKER_EXTRA_ARGS ?= |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 29 | DOCKER_REGISTRY ?= |
| 30 | DOCKER_REPOSITORY ?= |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 31 | DOCKER_TAG ?= ${VERSION} |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 32 | ADAPTER_IMAGENAME := ${DOCKER_REGISTRY}${DOCKER_REPOSITORY}voltha-openolt-adapter:${DOCKER_TAG} |
Andrea Campanella | cbf583e | 2019-12-17 15:26:00 -0800 | [diff] [blame] | 33 | TYPE ?= minimal |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 34 | |
| 35 | ## Docker labels. Only set ref and commit date if committed |
Matt Jeanneret | f880eb6 | 2019-07-16 20:08:03 -0400 | [diff] [blame] | 36 | DOCKER_LABEL_VCS_URL ?= $(shell git remote get-url $(shell git remote)) |
| 37 | DOCKER_LABEL_VCS_REF = $(shell git rev-parse HEAD) |
| 38 | DOCKER_LABEL_BUILD_DATE ?= $(shell date -u "+%Y-%m-%dT%H:%M:%SZ") |
| 39 | DOCKER_LABEL_COMMIT_DATE = $(shell git show -s --format=%cd --date=iso-strict HEAD) |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 40 | |
Matt Jeanneret | f880eb6 | 2019-07-16 20:08:03 -0400 | [diff] [blame] | 41 | DOCKER_BUILD_ARGS ?= \ |
| 42 | ${DOCKER_EXTRA_ARGS} \ |
| 43 | --build-arg org_label_schema_version="${VERSION}" \ |
| 44 | --build-arg org_label_schema_vcs_url="${DOCKER_LABEL_VCS_URL}" \ |
| 45 | --build-arg org_label_schema_vcs_ref="${DOCKER_LABEL_VCS_REF}" \ |
| 46 | --build-arg org_label_schema_build_date="${DOCKER_LABEL_BUILD_DATE}" \ |
| 47 | --build-arg org_opencord_vcs_commit_date="${DOCKER_LABEL_COMMIT_DATE}" \ |
| 48 | --build-arg org_opencord_vcs_dirty="${DOCKER_LABEL_VCS_DIRTY}" |
| 49 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 50 | # tool containers |
| 51 | VOLTHA_TOOLS_VERSION ?= 1.0.3 |
| 52 | |
| 53 | GO = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -v gocache:/.cache -v gocache-${VOLTHA_TOOLS_VERSION}:/go/pkg voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golang go |
| 54 | GO_JUNIT_REPORT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -i voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-go-junit-report go-junit-report |
| 55 | GOCOVER_COBERTURA = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -i voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-gocover-cobertura gocover-cobertura |
| 56 | GOFMT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golang gofmt |
| 57 | GOLANGCI_LINT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app -v gocache:/.cache -v gocache-${VOLTHA_TOOLS_VERSION}:/go/pkg voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-golangci-lint golangci-lint |
| 58 | HADOLINT = docker run --rm --user $$(id -u):$$(id -g) -v ${CURDIR}:/app voltha/voltha-ci-tools:${VOLTHA_TOOLS_VERSION}-hadolint hadolint |
| 59 | |
Scott Baker | 355d174 | 2019-10-24 10:57:52 -0700 | [diff] [blame] | 60 | .PHONY: docker-build local-protos local-lib-go |
Phaneendra Manda | 4c62c80 | 2019-03-06 21:37:49 +0530 | [diff] [blame] | 61 | |
| 62 | # This should to be the first and default target in this Makefile |
| 63 | help: |
| 64 | @echo "Usage: make [<target>]" |
| 65 | @echo "where available targets are:" |
David Bainbridge | 788e520 | 2019-10-21 18:49:40 +0000 | [diff] [blame] | 66 | @echo "" |
| 67 | @echo "clean : Removes any local filesystem artifacts generated by a build" |
| 68 | @echo "distclean : Removes any local filesystem artifacts generated by a build or test run" |
David Bainbridge | 63d5181 | 2019-10-22 15:55:29 +0000 | [diff] [blame] | 69 | @echo "build : Build all openolt adapter artifacts" |
Zack Williams | 95504be | 2019-09-03 14:17:24 -0700 | [diff] [blame] | 70 | @echo "docker-build : Build openolt adapter docker image" |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 71 | @echo "docker-push : Push the docker images to an external repository" |
David Bainbridge | 788e520 | 2019-10-21 18:49:40 +0000 | [diff] [blame] | 72 | @echo "help : Print this help" |
| 73 | @echo "lint : Run all lint targets" |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 74 | @echo "lint-dockerfile : Perform static analysis on Dockerfiles" |
David Bainbridge | 788e520 | 2019-10-21 18:49:40 +0000 | [diff] [blame] | 75 | @echo "lint-mod : Verify the Go dependencies" |
| 76 | @echo "lint-sanity : Run the Go language sanity tests (vet)" |
| 77 | @echo "lint-style : Verify the Go standard format of the source" |
| 78 | @echo "local-protos : Copies a local verison of the VOLTHA protos into the vendor directory" |
Scott Baker | 355d174 | 2019-10-24 10:57:52 -0700 | [diff] [blame] | 79 | @echo "local-lib-go : Copies a local version of the VOTLHA dependencies into the vendor directory" |
Girish Gowdru | 6a80bbd | 2019-07-02 07:36:09 -0700 | [diff] [blame] | 80 | @echo "sca : Runs various SCA through golangci-lint tool" |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 81 | @echo "test : Run unit tests, if any" |
Phaneendra Manda | 4c62c80 | 2019-03-06 21:37:49 +0530 | [diff] [blame] | 82 | @echo |
| 83 | |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 84 | ## Local Development Helpers |
Phaneendra Manda | 4c62c80 | 2019-03-06 21:37:49 +0530 | [diff] [blame] | 85 | |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 86 | local-protos: |
William Kurkian | ea86948 | 2019-04-09 15:16:11 -0400 | [diff] [blame] | 87 | ifdef LOCAL_PROTOS |
Esin Karaman | ccb714b | 2019-11-29 15:02:06 +0000 | [diff] [blame] | 88 | rm -rf vendor/github.com/opencord/voltha-protos/v3/go |
| 89 | mkdir -p vendor/github.com/opencord/voltha-protos/v3/go |
| 90 | cp -r ${LOCAL_PROTOS}/go/* vendor/github.com/opencord/voltha-protos/v3/go |
| 91 | rm -rf vendor/github.com/opencord/voltha-protos/v3/go/vendor |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 92 | endif |
| 93 | |
Scott Baker | 355d174 | 2019-10-24 10:57:52 -0700 | [diff] [blame] | 94 | ## Local Development Helpers |
| 95 | local-lib-go: |
| 96 | ifdef LOCAL_LIB_GO |
Esin Karaman | ccb714b | 2019-11-29 15:02:06 +0000 | [diff] [blame] | 97 | mkdir -p vendor/github.com/opencord/voltha-lib-go/v3/pkg |
| 98 | cp -r ${LOCAL_LIB_GO}/pkg/* vendor/github.com/opencord/voltha-lib-go/v3/pkg/ |
William Kurkian | ea86948 | 2019-04-09 15:16:11 -0400 | [diff] [blame] | 99 | endif |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 100 | |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 101 | ## Docker targets |
| 102 | |
David Bainbridge | 63d5181 | 2019-10-22 15:55:29 +0000 | [diff] [blame] | 103 | build: docker-build |
| 104 | |
Scott Baker | 355d174 | 2019-10-24 10:57:52 -0700 | [diff] [blame] | 105 | docker-build: local-protos local-lib-go |
David K. Bainbridge | 8eb6cd6 | 2019-08-22 13:17:29 -0700 | [diff] [blame] | 106 | docker build $(DOCKER_BUILD_ARGS) -t ${ADAPTER_IMAGENAME} -f docker/Dockerfile.openolt . |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 107 | |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 108 | docker-push: |
| 109 | docker push ${ADAPTER_IMAGENAME} |
| 110 | |
Andrea Campanella | cbf583e | 2019-12-17 15:26:00 -0800 | [diff] [blame] | 111 | docker-kind-load: |
| 112 | @if [ "`kind get clusters | grep voltha-$(TYPE)`" = '' ]; then echo "no voltha-$(TYPE) cluster found" && exit 1; fi |
| 113 | kind load docker-image ${ADAPTER_IMAGENAME} --name=voltha-$(TYPE) --nodes $(shell kubectl get nodes --template='{{range .items}}{{.metadata.name}},{{end}}' | sed 's/,$$//') |
| 114 | |
| 115 | |
Matt Jeanneret | 8b823f6 | 2019-05-11 11:01:28 -0400 | [diff] [blame] | 116 | ## lint and unit tests |
Phaneendra Manda | 4c62c80 | 2019-03-06 21:37:49 +0530 | [diff] [blame] | 117 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 118 | lint-dockerfile: |
| 119 | @echo "Running Dockerfile lint check ..." |
| 120 | @${HADOLINT} $$(find . -name "Dockerfile.*") |
| 121 | @echo "Dockerfile lint check OK" |
| 122 | |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 123 | lint-style: |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 124 | @echo "Running style check..." |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 125 | @gofmt_out="$$(${GOFMT} -l $$(find . -name '*.go' -not -path './vendor/*'))" ;\ |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 126 | if [ ! -z "$$gofmt_out" ]; then \ |
| 127 | echo "$$gofmt_out" ;\ |
| 128 | echo "Style check failed on one or more files ^, run 'go fmt' to fix." ;\ |
| 129 | exit 1 ;\ |
| 130 | fi |
| 131 | @echo "Style check OK" |
| 132 | |
| 133 | lint-sanity: |
| 134 | @echo "Running sanity check..." |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 135 | @${GO} vet -mod=vendor ./... |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 136 | @echo "Sanity check OK" |
| 137 | |
David Bainbridge | 788e520 | 2019-10-21 18:49:40 +0000 | [diff] [blame] | 138 | lint-mod: |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 139 | @echo "Running dependency check..." |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 140 | @${GO} mod verify |
Scott Baker | 22c0e9c | 2019-11-26 08:11:29 -0800 | [diff] [blame] | 141 | @echo "Dependency check OK. Running vendor check..." |
| 142 | @git status > /dev/null |
| 143 | @git diff-index --quiet HEAD -- go.mod go.sum vendor || (echo "ERROR: Staged or modified files must be committed before running this test" && echo "`git status`" && exit 1) |
| 144 | @[[ `git ls-files --exclude-standard --others go.mod go.sum vendor` == "" ]] || (echo "ERROR: Untracked files must be cleaned up before running this test" && echo "`git status`" && exit 1) |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 145 | ${GO} mod tidy |
| 146 | ${GO} mod vendor |
Scott Baker | 22c0e9c | 2019-11-26 08:11:29 -0800 | [diff] [blame] | 147 | @git status > /dev/null |
| 148 | @git diff-index --quiet HEAD -- go.mod go.sum vendor || (echo "ERROR: Modified files detected after running go mod tidy / go mod vendor" && echo "`git status`" && exit 1) |
| 149 | @[[ `git ls-files --exclude-standard --others go.mod go.sum vendor` == "" ]] || (echo "ERROR: Untracked files detected after running go mod tidy / go mod vendor" && echo "`git status`" && exit 1) |
| 150 | @echo "Vendor check OK." |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 151 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 152 | lint: lint-style lint-sanity lint-mod lint-dockerfile |
David Bainbridge | 788e520 | 2019-10-21 18:49:40 +0000 | [diff] [blame] | 153 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 154 | test: |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 155 | @mkdir -p ./tests/results |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 156 | @${GO} test -mod=vendor -v -coverprofile ./tests/results/go-test-coverage.out -covermode count ./... 2>&1 | tee ./tests/results/go-test-results.out ;\ |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 157 | RETURN=$$? ;\ |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 158 | ${GO_JUNIT_REPORT} < ./tests/results/go-test-results.out > ./tests/results/go-test-results.xml ;\ |
| 159 | ${GOCOVER_COBERTURA} < ./tests/results/go-test-coverage.out > ./tests/results/go-test-coverage.xml ;\ |
Matt Jeanneret | 384d8c9 | 2019-05-06 14:27:31 -0400 | [diff] [blame] | 160 | exit $$RETURN |
| 161 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 162 | sca: |
Girish Gowdru | 6a80bbd | 2019-07-02 07:36:09 -0700 | [diff] [blame] | 163 | @mkdir -p ./sca-report |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 164 | @echo "Running static code analysis..." |
| 165 | @${GOLANGCI_LINT} run --deadline=4m --out-format junit-xml ./... | tee ./sca-report/sca-report.xml |
| 166 | @echo "Static code analysis OK" |
Girish Gowdru | 6a80bbd | 2019-07-02 07:36:09 -0700 | [diff] [blame] | 167 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 168 | clean: distclean |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 169 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 170 | distclean: |
| 171 | rm -rf ./sca-report |
Matt Jeanneret | b5bf10e | 2019-05-18 15:02:51 -0400 | [diff] [blame] | 172 | |
Kent Hagerman | 2cd4b7b | 2020-02-04 15:15:14 -0500 | [diff] [blame] | 173 | mod-update: |
| 174 | ${GO} mod tidy |
| 175 | ${GO} mod vendor |